Skip to content

Conversation

Ahmad-S792
Copy link
Contributor

@Ahmad-S792 Ahmad-S792 commented Dec 30, 2023

d13d145

Simplify RenderLayer::setParent

https://bugs.webkit.org/show_bug.cgi?id=266851

Reviewed by Antti Koivisto.

Merge: https://chromium.googlesource.com/chromium/blink/+/34436ac331a767eded6b60bc2b68cbcc5d8cb163

There's no need call these functions on RenderLayerCompositor.
RenderLayer::addChild and RenderLayer::removeChild already call them.

* Source/WebCore/rendering/RenderLayer.cpp:
(RenderLayer::addChild):
(RenderLayer::removeChild):
(RenderLayer::setParent): Deleted
(RenderLayer::createReflection):
(RenderLayer::removeReflection):
* Source/WebCore/rendering/RenderLayer.h:

Canonical link: https://commits.webkit.org/272566@main

f1c5b28

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@Ahmad-S792 Ahmad-S792 added the Layout and Rendering For bugs with layout and rendering of Web pages. label Dec 30, 2023
@Ahmad-S792 Ahmad-S792 self-assigned this Dec 30, 2023
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Dec 30, 2023
@Ahmad-S792 Ahmad-S792 removed the merging-blocked Applied to prevent a change from being merged label Dec 30, 2023
@Ahmad-S792 Ahmad-S792 marked this pull request as ready for review December 30, 2023 14:42
@Ahmad-S792 Ahmad-S792 added the merge-queue Applied to send a pull request to merge-queue label Jan 2, 2024
https://bugs.webkit.org/show_bug.cgi?id=266851

Reviewed by Antti Koivisto.

Merge: https://chromium.googlesource.com/chromium/blink/+/34436ac331a767eded6b60bc2b68cbcc5d8cb163

There's no need call these functions on RenderLayerCompositor.
RenderLayer::addChild and RenderLayer::removeChild already call them.

* Source/WebCore/rendering/RenderLayer.cpp:
(RenderLayer::addChild):
(RenderLayer::removeChild):
(RenderLayer::setParent): Deleted
(RenderLayer::createReflection):
(RenderLayer::removeReflection):
* Source/WebCore/rendering/RenderLayer.h:

Canonical link: https://commits.webkit.org/272566@main
@webkit-commit-queue webkit-commit-queue force-pushed the fix266851-simplifcation-setParent branch from f1c5b28 to d13d145 Compare January 2, 2024 12:40
@webkit-commit-queue webkit-commit-queue merged commit d13d145 into WebKit:main Jan 2, 2024
@webkit-commit-queue
Copy link
Collaborator

Committed 272566@main (d13d145): https://commits.webkit.org/272566@main

Reviewed commits have been landed. Closing PR #22271 and removing active labels.

@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jan 2, 2024
@Ahmad-S792 Ahmad-S792 deleted the fix266851-simplifcation-setParent branch January 8, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Layout and Rendering For bugs with layout and rendering of Web pages.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants