[GPUP] Chinese text in language selector in Google News is invisible #2355
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
litherum
added
Text
heycam
approved these changes
Jul 13, 2022
Comment on lines
+1569
to
+1570
There was a problem hiding this comment.
Can we assert in here that if platformData is not substituteFont, then it's an installed font?
There was a problem hiding this comment.
Hrmmm I don't see a way to do that 🤔
There was a problem hiding this comment.
I'll land as-is and in parallel discuss with the Core Text team.
webkit-early-warning-system
added
the
merging-blocked
litherum
added
merge-queue
https://bugs.webkit.org/show_bug.cgi?id=242674 <rdar://problem/96903146> Reviewed by Cameron McCormack. When falling off the end of the font-family list, the browser needs to pick some font which can render the requested character. Font selection routines accept a "hint" font, which it tries to match as stylistically closely as possible. The hint font itself may actually be selected - if it is, we have to make sure the fallback font takes the CreationData from the hint font. However, if the hint font is not selected, then the fallback font will be guaranteed to be an installed font, which means that no CreationData should be specified. 252096@main had some of this logic, but not all of it. * LayoutTests/fast/text/fallback-not-supported-expected-mismatch.html: Added. * LayoutTests/fast/text/fallback-not-supported.html: Added. * Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp: (WebCore::FontCache::systemFallbackForCharacters): Canonical link: https://commits.webkit.org/252407@main
webkit-early-warning-system
force-pushed
the
eng/GPUP-Chinese-text-in-language-selector-in-Google-News-is-invisible
branch
from
26b14c3 to
457dbbe
Compare
|
Committed 252407@main (457dbbe): https://commits.webkit.org/252407@main Reviewed commits have been landed. Closing PR #2355 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
litherum
deleted the
eng/GPUP-Chinese-text-in-language-selector-in-Google-News-is-invisible
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
457dbbe