[JSC] Port IPInt entry/exit to armv7 #24246

eugeneia · 2024-02-12T12:30:01Z

`474074a`

[JSC] Port IPInt entry/exit to armv7
https://bugs.webkit.org/show_bug.cgi?id=269187

Reviewed by Justin Michaud.

This ports the entry and exit sequences of IPInt to armv7.

With these changes we can run a basic empty WASM function
test case.

Further changes are needed to add individual instruction
implementations.

* Source/JavaScriptCore/llint/InPlaceInterpreter.asm:
* Source/JavaScriptCore/wasm/WasmIPIntGenerator.cpp:
(JSC::Wasm::IPIntGenerator::addCallCommonData):

Canonical link: https://commits.webkit.org/275185@main

a1ce01e

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 gtk
✅ 🛠 🧪 jsc	~~🧪 api-ios~~	✅ 🧪 mac-wk2	✅ 🧪 gtk-wk2
✅ 🛠 🧪 jsc-arm64	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv-sim		✅ 🛠 jsc-armv7
✅ 🛠 🧪 merge	✅ 🛠 watch		✅ 🧪 jsc-armv7-tests
	✅ 🛠 watch-sim

webkit-early-warning-system · 2024-02-12T12:30:11Z

EWS run on previous version of this PR (hash ad131f0)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	❌ 🛠 wincairo
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 gtk
✅ 🛠 🧪 jsc	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 gtk-wk2
✅ 🛠 🧪 jsc-arm64	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv-sim		✅ 🛠 jsc-armv7
	✅ 🛠 watch		✅ 🧪 jsc-armv7-tests
	✅ 🛠 watch-sim

justinmichaud

r=me

webkit-early-warning-system · 2024-02-15T12:11:12Z

EWS run on previous version of this PR (hash b50526e)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	❌ 🛠 wincairo
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	⏳ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	~~🧪 api-mac~~	~~🧪 api-wpe~~
	⏳ 🧪 ios-wk2-wpt	~~🧪 mac-wk1~~	✅ 🛠 gtk
~~🛠 🧪 jsc~~	⏳ 🧪 api-ios	~~🧪 mac-wk2~~	~~🧪 gtk-wk2~~
✅ 🛠 🧪 jsc-arm64	✅ 🛠 tv	~~🧪 mac-AS-debug-wk2~~	⏳ 🧪 api-gtk
	✅ 🛠 tv-sim		✅ 🛠 jsc-armv7
	✅ 🛠 watch		⏳ 🧪 jsc-armv7-tests
	✅ 🛠 watch-sim

webkit-early-warning-system · 2024-02-15T12:40:32Z

EWS run on previous version of this PR (hash 0d2adcc)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	❌ 🛠 wincairo
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	~~🧪 ios-wk2-wpt~~	✅ 🧪 mac-wk1	✅ 🛠 gtk
✅ 🛠 🧪 jsc	✅ 🧪 api-ios	✅ 🧪 mac-wk2	~~🧪 gtk-wk2~~
✅ 🛠 🧪 jsc-arm64	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2	⏳ 🧪 api-gtk
	✅ 🛠 tv-sim		✅ 🛠 jsc-armv7
	✅ 🛠 watch		❌ 🧪 jsc-armv7-tests
	✅ 🛠 watch-sim

webkit-early-warning-system · 2024-02-15T13:40:56Z

EWS run on previous version of this PR (hash 4e36617)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	❌ 🛠 wincairo
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 gtk
✅ 🛠 🧪 jsc	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 gtk-wk2
✅ 🛠 🧪 jsc-arm64	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv-sim		✅ 🛠 jsc-armv7
	✅ 🛠 watch		❌ 🧪 jsc-armv7-tests
	✅ 🛠 watch-sim

eugeneia · 2024-02-16T10:55:34Z

Hadn't really considered windows yet, I need to do some thinking how to handle the X86_64_WIN case which is currently entirely unsupported just like ARM.

webkit-early-warning-system · 2024-02-20T13:20:30Z

EWS run on previous version of this PR (hash 48c50cd)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	❌ 🛠 wincairo
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 gtk
✅ 🛠 🧪 jsc	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 gtk-wk2
✅ 🛠 🧪 jsc-arm64	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv-sim		✅ 🛠 jsc-armv7
	✅ 🛠 watch		✅ 🧪 jsc-armv7-tests
	✅ 🛠 watch-sim

webkit-early-warning-system · 2024-02-21T22:38:49Z

EWS run on previous version of this PR (hash 787d414)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
❌ 🧪 style	❌ 🛠 ios	❌ 🛠 mac	❌ 🛠 wpe	❌ 🛠 wincairo
	❌ 🛠 ios-sim	❌ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2
❌ 🧪 webkitperl	❌ 🧪 ios-wk2	❌ 🧪 api-mac	❌ 🧪 api-wpe
	❌ 🧪 ios-wk2-wpt	❌ 🧪 mac-wk1	❌ 🛠 gtk
~~🛠 🧪 jsc~~	❌ 🧪 api-ios	❌ 🧪 mac-wk2	❌ 🧪 gtk-wk2
~~🛠 🧪 jsc-arm64~~	~~🛠 tv~~	❌ 🧪 mac-AS-debug-wk2	❌ 🧪 api-gtk
	~~🛠 tv-sim~~	❌ 🧪 mac-wk2-stress	~~🛠 jsc-armv7~~
	~~🛠 watch~~		~~🧪 jsc-armv7-tests~~
	~~🛠 watch-sim~~

webkit-early-warning-system · 2024-02-21T22:40:03Z

EWS run on previous version of this PR (hash 0c148a6)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
❌ 🧪 style	❌ 🛠 ios	❌ 🛠 mac	❌ 🛠 wpe	❌ 🛠 wincairo
	❌ 🛠 ios-sim	❌ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2
❌ 🧪 webkitperl	❌ 🧪 ios-wk2	❌ 🧪 api-mac	❌ 🧪 api-wpe
	❌ 🧪 ios-wk2-wpt	❌ 🧪 mac-wk1	❌ 🛠 gtk
❌ 🛠 🧪 jsc	❌ 🧪 api-ios	❌ 🧪 mac-wk2	❌ 🧪 gtk-wk2
❌ 🛠 🧪 jsc-arm64	❌ 🛠 tv	❌ 🧪 mac-AS-debug-wk2	❌ 🧪 api-gtk
	❌ 🛠 tv-sim	❌ 🧪 mac-wk2-stress	❌ 🛠 jsc-armv7
	❌ 🛠 watch		❌ 🧪 jsc-armv7-tests
	❌ 🛠 watch-sim

webkit-early-warning-system · 2024-02-22T12:42:05Z

EWS run on current version of this PR (hash a1ce01e)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 gtk
✅ 🛠 🧪 jsc	~~🧪 api-ios~~	✅ 🧪 mac-wk2	✅ 🧪 gtk-wk2
✅ 🛠 🧪 jsc-arm64	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv-sim		✅ 🛠 jsc-armv7
✅ 🛠 🧪 merge	✅ 🛠 watch		✅ 🧪 jsc-armv7-tests
	✅ 🛠 watch-sim

eugeneia · 2024-02-22T16:35:29Z

Ok I resolved the windows build failure by temporarily duplicating the stubs for armv7 instead of changing the existing stubs for unimplemented architectures (which happen to be relied by the windows build too).

Should be good to go if EWS says green.

https://bugs.webkit.org/show_bug.cgi?id=269187 Reviewed by Justin Michaud. This ports the entry and exit sequences of IPInt to armv7. With these changes we can run a basic empty WASM function test case. Further changes are needed to add individual instruction implementations. * Source/JavaScriptCore/llint/InPlaceInterpreter.asm: * Source/JavaScriptCore/wasm/WasmIPIntGenerator.cpp: (JSC::Wasm::IPIntGenerator::addCallCommonData): Canonical link: https://commits.webkit.org/275185@main

webkit-commit-queue · 2024-02-22T18:18:58Z

Committed 275185@main (474074a): https://commits.webkit.org/275185@main

Reviewed commits have been landed. Closing PR #24246 and removing active labels.

eugeneia requested a review from a team as a code owner February 12, 2024 12:30

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Feb 12, 2024

justinmichaud approved these changes Feb 12, 2024

View reviewed changes

eugeneia force-pushed the eng/ipint-armv7-entry branch from ad131f0 to b50526e Compare February 15, 2024 12:11

eugeneia force-pushed the eng/ipint-armv7-entry branch from b50526e to 0d2adcc Compare February 15, 2024 12:37

eugeneia force-pushed the eng/ipint-armv7-entry branch from 0d2adcc to 4e36617 Compare February 15, 2024 13:40

eugeneia force-pushed the eng/ipint-armv7-entry branch from 4e36617 to 48c50cd Compare February 20, 2024 13:20

eugeneia force-pushed the eng/ipint-armv7-entry branch from 48c50cd to 787d414 Compare February 21, 2024 22:38

eugeneia force-pushed the eng/ipint-armv7-entry branch from 787d414 to 0c148a6 Compare February 21, 2024 22:39

eugeneia force-pushed the eng/ipint-armv7-entry branch from 0c148a6 to a1ce01e Compare February 22, 2024 12:41

jjgriego added merge-queue Applied to send a pull request to merge-queue and removed merging-blocked Applied to prevent a change from being merged labels Feb 22, 2024

webkit-commit-queue force-pushed the eng/ipint-armv7-entry branch from a1ce01e to 474074a Compare February 22, 2024 18:18

webkit-commit-queue merged commit 474074a into WebKit:main Feb 22, 2024

webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Feb 22, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[JSC] Port IPInt entry/exit to armv7 #24246

[JSC] Port IPInt entry/exit to armv7 #24246

eugeneia commented Feb 12, 2024 •

edited by webkit-early-warning-system

Loading

Uh oh!

webkit-early-warning-system commented Feb 12, 2024 •

edited

Loading

Uh oh!

justinmichaud left a comment

Uh oh!

webkit-early-warning-system commented Feb 15, 2024 •

edited

Loading

Uh oh!

webkit-early-warning-system commented Feb 15, 2024 •

edited

Loading

Uh oh!

webkit-early-warning-system commented Feb 15, 2024 •

edited

Loading

Uh oh!

eugeneia commented Feb 16, 2024

Uh oh!

webkit-early-warning-system commented Feb 20, 2024 •

edited

Loading

Uh oh!

webkit-early-warning-system commented Feb 21, 2024 •

edited

Loading

Uh oh!

webkit-early-warning-system commented Feb 21, 2024 •

edited

Loading

Uh oh!

webkit-early-warning-system commented Feb 22, 2024 •

edited

Loading

Uh oh!

eugeneia commented Feb 22, 2024

Uh oh!

webkit-commit-queue commented Feb 22, 2024

Uh oh!

Uh oh!

[JSC] Port IPInt entry/exit to armv7 #24246

[JSC] Port IPInt entry/exit to armv7 #24246

Conversation

eugeneia commented Feb 12, 2024 • edited by webkit-early-warning-system Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

474074a

Uh oh!

webkit-early-warning-system commented Feb 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

justinmichaud left a comment

Choose a reason for hiding this comment

Uh oh!

webkit-early-warning-system commented Feb 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Feb 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Feb 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

eugeneia commented Feb 16, 2024

Uh oh!

webkit-early-warning-system commented Feb 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Feb 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Feb 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Feb 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

eugeneia commented Feb 22, 2024

Uh oh!

webkit-commit-queue commented Feb 22, 2024

Uh oh!

Uh oh!

eugeneia commented Feb 12, 2024 •

edited by webkit-early-warning-system

Loading

`474074a`

webkit-early-warning-system commented Feb 12, 2024 •

edited

Loading

webkit-early-warning-system commented Feb 15, 2024 •

edited

Loading

webkit-early-warning-system commented Feb 15, 2024 •

edited

Loading

webkit-early-warning-system commented Feb 15, 2024 •

edited

Loading

webkit-early-warning-system commented Feb 20, 2024 •

edited

Loading

webkit-early-warning-system commented Feb 21, 2024 •

edited

Loading

webkit-early-warning-system commented Feb 21, 2024 •

edited

Loading

webkit-early-warning-system commented Feb 22, 2024 •

edited

Loading