Disable OffscreenCanvasRenderingContext2D's commit() method by default #27196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
webkit-ews-buildbot
added
the
merging-blocked
annevk
force-pushed
the
eng/Remove-OffscreenCanvasRenderingContext2Ds-commit-method
branch
from
ccbdfb7 to
84dfc72
Compare
This comment was marked as outdated.
This comment was marked as outdated.
annevk
changed the title
annevk
force-pushed
the
eng/Remove-OffscreenCanvasRenderingContext2Ds-commit-method
branch
from
84dfc72 to
8205e40
Compare
This comment was marked as outdated.
This comment was marked as outdated.
webkit-ews-buildbot
added
the
merging-blocked
annevk
force-pushed
the
eng/Remove-OffscreenCanvasRenderingContext2Ds-commit-method
branch
from
8205e40 to
4bc054f
Compare
|
EWS run on previous version of this PR (hash 4bc054f) |
webkit-ews-buildbot
added
the
merging-blocked
Kaiido
added a commit
to Kaiido/content
that referenced
this pull request
Apr 18, 2024
This method has been removed in whatwg/html#9979 The placeholder <canvas>'s bitmap is now updated during the "update the rendering" steps of the Worker or Window's event-loop that owns the OffscreenCanvas object. Not sure how to formulate that clearly. This method has been (partially) implemented in 2 browsers before it got removed, but at least Safari is in the process of removing it (WebKit/WebKit#27196), and there may be another method with the same name coming later. So it's not clear if simply removing the method's page like that is fine or if it would be better to keep it with a deprecation notice instead? Compat table would also need to be updated, but I'll wait for a position on the above question. Also, while I was on that page I fixed an approximative wording, and the position of the roundRect() method. 8a4754d7ba
This was referenced Apr 18, 2024
Kaiido
added a commit
to Kaiido/content
that referenced
this pull request
Apr 19, 2024
This method has been removed in whatwg/html#9979 The placeholder <canvas>'s bitmap is now updated during the "update the rendering" steps of the Worker or Window's event-loop that owns the OffscreenCanvas object. Not sure how to formulate that clearly. This method has been (partially) implemented in 2 browsers before it got removed, but at least Safari is in the process of removing it (WebKit/WebKit#27196), and there may be another method with the same name coming later. So it's not clear if simply removing the method's page like that is fine or if it would be better to keep it with a deprecation notice instead? Compat table would also need to be updated, but I'll wait for a position on the above question. Also, while I was on that page I fixed an approximative wording, and the position of the roundRect() method.
mattwoodrow
approved these changes
Apr 25, 2024
wbamberg
added a commit
to mdn/content
that referenced
this pull request
Apr 25, 2024
* Deprecate OffscreenCanvas2D's commit() method This method has been removed in whatwg/html#9979 The placeholder <canvas>'s bitmap is now updated during the "update the rendering" steps of the Worker or Window's event-loop that owns the OffscreenCanvas object. Not sure how to formulate that clearly. This method has been (partially) implemented in 2 browsers before it got removed, but at least Safari is in the process of removing it (WebKit/WebKit#27196), and there may be another method with the same name coming later. So it's not clear if simply removing the method's page like that is fine or if it would be better to keep it with a deprecation notice instead? Compat table would also need to be updated, but I'll wait for a position on the above question. Also, while I was on that page I fixed an approximative wording, and the position of the roundRect() method. * Better wording from suggestion Co-authored-by: wbamberg <will@bootbonnet.ca> * remove deprecation macros as per comments These should hopefully be added back once mdn/browser-compat-data#22878 is merged --------- Co-authored-by: wbamberg <will@bootbonnet.ca> Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com>
annevk
force-pushed
the
eng/Remove-OffscreenCanvasRenderingContext2Ds-commit-method
branch
from
4bc054f to
7cb3f4b
Compare
|
EWS run on current version of this PR (hash 7cb3f4b) |
🛠 mac-AS-debug
annevk
added
the
unsafe-merge-queue
https://bugs.webkit.org/show_bug.cgi?id=272591 rdar://126758254 Reviewed by Matt Woodrow. This puts OffscreenCanvasRenderingContext2D's commit() behind a runtime setting marked testable (OffscreenCanvasDeprecatedCommitEnabled). This ensures this method continues to be tested for the time being and can be re-enabled should there be a need. The goal is to remove this method and underlying implementation completely as discussed here: whatwg/html#9979 * LayoutTests/inspector/canvas/recording-offscreen-canvas-2d-full-expected.txt: * LayoutTests/inspector/canvas/resources/recording-2d.js: * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: * Source/WebCore/html/canvas/OffscreenCanvasRenderingContext2D.idl: Canonical link: https://commits.webkit.org/278047@main
webkit-commit-queue
force-pushed
the
eng/Remove-OffscreenCanvasRenderingContext2Ds-commit-method
branch
from
7cb3f4b to
f8cecb9
Compare
|
Committed 278047@main (f8cecb9): https://commits.webkit.org/278047@main Reviewed commits have been landed. Closing PR #27196 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
annevk
deleted the
eng/Remove-OffscreenCanvasRenderingContext2Ds-commit-method
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
f8cecb9
7cb3f4b
🛠 🧪 jsc-arm64