Skip to content

Safari crashes in WebKit::PlaybackSessionInterfaceLMK::seekableRangesChanged on visionOS Simulator #27292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 16, 2024
Merged

Safari crashes in WebKit::PlaybackSessionInterfaceLMK::seekableRangesChanged on visionOS Simulator #27292

merged 1 commit into from
Apr 16, 2024

Conversation

aestes
Copy link
Contributor

@aestes aestes commented Apr 15, 2024 •
edited by webkit-early-warning-system
Loading

d9472ab

Safari crashes in WebKit::PlaybackSessionInterfaceLMK::seekableRangesChanged on visionOS Simulator
https://bugs.webkit.org/show_bug.cgi?id=272714
rdar://126230504

Reviewed by Richard Robinson.

Since WebKitSwift is currently not available in visionOS Simulator, disable the LinearMediaPlayer
feature on that platform.

* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:

Canonical link: https://commits.webkit.org/277558@main

9526203

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt   🧪 mac-wk1 ✅ 🛠 wpe-skia
✅ 🛠 🧪 jsc ✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv-sim ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🛠 watch ✅ 🛠 jsc-armv7
✅ 🛠 watch-sim ✅ 🧪 jsc-armv7-tests

@aestes aestes self-assigned this Apr 15, 2024
@aestes aestes added the Media Bugs related to the HTML 5 Media elements. label Apr 15, 2024
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Apr 15, 2024 •
edited
Loading

EWS run on current version of this PR (hash 9526203)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt   🧪 mac-wk1 ✅ 🛠 wpe-skia
✅ 🛠 🧪 jsc ✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv-sim ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🛠 watch ✅ 🛠 jsc-armv7
✅ 🛠 watch-sim ✅ 🧪 jsc-armv7-tests

@aestes aestes requested a review from a team April 15, 2024 23:28
@aestes aestes added safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks merge-queue Applied to send a pull request to merge-queue and removed safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks labels Apr 16, 2024
@aestes
Safari crashes in WebKit::PlaybackSessionInterfaceLMK::seekableRanges…
d9472ab 
…Changed on visionOS Simulator

https://bugs.webkit.org/show_bug.cgi?id=272714
rdar://126230504

Reviewed by Richard Robinson.

Since WebKitSwift is currently not available in visionOS Simulator, disable the LinearMediaPlayer
feature on that platform.

* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:

Canonical link: https://commits.webkit.org/277558@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Safari-crashes-in-WebKitPlaybackSessionInterfaceLMKseekableRangesChanged-on-visionOS-Simulator branch from 9526203 to d9472ab Compare April 16, 2024 18:10
@webkit-commit-queue
Copy link
Collaborator

Committed 277558@main (d9472ab): https://commits.webkit.org/277558@main

Reviewed commits have been landed. Closing PR #27292 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit d9472ab into WebKit:main Apr 16, 2024
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Apr 16, 2024
@aestes aestes deleted the eng/Safari-crashes-in-WebKitPlaybackSessionInterfaceLMKseekableRangesChanged-on-visionOS-Simulator branch August 25, 2025 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rr-codes rr-codes rr-codes approved these changes

Assignees

@aestes aestes

Labels

Media Bugs related to the HTML 5 Media elements.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@aestes @webkit-early-warning-system @webkit-commit-queue @rr-codes