Skip to content

Conversation

JonWBedard
Copy link
Member

@JonWBedard JonWBedard commented Apr 12, 2022

b191a69

[commits.webkit.org] Change branch forwarding behavior
https://bugs.webkit.org/show_bug.cgi?id=239136
<rdar://problem/91314217 >

Reviewed by Dewei Zhu.

* Tools/Scripts/libraries/reporelaypy/reporelaypy/__init__.py: Bump version.
* Tools/Scripts/libraries/reporelaypy/setup.py: Ditto.
* Tools/Scripts/libraries/reporelaypy/reporelaypy/checkout.py:
(Checkout.Encoder.default): Encode forwarding list.
(Checkout.__init__): Add forwarding argument.
(Checkout.push_update): Add dest_branch argument.
(Checkout.forward_update): Trigger push_update based on forwarding arguments.
(Checkout.update_all): Use forward_update instead of pushing to every branch.
* Tools/Scripts/libraries/reporelaypy/reporelaypy/hooks.py:
(HookProcessor.process_worker_hook): Extract remote from incoming data, invoke forward_update.
* Tools/Scripts/libraries/reporelaypy/reporelaypy/tests/checkout_unittest.py:
(CheckoutUnittest.test_json):

Canonical link: https://commits.webkit.org/250045@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@293514 268f45cc-cd09-0410-ab3c-d52691b4dbfc

@JonWBedard JonWBedard self-assigned this Apr 12, 2022
@JonWBedard JonWBedard added Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases WebKit Nightly Build labels Apr 12, 2022
@JonWBedard JonWBedard requested review from dewei-zhu and akath20 April 12, 2022 19:08
Copy link
Contributor

@dewei-zhu dewei-zhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me with comment.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function name sounds like it will return a boolean, but it's a void function. Maybe forward_update or if you have more accurate function name?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will change, that's better terminology

@JonWBedard JonWBedard force-pushed the eng/commits-webkit-org-Change-branch-forwarding-behavior branch 3 times, most recently from 9581c86 to b921439 Compare April 27, 2022 16:38
@JonWBedard JonWBedard added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Apr 27, 2022
@webkit-early-warning-system webkit-early-warning-system force-pushed the eng/commits-webkit-org-Change-branch-forwarding-behavior branch from b921439 to b191a69 Compare April 27, 2022 17:12
@webkit-early-warning-system webkit-early-warning-system merged commit b191a69 into WebKit:main Apr 27, 2022
@webkit-early-warning-system
Copy link
Collaborator

Committed r293514 (250045@main): https://commits.webkit.org/250045@main

Reviewed commits have been landed. Closing PR #276 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Apr 27, 2022
@JonWBedard JonWBedard deleted the eng/commits-webkit-org-Change-branch-forwarding-behavior branch May 19, 2022 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants