Skip to content

Unreviewed, reverting 277816@main #27676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 24, 2024
Merged

Unreviewed, reverting 277816@main #27676

merged 1 commit into from
Apr 24, 2024

Conversation

cdumez
Copy link
Contributor

@cdumez cdumez commented Apr 24, 2024 •
edited by webkit-early-warning-system
Loading

0c23d38

Unreviewed, reverting 277816@main
https://bugs.webkit.org/show_bug.cgi?id=273168
rdar://126927058

Unreviewed, revert 277816@main as it seems to have broken roots install

Reverted change:

    Change install location of WebKit process extensions
    https://bugs.webkit.org/show_bug.cgi?id=268946
    rdar://126613034
    https://commits.webkit.org/277816@main

Canonical link: https://commits.webkit.org/277918@main

2e2600b

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🛠 wpe-skia
  🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress   🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@cdumez cdumez requested a review from emw-apple as a code owner April 24, 2024 05:06
@cdumez cdumez self-assigned this Apr 24, 2024
@cdumez cdumez added the WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore). label Apr 24, 2024
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Apr 24, 2024 •
edited
Loading

EWS run on current version of this PR (hash 2e2600b)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt loading 🧪 mac-wk1 ✅ 🛠 wpe-skia
  🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress   🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@cdumez cdumez added the merge-queue Applied to send a pull request to merge-queue label Apr 24, 2024
@cdumez
Unreviewed, reverting 277816@main
0c23d38 
https://bugs.webkit.org/show_bug.cgi?id=273168
rdar://126927058

Unreviewed, revert 277816@main as it seems to have broken roots install

Reverted change:

    Change install location of WebKit process extensions
    https://bugs.webkit.org/show_bug.cgi?id=268946
    rdar://126613034
    https://commits.webkit.org/277816@main

Canonical link: https://commits.webkit.org/277918@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Unreviewed-revert-277816main-as-it-seems-to-have-broken-roots-install branch from 2e2600b to 0c23d38 Compare April 24, 2024 06:55
@webkit-commit-queue
Copy link
Collaborator

Committed 277918@main (0c23d38): https://commits.webkit.org/277918@main

Reviewed commits have been landed. Closing PR #27676 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 0c23d38 into WebKit:main Apr 24, 2024
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emw-apple emw-apple Awaiting requested review from emw-apple emw-apple is a code owner

Assignees

@cdumez cdumez

Labels
WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cdumez @webkit-early-warning-system @webkit-commit-queue