Misc compiler warnings, April 2022 edition

[mcatanzaro]

832b6c0

Misc compiler warnings, April 2022 edition
https://bugs.webkit.org/show_bug.cgi?id=239290

Patch by Michael Catanzaro <mcatanzaro@gnome.org > on 2022-04-13
Reviewed by Adrian Perez de Castro.

Fix the usual spam of -Wreturn-type warnings.

Bonus warnings: unused variable, unknown pragmas, and redundant move.

* Source/JavaScriptCore/bytecode/PropertyCondition.cpp:
(JSC::PropertyCondition::isStillValidAssumingImpurePropertyWatchpoint const):
(JSC::watchabilityToConcurrency):
(JSC::PropertyCondition::validityRequiresImpurePropertyWatchpoint const):
* Source/JavaScriptCore/runtime/JSObject.h:
(JSC::JSObject::getDirect const):
* Source/JavaScriptCore/runtime/Structure.h:
(JSC::Structure::get):
* Source/WebKit/NetworkProcess/storage/OriginStorageManager.cpp:
(WebKit::OriginStorageManager::StorageBucket::resolvedPath):
* Source/WebCore/dom/ScriptExecutionContext.cpp:
(WebCore::ScriptExecutionContext::canAccessResource const):
* Source/WebCore/page/DebugPageOverlays.cpp:
* Source/WebCore/page/InteractionRegion.cpp:
(WebCore::regionForElement):
* Source/WebCore/platform/graphics/GraphicsContextState.cpp:
(WebCore::stateChangeName):
* Source/WebCore/rendering/style/RenderStyle.cpp:
(WebCore::getPathFromPathOperation):
* Source/WebCore/style/ContainerQueryEvaluator.cpp:
(WebCore::Style::ContainerQueryEvaluator::evaluateSizeFeature const):
* Source/WebCore/testing/Internals.cpp:
(WebCore::Internals::categoryAtMostRecentPlayback const):

Canonical link: https://commits.webkit.org/249613@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@292840 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[Constellation]

Looks like issue's content is different from the other PRs.
Is this PR created via git webkit pr?

[mcatanzaro]

Is this PR created via git webkit pr?

Nope, see https://bugs.webkit.org/show_bug.cgi?id=239296

[webkit-early-warning-system]

Committed r292840 (249613@main): https://commits.webkit.org/249613@main

Reviewed commits have been landed. Closing PR #282 and removing active labels.