Skip to content

[WPE] WPE Platform: add support for loading external platforms #29301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 3, 2024
Merged

[WPE] WPE Platform: add support for loading external platforms #29301

merged 1 commit into from
Jun 3, 2024

Conversation

carlosgcampos
Copy link
Contributor

@carlosgcampos carlosgcampos commented May 30, 2024 •
edited by webkit-early-warning-system
Loading

d8b7a2f

[WPE] WPE Platform: add support for loading external platforms
https://bugs.webkit.org/show_bug.cgi?id=265641

Reviewed by Adrian Perez de Castro.

* Source/WebKit/WPEPlatform/CMakeLists.txt:
* Source/WebKit/WPEPlatform/wpe-platform.pc.in:
* Source/WebKit/WPEPlatform/wpe/WPEExtensions.cpp:
(wpeEnsureExtensionPointsLoaded):

Canonical link: https://commits.webkit.org/279640@main

1ac6c7d

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 wincairo-tests
✅ 🧪 webkitperl   🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 tv   🧪 mac-AS-debug-wk2   🧪 gtk-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

@carlosgcampos carlosgcampos requested review from a team and zdobersek as code owners May 30, 2024 12:02
@carlosgcampos carlosgcampos self-assigned this May 30, 2024
@carlosgcampos carlosgcampos added the WPE WebKit WebKit WPE component label May 30, 2024
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented May 30, 2024 •
edited
Loading

EWS run on previous version of this PR (hash e9244dd)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 wincairo-tests
✅ 🧪 webkitperl ❌ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 watch
✅ 🛠 watch-sim

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label May 30, 2024
aperezdc
aperezdc approved these changes May 31, 2024
View reviewed changes
Copy link
Contributor

@aperezdc aperezdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a nit.

@carlosgcampos carlosgcampos removed the merging-blocked Applied to prevent a change from being merged label Jun 3, 2024
@carlosgcampos carlosgcampos force-pushed the wpe-platform-external-modules branch from e9244dd to 1ac6c7d Compare June 3, 2024 08:52
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jun 3, 2024 •
edited
Loading

EWS run on current version of this PR (hash 1ac6c7d)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 wincairo-tests
✅ 🧪 webkitperl   🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 tv   🧪 mac-AS-debug-wk2   🧪 gtk-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

@carlosgcampos carlosgcampos added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jun 3, 2024
@webkit-commit-queue webkit-commit-queue force-pushed the wpe-platform-external-modules branch from 1ac6c7d to 486935b Compare June 3, 2024 10:25
@carlosgcampos
[WPE] WPE Platform: add support for loading external platforms
d8b7a2f 
https://bugs.webkit.org/show_bug.cgi?id=265641

Reviewed by Adrian Perez de Castro.

* Source/WebKit/WPEPlatform/CMakeLists.txt:
* Source/WebKit/WPEPlatform/wpe-platform.pc.in:
* Source/WebKit/WPEPlatform/wpe/WPEExtensions.cpp:
(wpeEnsureExtensionPointsLoaded):

Canonical link: https://commits.webkit.org/279640@main
@webkit-commit-queue webkit-commit-queue force-pushed the wpe-platform-external-modules branch from 486935b to d8b7a2f Compare June 3, 2024 10:27
@webkit-commit-queue
Copy link
Collaborator

Committed 279640@main (d8b7a2f): https://commits.webkit.org/279640@main

Reviewed commits have been landed. Closing PR #29301 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit d8b7a2f into WebKit:main Jun 3, 2024
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jun 3, 2024
@carlosgcampos carlosgcampos deleted the wpe-platform-external-modules branch June 3, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aperezdc aperezdc aperezdc approved these changes

@zdobersek zdobersek Awaiting requested review from zdobersek

Assignees

@carlosgcampos carlosgcampos

Labels

WPE WebKit WebKit WPE component

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@carlosgcampos @webkit-early-warning-system @webkit-commit-queue @aperezdc @zhani @webkit-ews-buildbot