-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Access a WebPageProxy's WebProcessPool through its configuration instead of its main frame process #29649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
EWS run on previous version of this PR (hash 480c810) |
480c810
to
3a74c0d
Compare
EWS run on previous version of this PR (hash 3a74c0d)
|
3a74c0d
to
3123233
Compare
EWS run on current version of this PR (hash 3123233) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are several uses of m_legacyMainFrameProcess->processPool()
in WebPageProxy that could also be replaced.
…ead of its main frame process https://bugs.webkit.org/show_bug.cgi?id=275284 rdar://129425265 Reviewed by Charlie Wolfe. This is the broadest and lowest risk way to quickly reduce use of WebPageProxy::legacyMainFrameProcess. The two paths reach the same WebProcessPool. * Source/WebKit/UIProcess/API/C/WKPage.cpp: (WKPageGetContext): (WKPageGetGPUProcessIdentifier): (WKPageSetMockCaptureDevicesInterrupted): (WKPageTriggerMockCaptureConfigurationChange): * Source/WebKit/UIProcess/API/C/mac/WKPagePrivateMac.mm: (WKPageIsURLKnownHSTSHost): * Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm: (-[WKWebView dealloc]): (-[WKWebView _remoteObjectRegistry]): (-[WKWebView _clearBackForwardCache]): * Source/WebKit/UIProcess/API/Cocoa/WKWebViewTesting.mm: (-[WKWebView _hasServiceWorkerBackgroundActivityForTesting]): (-[WKWebView _hasServiceWorkerForegroundActivityForTesting]): (-[WKWebView _gpuToWebProcessConnectionCountForTesting:]): * Source/WebKit/UIProcess/Cocoa/VideoPresentationManagerProxy.mm: (WebKit::VideoPresentationManagerProxy::createLayerHostViewWithID): * Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionControllerCocoa.mm: (WebKit::WebExtensionController::addPage): (WebKit::WebExtensionController::removePage): (WebKit::WebExtensionController::removeProcessPool): * Source/WebKit/UIProcess/Gamepad/UIGamepadProvider.cpp: (WebKit::UIGamepadProvider::gamepadSyncTimerFired): (WebKit::UIGamepadProvider::viewBecameActive): * Source/WebKit/UIProcess/Inspector/WebInspectorUIProxy.cpp: (WebKit::WebInspectorUIProxy::frontendLoaded): * Source/WebKit/UIProcess/RemoteLayerTree/mac/RemoteLayerTreeDrawingAreaProxyMac.mm: (WebKit::RemoteLayerTreeDrawingAreaProxyMac::existingDisplayLink): (WebKit::RemoteLayerTreeDrawingAreaProxyMac::displayLink): * Source/WebKit/UIProcess/UserMediaPermissionRequestManagerProxy.cpp: (WebKit::UserMediaPermissionRequestManagerProxy::processUserMediaPermissionValidRequest): * Source/WebKit/UIProcess/WebFullScreenManagerProxy.cpp: (WebKit::WebFullScreenManagerProxy::didEnterFullScreen): (WebKit::WebFullScreenManagerProxy::didExitFullScreen): * Source/WebKit/UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::gpuProcessID const): (WebKit::WebPageProxy::modelProcessID const): (WebKit::WebPageProxy::backForwardCache const): (WebKit::WebPageProxy::close): (WebKit::WebPageProxy::reload): (WebKit::WebPageProxy::wheelEventHandlingCompleted): (WebKit::WebPageProxy::receivedNavigationActionPolicyDecision): (WebKit::WebPageProxy::didDestroyFrame): (WebKit::WebPageProxy::didFinishDocumentLoadForFrame): (WebKit::WebPageProxy::didFinishLoadForFrame): (WebKit::WebPageProxy::didFailLoadForFrame): (WebKit::WebPageProxy::didSameDocumentNavigationForFrame): (WebKit::WebPageProxy::didSameDocumentNavigationForFrameViaJSHistoryAPI): (WebKit::WebPageProxy::didUpdateHistoryTitle): (WebKit::WebPageProxy::runJavaScriptAlert): (WebKit::WebPageProxy::runJavaScriptConfirm): (WebKit::WebPageProxy::runJavaScriptPrompt): (WebKit::WebPageProxy::runBeforeUnloadConfirmPanel): (WebKit::WebPageProxy::runOpenPanel): (WebKit::WebPageProxy::resumeDownload): (WebKit::WebPageProxy::downloadRequest): (WebKit::WebPageProxy::showPopupMenu): (WebKit::WebPageProxy::showContextMenu): (WebKit::WebPageProxy::mouseEventHandlingCompleted): (WebKit::WebPageProxy::keyEventHandlingCompleted): (WebKit::WebPageProxy::resetStateAfterProcessTermination): (WebKit::WebPageProxy::willStartCapture): (WebKit::WebPageProxy::gpuProcessExited): * Source/WebKit/UIProcess/WebPreferences.cpp: (WebKit::WebPreferences::updateBoolValueForKey): * Source/WebKit/UIProcess/ios/PageClientImplIOS.mm: (WebKit::PageClientImpl::decidePolicyForGeolocationPermissionRequest): * Source/WebKit/UIProcess/ios/WKContentView.mm: (-[WKContentView _setupVisibilityPropagationForGPUProcess]): (-[WKContentView _setupVisibilityPropagationForModelProcess]): (-[WKContentView _removeVisibilityPropagationViewForGPUProcess]): * Source/WebKit/UIProcess/mac/DisplayCaptureSessionManager.mm: (WebKit::DisplayCaptureSessionManager::promptForGetDisplayMedia): (WebKit::DisplayCaptureSessionManager::cancelGetDisplayMediaPrompt): * Source/WebKit/UIProcess/mac/WebViewImpl.mm: (WebKit::WebViewImpl::~WebViewImpl): (WebKit::WebViewImpl::screenDidChangeColorSpace): (WebKit::WebViewImpl::remoteObjectRegistry): Canonical link: https://commits.webkit.org/279850@main
3123233
to
b99b53f
Compare
Committed 279850@main (b99b53f): https://commits.webkit.org/279850@main Reviewed commits have been landed. Closing PR #29649 and removing active labels. |
b99b53f
3123233
🧪 api-ios