Skip to content

Use WTF::forward_like instead of std::forward_like #29971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

achristensen07
Copy link
Contributor

@achristensen07 achristensen07 commented Jun 19, 2024

6a853b6

Use WTF::forward_like instead of std::forward_like
https://bugs.webkit.org/show_bug.cgi?id=275654
rdar://130130589

Reviewed by Yusuke Suzuki.

Microsoft's STL implementation uses an inferred return type, and clang has some difficulty
seeing that it is actually defined before it is used.  I'm sure we can eventually move back
to using std::forward_like, but since that is the only known blocker to C++23 adoption,
let's do this now and figure out how to switch back to std::forward_like later.

* Source/WTF/wtf/StdLibExtras.h:
(std::forward_like): Deleted.
* Source/WebKit/Platform/IPC/ArgumentCoders.h:
(IPC::ArgumentCoder<std::unique_ptr<T>>::encode):
(IPC::ArgumentCoder<UniqueRef<T>>::encode):

Canonical link: https://commits.webkit.org/280187@main

6087ae0

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 wincairo-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🛠 🧪 jsc ✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64 ⏳ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
⏳ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
⏳ 🧪 vision-wk2 🛠 jsc-armv7
✅ 🛠 🧪 unsafe-merge ✅ 🛠 tv 🧪 jsc-armv7-tests
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@achristensen07 achristensen07 requested a review from cdumez as a code owner June 19, 2024 05:34
@achristensen07 achristensen07 self-assigned this Jun 19, 2024
@achristensen07 achristensen07 added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jun 20, 2024
https://bugs.webkit.org/show_bug.cgi?id=275654
rdar://130130589

Reviewed by Yusuke Suzuki.

Microsoft's STL implementation uses an inferred return type, and clang has some difficulty
seeing that it is actually defined before it is used.  I'm sure we can eventually move back
to using std::forward_like, but since that is the only known blocker to C++23 adoption,
let's do this now and figure out how to switch back to std::forward_like later.

* Source/WTF/wtf/StdLibExtras.h:
(std::forward_like): Deleted.
* Source/WebKit/Platform/IPC/ArgumentCoders.h:
(IPC::ArgumentCoder<std::unique_ptr<T>>::encode):
(IPC::ArgumentCoder<UniqueRef<T>>::encode):

Canonical link: https://commits.webkit.org/280187@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Use-WTFforward_like-instead-of-stdforward_like branch from 6087ae0 to 6a853b6 Compare June 20, 2024 01:20
@webkit-commit-queue
Copy link
Collaborator

Committed 280187@main (6a853b6): https://commits.webkit.org/280187@main

Reviewed commits have been landed. Closing PR #29971 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 6a853b6 into WebKit:main Jun 20, 2024
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants