Skip to content

Use SystemV ABI for Wasm LLInt on Windows #30116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

iangrunert
Copy link
Contributor

@iangrunert iangrunert commented Jun 24, 2024

e655849

Use SystemV ABI for Wasm LLInt on Windows
https://bugs.webkit.org/show_bug.cgi?id=275811

Reviewed by Yusuke Suzuki.

Disabled wasm/wast-tests when running without JIT, they're way too slow.

* JSTests/wasm/wast-tests/harness.js:
* Source/JavaScriptCore/llint/WebAssembly.asm:
* Source/JavaScriptCore/llint/WebAssembly64.asm:
* Source/JavaScriptCore/wasm/WasmCallee.cpp:
(JSC::Wasm::LLIntCallee::calleeSaveRegistersImpl):
* Source/JavaScriptCore/wasm/WasmCallingConvention.h:
* Source/JavaScriptCore/wasm/WasmOMGIRGenerator.h:
* Source/JavaScriptCore/wasm/WasmSlowPaths.cpp:
(JSC::LLInt::wasm_log_crash): Deleted.
(JSC::LLInt::shouldJIT): Deleted.
(JSC::LLInt::jitCompileAndSetHeuristics): Deleted.
(JSC::LLInt::jitCompileSIMDFunction): Deleted.
(JSC::LLInt::WASM_SLOW_PATH_DECL): Deleted.
(JSC::LLInt::doWasmCall): Deleted.
(JSC::LLInt::doWasmCallIndirect): Deleted.
(JSC::LLInt::doWasmCallRef): Deleted.
(JSC::LLInt::jsrSize): Deleted.
(JSC::LLInt::slow_path_wasm_throw_exception): Deleted.
(JSC::LLInt::slow_path_wasm_popcount): Deleted.
(JSC::LLInt::slow_path_wasm_popcountll): Deleted.
* Source/JavaScriptCore/wasm/WasmSlowPaths.h:
* Source/cmake/OptionsWin.cmake:
* Tools/Scripts/run-jsc-stress-tests:

Canonical link: https://commits.webkit.org/280334@main

54f2fd8

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 wincairo-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🛠 🧪 jsc 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🛠 jsc-armv7
✅ 🛠 🧪 unsafe-merge ✅ 🛠 tv ✅ 🧪 jsc-armv7-tests
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@iangrunert iangrunert requested review from a team and JonWBedard as code owners June 24, 2024 17:02
@Ahmad-S792 Ahmad-S792 added the JavaScriptCore For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues. label Jun 24, 2024
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jun 24, 2024
Copy link
Member

@Constellation Constellation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me

@iangrunert iangrunert force-pushed the ig/enable-wasm-llint-win branch from ca9871b to 54f2fd8 Compare June 25, 2024 13:44
@Constellation Constellation added unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing and removed merging-blocked Applied to prevent a change from being merged labels Jun 25, 2024
https://bugs.webkit.org/show_bug.cgi?id=275811

Reviewed by Yusuke Suzuki.

Disabled wasm/wast-tests when running without JIT, they're way too slow.

* JSTests/wasm/wast-tests/harness.js:
* Source/JavaScriptCore/llint/WebAssembly.asm:
* Source/JavaScriptCore/llint/WebAssembly64.asm:
* Source/JavaScriptCore/wasm/WasmCallee.cpp:
(JSC::Wasm::LLIntCallee::calleeSaveRegistersImpl):
* Source/JavaScriptCore/wasm/WasmCallingConvention.h:
* Source/JavaScriptCore/wasm/WasmOMGIRGenerator.h:
* Source/JavaScriptCore/wasm/WasmSlowPaths.cpp:
(JSC::LLInt::wasm_log_crash): Deleted.
(JSC::LLInt::shouldJIT): Deleted.
(JSC::LLInt::jitCompileAndSetHeuristics): Deleted.
(JSC::LLInt::jitCompileSIMDFunction): Deleted.
(JSC::LLInt::WASM_SLOW_PATH_DECL): Deleted.
(JSC::LLInt::doWasmCall): Deleted.
(JSC::LLInt::doWasmCallIndirect): Deleted.
(JSC::LLInt::doWasmCallRef): Deleted.
(JSC::LLInt::jsrSize): Deleted.
(JSC::LLInt::slow_path_wasm_throw_exception): Deleted.
(JSC::LLInt::slow_path_wasm_popcount): Deleted.
(JSC::LLInt::slow_path_wasm_popcountll): Deleted.
* Source/JavaScriptCore/wasm/WasmSlowPaths.h:
* Source/cmake/OptionsWin.cmake:
* Tools/Scripts/run-jsc-stress-tests:

Canonical link: https://commits.webkit.org/280334@main
@webkit-commit-queue webkit-commit-queue force-pushed the ig/enable-wasm-llint-win branch from 54f2fd8 to e655849 Compare June 25, 2024 15:16
@webkit-commit-queue
Copy link
Collaborator

Committed 280334@main (e655849): https://commits.webkit.org/280334@main

Reviewed commits have been landed. Closing PR #30116 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit e655849 into WebKit:main Jun 25, 2024
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JavaScriptCore For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants