-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Use SystemV ABI for Wasm LLInt on Windows #30116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
webkit-commit-queue
merged 1 commit into
WebKit:main
from
iangrunert:ig/enable-wasm-llint-win
Jun 25, 2024
Merged
Use SystemV ABI for Wasm LLInt on Windows #30116
webkit-commit-queue
merged 1 commit into
WebKit:main
from
iangrunert:ig/enable-wasm-llint-win
Jun 25, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
EWS run on previous version of this PR (hash ca9871b) |
Constellation
approved these changes
Jun 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r=me
ca9871b
to
54f2fd8
Compare
EWS run on current version of this PR (hash 54f2fd8) |
https://bugs.webkit.org/show_bug.cgi?id=275811 Reviewed by Yusuke Suzuki. Disabled wasm/wast-tests when running without JIT, they're way too slow. * JSTests/wasm/wast-tests/harness.js: * Source/JavaScriptCore/llint/WebAssembly.asm: * Source/JavaScriptCore/llint/WebAssembly64.asm: * Source/JavaScriptCore/wasm/WasmCallee.cpp: (JSC::Wasm::LLIntCallee::calleeSaveRegistersImpl): * Source/JavaScriptCore/wasm/WasmCallingConvention.h: * Source/JavaScriptCore/wasm/WasmOMGIRGenerator.h: * Source/JavaScriptCore/wasm/WasmSlowPaths.cpp: (JSC::LLInt::wasm_log_crash): Deleted. (JSC::LLInt::shouldJIT): Deleted. (JSC::LLInt::jitCompileAndSetHeuristics): Deleted. (JSC::LLInt::jitCompileSIMDFunction): Deleted. (JSC::LLInt::WASM_SLOW_PATH_DECL): Deleted. (JSC::LLInt::doWasmCall): Deleted. (JSC::LLInt::doWasmCallIndirect): Deleted. (JSC::LLInt::doWasmCallRef): Deleted. (JSC::LLInt::jsrSize): Deleted. (JSC::LLInt::slow_path_wasm_throw_exception): Deleted. (JSC::LLInt::slow_path_wasm_popcount): Deleted. (JSC::LLInt::slow_path_wasm_popcountll): Deleted. * Source/JavaScriptCore/wasm/WasmSlowPaths.h: * Source/cmake/OptionsWin.cmake: * Tools/Scripts/run-jsc-stress-tests: Canonical link: https://commits.webkit.org/280334@main
54f2fd8
to
e655849
Compare
Committed 280334@main (e655849): https://commits.webkit.org/280334@main Reviewed commits have been landed. Closing PR #30116 and removing active labels. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
JavaScriptCore
For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
e655849
54f2fd8
🧪 api-ios