[GStreamer][MediaStream] Video resizing fixes #3086
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philn
added
Platform
webkit-ews-buildbot
added
the
merging-blocked
calvaris
approved these changes
Aug 10, 2022
Source/WebCore/platform/graphics/gstreamer/VideoFrameGStreamer.cpp
Outdated
Show resolved
Hide resolved
ceyusa
reviewed
Aug 10, 2022
Source/WebCore/platform/graphics/gstreamer/VideoFrameGStreamer.cpp
Outdated
Show resolved
Hide resolved
https://bugs.webkit.org/show_bug.cgi?id=243638 Reviewed by Xabier Rodriguez-Calvar. Resizing a media track from JS triggers a call to RealtimeMediaSource::setSize() but that doesn't affect the mock video source per-se because it is wrapped in a RealtimeVideoSource. On Apple platforms the RealtimeVideoSource actually resizes the video frame, but keeps the captureSize un-modified. So the RealtimeVideoSource::adaptVideoFrame() method is also now implemented for GStreamer ports. * LayoutTests/platform/glib/TestExpectations: * Source/WebCore/platform/graphics/gstreamer/VideoFrameGStreamer.cpp: (WebCore::setBufferFields): (WebCore::VideoFrameGStreamer::createFromPixelBuffer): (WebCore::VideoFrameGStreamer::resizeTo): * Source/WebCore/platform/graphics/gstreamer/VideoFrameGStreamer.h: * Source/WebCore/platform/mediastream/RealtimeVideoSource.cpp: (WebCore::RealtimeVideoSource::adaptVideoFrame): (WebCore::RealtimeVideoSource::videoFrameAvailable): * Source/WebCore/platform/mediastream/RealtimeVideoSource.h: Canonical link: https://commits.webkit.org/253289@main
webkit-early-warning-system
force-pushed
the
eng/243638
branch
from
1bcdc4b to
8a44e02
Compare
|
Committed 253289@main (8a44e02): https://commits.webkit.org/253289@main Reviewed commits have been landed. Closing PR #3086 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
8a44e02