Skip to content

Conversation

Ahmad-S792
Copy link
Contributor

@Ahmad-S792 Ahmad-S792 commented Aug 27, 2024

a85951c

Remove invalid `writing-mode` from `:cue` in `text-tracks.css`

https://bugs.webkit.org/show_bug.cgi?id=278735
rdar://134793230

Reviewed by Jer Noble.

This patch removes invalid CSS `writing-mode: writing-mode` configured
for `:cue` in `text-tracks.css` as per web specification [1], since it is
variable value.

[1] https://w3c.github.io/webvtt/#applying-css-properties

For `writing-mode` implementation, refer to `VTTCue::getCSSWritingMode()`.

* Source/WebCore/Modules/modern-media-controls/controls/text-tracks.css:
([useragentpart="cue"]):

Canonical link: https://commits.webkit.org/282820@main

18dc1a0

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac 🛠 wpe 🛠 wincairo
✅ 🧪 bindings 🛠 ios-sim ✅ 🛠 mac-AS-debug 🧪 wpe-wk2 🧪 wincairo-tests
✅ 🧪 webkitperl 🧪 ios-wk2 🧪 api-mac 🧪 api-wpe
🧪 ios-wk2-wpt 🧪 mac-wk1 🛠 wpe-cairo
🧪 api-ios 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision 🧪 mac-AS-debug-wk2 🧪 gtk-wk2
✅ 🛠 vision-sim 🧪 mac-wk2-stress 🧪 api-gtk
🧪 vision-wk2 🧪 mac-intel-wk2
✅ 🛠 🧪 unsafe-merge 🛠 tv
🛠 tv-sim
🛠 watch
🛠 watch-sim

@Ahmad-S792 Ahmad-S792 self-assigned this Aug 27, 2024
@Ahmad-S792 Ahmad-S792 added the Media Bugs related to the HTML 5 Media elements. label Aug 27, 2024
@Ahmad-S792 Ahmad-S792 force-pushed the eng/Remove-invalid-writing-mode-from-cue-in-text-tracks-css branch from f3b8f85 to 18dc1a0 Compare August 27, 2024 21:48
@Ahmad-S792 Ahmad-S792 added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Aug 27, 2024
https://bugs.webkit.org/show_bug.cgi?id=278735
rdar://134793230

Reviewed by Jer Noble.

This patch removes invalid CSS `writing-mode: writing-mode` configured
for `:cue` in `text-tracks.css` as per web specification [1], since it is
variable value.

[1] https://w3c.github.io/webvtt/#applying-css-properties

For `writing-mode` implementation, refer to `VTTCue::getCSSWritingMode()`.

* Source/WebCore/Modules/modern-media-controls/controls/text-tracks.css:
([useragentpart="cue"]):

Canonical link: https://commits.webkit.org/282820@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Remove-invalid-writing-mode-from-cue-in-text-tracks-css branch from 18dc1a0 to a85951c Compare August 27, 2024 22:00
@webkit-commit-queue
Copy link
Collaborator

Committed 282820@main (a85951c): https://commits.webkit.org/282820@main

Reviewed commits have been landed. Closing PR #32771 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit a85951c into WebKit:main Aug 27, 2024
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Aug 27, 2024
@Ahmad-S792 Ahmad-S792 deleted the eng/Remove-invalid-writing-mode-from-cue-in-text-tracks-css branch August 27, 2024 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Media Bugs related to the HTML 5 Media elements.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants