LocalAuthenticatorAccessGroup should be an Objective-C String literal #33225

AZero13 · 2024-09-06T01:08:01Z

`dc269f2`

LocalAuthenticatorAccessGroup should be an Objective-C String literal
https://bugs.webkit.org/show_bug.cgi?id=279240

Reviewed by Pascoe.

* Source/WebCore/Modules/webauthn/WebAuthenticationConstants.h: Make Objective-C literal.
* Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm: Ditto.
(+[_WKWebAuthenticationPanel getAllLocalAuthenticatorCredentials]): Ditto.
(+[_WKWebAuthenticationPanel getAllLocalAuthenticatorCredentialsWithRPID:]): Ditto.
(+[_WKWebAuthenticationPanel getAllLocalAuthenticatorCredentialsWithCredentialID:]): Ditto.
(+[_WKWebAuthenticationPanel importLocalAuthenticatorCredential:error:]): Ditto.

Canonical link: https://commits.webkit.org/283773@main

c6ed917

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	✅ 🧪 wincairo-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-cairo
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 vision	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
✅ 🛠 🧪 merge	✅ 🧪 vision-wk2	✅ 🧪 mac-intel-wk2
	✅ 🛠 tv
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2024-09-06T01:08:06Z

EWS run on previous version of this PR (hash 5417b36)

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	❌ 🛠 ios	❌ 🛠 mac	~~🛠 wpe~~	~~🛠 wincairo~~
✅ 🧪 bindings	❌ 🛠 ios-sim	❌ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~	~~🧪 wincairo-tests~~
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	❌ 🧪 api-mac	~~🧪 api-wpe~~
	❌ 🧪 ios-wk2-wpt	❌ 🧪 mac-wk1	~~🛠 wpe-cairo~~
	❌ 🧪 api-ios	❌ 🧪 mac-wk2	~~🛠 gtk~~
	❌ 🛠 vision	❌ 🧪 mac-AS-debug-wk2	~~🧪 gtk-wk2~~
	~~🛠 vision-sim~~	❌ 🧪 mac-wk2-stress	~~🧪 api-gtk~~
	⏳ 🧪 vision-wk2	❌ 🧪 mac-intel-wk2
	~~🛠 tv~~
	~~🛠 tv-sim~~
	~~🛠 watch~~
	~~🛠 watch-sim~~

webkit-early-warning-system · 2024-09-06T01:28:27Z

EWS run on previous version of this PR (hash 814ea87)

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	✅ 🧪 wincairo-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-cairo
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 vision	❌ 🧪 mac-AS-debug-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
	✅ 🧪 vision-wk2	✅ 🧪 mac-intel-wk2
	✅ 🛠 tv
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2024-09-07T00:28:36Z

EWS run on previous version of this PR (hash e792cbb)

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	✅ 🧪 wincairo-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-cairo
	🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 vision	❌ 🧪 mac-AS-debug-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
	✅ 🧪 vision-wk2	✅ 🧪 mac-intel-wk2
	✅ 🛠 tv
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2024-09-07T16:02:33Z

EWS run on previous version of this PR (hash f253041)

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	✅ 🧪 wincairo-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-cairo
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 vision	❌ 🧪 mac-AS-debug-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
	✅ 🧪 vision-wk2	✅ 🧪 mac-intel-wk2
	✅ 🛠 tv
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2024-09-08T00:33:20Z

EWS run on previous version of this PR (hash e9c77a5)

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	✅ 🧪 wincairo-tests
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-cairo
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 vision	❌ 🧪 mac-AS-debug-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
	✅ 🧪 vision-wk2	✅ 🧪 mac-intel-wk2
	✅ 🛠 tv
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2024-09-09T01:12:26Z

EWS run on previous version of this PR (hash 3375266)

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	✅ 🧪 wincairo-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-cairo
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 vision	❌ 🧪 mac-AS-debug-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
	✅ 🧪 vision-wk2	✅ 🧪 mac-intel-wk2
	✅ 🛠 tv
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2024-09-10T03:03:28Z

EWS run on current version of this PR (hash c6ed917)

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	✅ 🧪 wincairo-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-cairo
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 vision	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
✅ 🛠 🧪 merge	✅ 🧪 vision-wk2	✅ 🧪 mac-intel-wk2
	✅ 🛠 tv
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

https://bugs.webkit.org/show_bug.cgi?id=279240 Reviewed by Pascoe. * Source/WebCore/Modules/webauthn/WebAuthenticationConstants.h: Make Objective-C literal. * Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm: Ditto. (+[_WKWebAuthenticationPanel getAllLocalAuthenticatorCredentials]): Ditto. (+[_WKWebAuthenticationPanel getAllLocalAuthenticatorCredentialsWithRPID:]): Ditto. (+[_WKWebAuthenticationPanel getAllLocalAuthenticatorCredentialsWithCredentialID:]): Ditto. (+[_WKWebAuthenticationPanel importLocalAuthenticatorCredential:error:]): Ditto. Canonical link: https://commits.webkit.org/283773@main

webkit-commit-queue · 2024-09-17T16:09:50Z

Committed 283773@main (dc269f2): https://commits.webkit.org/283773@main

Reviewed commits have been landed. Closing PR #33225 and removing active labels.

AZero13 requested a review from cdumez as a code owner September 6, 2024 01:08

AZero13 force-pushed the k branch from 5417b36 to 814ea87 Compare September 6, 2024 01:28

Ahmad-S792 assigned AZero13 Sep 6, 2024

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Sep 6, 2024

AZero13 force-pushed the k branch from 814ea87 to e792cbb Compare September 7, 2024 00:28

AZero13 force-pushed the k branch from e792cbb to f253041 Compare September 7, 2024 16:02

AZero13 force-pushed the k branch from f253041 to e9c77a5 Compare September 8, 2024 00:33

AZero13 force-pushed the k branch from e9c77a5 to 3375266 Compare September 9, 2024 01:12

AZero13 force-pushed the k branch from 3375266 to c6ed917 Compare September 10, 2024 03:03

pascoej approved these changes Sep 17, 2024

View reviewed changes

pascoej added merge-queue Applied to send a pull request to merge-queue and removed merging-blocked Applied to prevent a change from being merged labels Sep 17, 2024

webkit-commit-queue force-pushed the k branch from c6ed917 to dc269f2 Compare September 17, 2024 16:09

webkit-commit-queue merged commit dc269f2 into WebKit:main Sep 17, 2024

webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Sep 17, 2024

AZero13 deleted the k branch September 17, 2024 18:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

LocalAuthenticatorAccessGroup should be an Objective-C String literal #33225

LocalAuthenticatorAccessGroup should be an Objective-C String literal #33225

Uh oh!

AZero13 commented Sep 6, 2024 •

edited by webkit-early-warning-system

Loading

Uh oh!

webkit-early-warning-system commented Sep 6, 2024 •

edited

Loading

Uh oh!

webkit-early-warning-system commented Sep 6, 2024 •

edited

Loading

Uh oh!

webkit-early-warning-system commented Sep 7, 2024 •

edited

Loading

Uh oh!

webkit-early-warning-system commented Sep 7, 2024 •

edited

Loading

Uh oh!

webkit-early-warning-system commented Sep 8, 2024 •

edited

Loading

Uh oh!

webkit-early-warning-system commented Sep 9, 2024 •

edited

Loading

Uh oh!

webkit-early-warning-system commented Sep 10, 2024 •

edited

Loading

Uh oh!

webkit-commit-queue commented Sep 17, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

LocalAuthenticatorAccessGroup should be an Objective-C String literal #33225

LocalAuthenticatorAccessGroup should be an Objective-C String literal #33225

Uh oh!

Conversation

AZero13 commented Sep 6, 2024 • edited by webkit-early-warning-system Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

dc269f2

Uh oh!

webkit-early-warning-system commented Sep 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Sep 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Sep 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Sep 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Sep 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Sep 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Sep 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-commit-queue commented Sep 17, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

AZero13 commented Sep 6, 2024 •

edited by webkit-early-warning-system

Loading

`dc269f2`

webkit-early-warning-system commented Sep 6, 2024 •

edited

Loading

webkit-early-warning-system commented Sep 6, 2024 •

edited

Loading

webkit-early-warning-system commented Sep 7, 2024 •

edited

Loading

webkit-early-warning-system commented Sep 7, 2024 •

edited

Loading

webkit-early-warning-system commented Sep 8, 2024 •

edited

Loading

webkit-early-warning-system commented Sep 9, 2024 •

edited

Loading

webkit-early-warning-system commented Sep 10, 2024 •

edited

Loading