Skip to content

Conversation

carlosgcampos
Copy link
Contributor

@carlosgcampos carlosgcampos commented Sep 24, 2024

e4c64c9

[WPE] WPE Platform: do not force headless platform to AR24 linear buffer format
https://bugs.webkit.org/show_bug.cgi?id=280263

Reviewed by Adrian Perez de Castro.

When used with swrast, shared memory buffers are used with ARGB8888
format, but when using a GPU there's no reason to force a format. We can
remove the implementation of get_preferred_dma_buf_formats and implement
get_egl_display instead, so that WPEDisplay will build the list of
formats supported by the EGL display.

* Source/WebKit/WPEPlatform/wpe/headless/WPEDisplayHeadless.cpp:
(wpeDisplayHeadlessDispose):
(wpeDisplayHeadlessGetEGLDisplay):
(wpe_display_headless_class_init):
(wpeDisplayHeadlessGetPreferredDMABufFormats): Deleted.

Canonical link: https://commits.webkit.org/284205@main

e31212c

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt loading 🧪 mac-wk1 ✅ 🛠 wpe-cairo
loading 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ❌ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2
✅ 🛠 🧪 unsafe-merge ✅ 🛠 tv
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@carlosgcampos carlosgcampos requested review from a team and zdobersek as code owners September 24, 2024 10:20
@carlosgcampos carlosgcampos self-assigned this Sep 24, 2024
@carlosgcampos carlosgcampos added the WPE WebKit WebKit WPE component label Sep 24, 2024
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Sep 24, 2024
@carlosgcampos carlosgcampos added unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing and removed merging-blocked Applied to prevent a change from being merged labels Sep 25, 2024
…fer format

https://bugs.webkit.org/show_bug.cgi?id=280263

Reviewed by Adrian Perez de Castro.

When used with swrast, shared memory buffers are used with ARGB8888
format, but when using a GPU there's no reason to force a format. We can
remove the implementation of get_preferred_dma_buf_formats and implement
get_egl_display instead, so that WPEDisplay will build the list of
formats supported by the EGL display.

* Source/WebKit/WPEPlatform/wpe/headless/WPEDisplayHeadless.cpp:
(wpeDisplayHeadlessDispose):
(wpeDisplayHeadlessGetEGLDisplay):
(wpe_display_headless_class_init):
(wpeDisplayHeadlessGetPreferredDMABufFormats): Deleted.

Canonical link: https://commits.webkit.org/284205@main
@webkit-commit-queue webkit-commit-queue force-pushed the wpe-platform-headless-dmabuf-formats branch from e31212c to e4c64c9 Compare September 25, 2024 05:08
@webkit-commit-queue
Copy link
Collaborator

Committed 284205@main (e4c64c9): https://commits.webkit.org/284205@main

Reviewed commits have been landed. Closing PR #34160 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit e4c64c9 into WebKit:main Sep 25, 2024
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Sep 25, 2024
@carlosgcampos carlosgcampos deleted the wpe-platform-headless-dmabuf-formats branch September 25, 2024 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

WPE WebKit WebKit WPE component

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants