Skip to content

Conversation

lilyspiniolas
Copy link
Contributor

@lilyspiniolas lilyspiniolas commented Oct 4, 2024

ca350c2

[iOS] Improve support for <input type="file" webkitdirectory>
https://bugs.webkit.org/show_bug.cgi?id=271705
rdar://125457578

Reviewed by Wenson Hsieh.

WKFileUploadPanel now checks for the webkitdirectory attribute, and if present
sets the mode of the UIDocumentPickerViewController to the required
UIDocumentPickerModeOpen rather than UIDocumentPickerModeImport. The contents
of selected directories are then manually imported in order to be uploaded.

* Source/WebKit/UIProcess/ios/forms/WKFileUploadPanel.mm:
(-[WKFileUploadPanel presentWithParameters:resultListener:]):

Canonical link: https://commits.webkit.org/284685@main

1360f93

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2
✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@lilyspiniolas lilyspiniolas requested a review from cdumez as a code owner October 4, 2024 04:30
@lilyspiniolas lilyspiniolas self-assigned this Oct 4, 2024
@lilyspiniolas lilyspiniolas added the Forms For bugs specific to form elements (checkboxes, buttons, text fields, etc.) label Oct 4, 2024
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Oct 4, 2024
@lilyspiniolas lilyspiniolas removed the merging-blocked Applied to prevent a change from being merged label Oct 4, 2024
@lilyspiniolas lilyspiniolas added the merge-queue Applied to send a pull request to merge-queue label Oct 4, 2024
https://bugs.webkit.org/show_bug.cgi?id=271705
rdar://125457578

Reviewed by Wenson Hsieh.

WKFileUploadPanel now checks for the webkitdirectory attribute, and if present
sets the mode of the UIDocumentPickerViewController to the required
UIDocumentPickerModeOpen rather than UIDocumentPickerModeImport. The contents
of selected directories are then manually imported in order to be uploaded.

* Source/WebKit/UIProcess/ios/forms/WKFileUploadPanel.mm:
(-[WKFileUploadPanel presentWithParameters:resultListener:]):

Canonical link: https://commits.webkit.org/284685@main
@webkit-commit-queue
Copy link
Collaborator

Committed 284685@main (ca350c2): https://commits.webkit.org/284685@main

Reviewed commits have been landed. Closing PR #34675 and removing active labels.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Forms For bugs specific to form elements (checkboxes, buttons, text fields, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants