-
Notifications
You must be signed in to change notification settings - Fork 1.7k
[iOS] Improve support for <input type="file" webkitdirectory> #34675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
EWS run on previous version of this PR (hash 7a579aa) |
EWS run on previous version of this PR (hash af17f57) |
af17f57
to
f9fe5a2
Compare
EWS run on previous version of this PR (hash f9fe5a2) |
f9fe5a2
to
1360f93
Compare
EWS run on current version of this PR (hash 1360f93) |
whsieh
approved these changes
Oct 4, 2024
https://bugs.webkit.org/show_bug.cgi?id=271705 rdar://125457578 Reviewed by Wenson Hsieh. WKFileUploadPanel now checks for the webkitdirectory attribute, and if present sets the mode of the UIDocumentPickerViewController to the required UIDocumentPickerModeOpen rather than UIDocumentPickerModeImport. The contents of selected directories are then manually imported in order to be uploaded. * Source/WebKit/UIProcess/ios/forms/WKFileUploadPanel.mm: (-[WKFileUploadPanel presentWithParameters:resultListener:]): Canonical link: https://commits.webkit.org/284685@main
1360f93
to
ca350c2
Compare
Committed 284685@main (ca350c2): https://commits.webkit.org/284685@main Reviewed commits have been landed. Closing PR #34675 and removing active labels. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ca350c2
1360f93