Skip to content

Web Inspector: Update label for "Disable site-specific hacks" setting override #35145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 14, 2024
Merged

Web Inspector: Update label for "Disable site-specific hacks" setting override #35145

merged 1 commit into from
Oct 14, 2024

Conversation

rcaliman-apple
Copy link
Contributor

@rcaliman-apple rcaliman-apple commented Oct 14, 2024 •
edited by webkit-early-warning-system
Loading

970ce2b

Web Inspector: Update label for "Disable site-specific hacks" setting override
https://bugs.webkit.org/show_bug.cgi?id=281422
rdar://137779118

Reviewed by BJ Burg and Tim Nguyen.

Update the label from "Disable site-specific hacks" to "Disable site-specific quirks".
Matches implementation nomenclature.

* Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js:
* Source/WebInspectorUI/UserInterface/Views/OverrideDeviceSettingsPopover.js:
(WI.OverrideDeviceSettingsPopover.prototype._createSettingsSection):

Canonical link: https://commits.webkit.org/285136@main

fde9c0f

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2
✅ 🛠 tv
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@rcaliman-apple rcaliman-apple self-assigned this Oct 14, 2024
@rcaliman-apple rcaliman-apple added the Web Inspector Bugs related to the WebKit Web Inspector. label Oct 14, 2024
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Oct 14, 2024 •
edited
Loading

EWS run on current version of this PR (hash fde9c0f)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2
✅ 🛠 tv
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@rcaliman-apple rcaliman-apple requested a review from burg October 14, 2024 11:38
@burg burg added the merge-queue Applied to send a pull request to merge-queue label Oct 14, 2024
@rcaliman-apple @burg
Web Inspector: Update label for "Disable site-specific hacks" setting…
970ce2b 
… override

https://bugs.webkit.org/show_bug.cgi?id=281422
rdar://137779118

Reviewed by BJ Burg and Tim Nguyen.

Update the label from "Disable site-specific hacks" to "Disable site-specific quirks".
Matches implementation nomenclature.

* Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js:
* Source/WebInspectorUI/UserInterface/Views/OverrideDeviceSettingsPopover.js:
(WI.OverrideDeviceSettingsPopover.prototype._createSettingsSection):

Canonical link: https://commits.webkit.org/285136@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Web-Inspector-Update-label-for-Disable-site-specific-hacks-setting-override branch from fde9c0f to 970ce2b Compare October 14, 2024 19:56
@webkit-commit-queue
Copy link
Collaborator

Committed 285136@main (970ce2b): https://commits.webkit.org/285136@main

Reviewed commits have been landed. Closing PR #35145 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 970ce2b into WebKit:main Oct 14, 2024
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@burg burg burg approved these changes

@nt1m nt1m nt1m approved these changes

@dcrousso dcrousso Awaiting requested review from dcrousso dcrousso is a code owner

@patrickangle patrickangle Awaiting requested review from patrickangle patrickangle is a code owner

Assignees

@rcaliman-apple rcaliman-apple

Labels
Web Inspector Bugs related to the WebKit Web Inspector.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rcaliman-apple @webkit-early-warning-system @webkit-commit-queue @burg @nt1m