AX: Default to walking the DOM rather than the render tree when building the accessibility tree #35430

twilco · 2024-10-18T15:05:53Z

`6a44b38`

AX: Default to walking the DOM rather than the render tree when building the accessibility tree
https://bugs.webkit.org/show_bug.cgi?id=281749
rdar://138184652

Reviewed by Chris Fleizach.

Walking the DOM rather than the render tree allows many simplifications to our code. Before this
patch, we had several display:contents special cases scattered throughout the code that are no longer
needed:

  1. AccessibilityRenderObject::addNodeOnlyChildren() added display:contents children to the right
     place in an object's render-tree children retroactively. This function is now unnecessary —
     we get this property for free by walking the DOM to build the AX tree.

  2. AccessibilityObject::insertChild had a special case to prevent double-insertion of display:contents children.

  3. AccessibilityRenderObject::addCanvasChildren() only existed because canvas descendants are not rendered,
     and thus not picked up by a render tree walk. This function is now removed.

  4. Numerous other more minor checks throughout the code that only existed because we had to deal with
     anonymous renderers are removed.

The flip side of this is that we don't get "interesting" anonymous renderers for free anymore, e.g.
list markers, CSS ::before and CSS ::after, mfenced element `open`, `close`, `separators` anonymous
renderers. This is still a great tradeoff, as there are far more uninteresting anonymous renderers
than there are interesting ones.

I tried to apply this change to USE(ATSPI) ports, but there are GTK tests that expect the presence of certain
anonymous renderers that I'm not sure we can outright remove (e.g. those in accessibility/gtk/replaced-objects-in-anonymous-blocks.html).
I filed a follow-up bug (https://bugs.webkit.org/show_bug.cgi?id=282117) to track this, more details are there.

Another important aspect of this change is the addition of AXObjectCache::onStyleChange. We have accessibility
properties cached based on element styles that never get updated, and the addition of this function gives us the
framework for starting to fix those.

* LayoutTests/accessibility/mac/ruby-hierarchy-roles-expected.txt:
* LayoutTests/accessibility/mac/ruby-hierarchy-roles.html:
Remove an else block from this test that only existed due to a useless
anonymous renderer child.
* Source/WebCore/accessibility/AXCoreObject.h:
* Source/WebCore/accessibility/AXLogger.cpp:
(WebCore::operator<<):
* Source/WebCore/accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::createObjectFromRenderer):
(WebCore::AXObjectCache::getOrCreate):
(WebCore::AXObjectCache::handleChildrenChanged):
(WebCore::AXObjectCache::onStyleChange):
* Source/WebCore/accessibility/AXObjectCache.h:
* Source/WebCore/accessibility/AccessibilityMathMLElement.cpp:
(WebCore::AccessibilityMathMLElement::addChildren):
* Source/WebCore/accessibility/AccessibilityMathMLElement.h:
* Source/WebCore/accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::parentObject const):
(WebCore::AccessibilityNodeObject::addChildren):
(WebCore::shouldUseAccessibilityObjectInnerText):
(WebCore::AccessibilityNodeObject::parentObjectIfExists const): Deleted.
* Source/WebCore/accessibility/AccessibilityNodeObject.h:
* Source/WebCore/accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::insertChild):
* Source/WebCore/accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::parentInCoreTree const):
(WebCore::AccessibilityObject::parentObjectIfExists const): Deleted.
* Source/WebCore/accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::parentObject const):
(WebCore::AccessibilityRenderObject::textUnderElement const):
(WebCore::AccessibilityRenderObject::shouldGetTextFromNode const):
(WebCore::AccessibilityRenderObject::boundingBoxRect const):
(WebCore::AccessibilityRenderObject::determineAccessibilityRole):
(WebCore::AccessibilityRenderObject::markerRenderer const):
(WebCore::AccessibilityRenderObject::addListItemMarker):
(WebCore::AccessibilityRenderObject::addChildren):
(WebCore::AccessibilityRenderObject::parentObjectIfExists const): Deleted.
(WebCore::AccessibilityRenderObject::addCanvasChildren): Deleted.
(WebCore::AccessibilityRenderObject::addNodeOnlyChildren): Deleted.
* Source/WebCore/accessibility/AccessibilityRenderObject.h:
* Source/WebCore/accessibility/AccessibilityScrollView.h:
* Source/WebCore/accessibility/AccessibilityTable.cpp:
(WebCore::AccessibilityTable::addChildren):
* Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper detailParentForSummaryObject:]):
(-[WebAccessibilityObjectWrapper accessibilitySupportsARIAExpanded]):
(-[WebAccessibilityObjectWrapper accessibilityIsExpanded]):
* Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp:
(WebCore::AXIsolatedTree::updateChildren):
* Source/WebCore/style/StyleTreeResolver.cpp:
(WebCore::Style::TreeResolver::resolveComposedTree):

Canonical link: https://commits.webkit.org/285807@main

59aa64c

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	✅ 🧪 win-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-cairo
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 vision	✅ 🧪 mac-AS-debug-wk2	❌ 🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
✅ 🛠 🧪 merge	✅ 🧪 vision-wk2	✅ 🧪 mac-intel-wk2
	✅ 🛠 tv	✅ 🛠 mac-safer-cpp
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2024-10-18T15:06:00Z

EWS run on previous version of this PR (hash cc858cf)

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	~~🛠 wpe~~	✅ 🛠 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~	~~🧪 win-tests~~
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	~~🧪 api-wpe~~
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	❌ 🛠 wpe-cairo
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	❌ 🛠 gtk
	✅ 🛠 vision	~~🧪 mac-AS-debug-wk2~~	❌ 🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	❌ 🧪 api-gtk
	✅ 🧪 vision-wk2	✅ 🧪 mac-intel-wk2
	✅ 🛠 tv	~~🛠 mac-safer-cpp~~
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2024-10-18T17:06:47Z

EWS run on previous version of this PR (hash 46aa769)

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2	✅ 🧪 win-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-cairo
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 vision	❌ 🧪 mac-AS-debug-wk2	❌ 🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
	✅ 🧪 vision-wk2	✅ 🧪 mac-intel-wk2
	✅ 🛠 tv	✅ 🛠 mac-safer-cpp
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2024-10-25T01:56:21Z

EWS run on previous version of this PR (hash 75fcf0e)

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	~~🛠 ios~~	~~🛠 mac~~	~~🛠 wpe~~	~~🛠 win~~
~~🧪 bindings~~	~~🛠 ios-sim~~	~~🛠 mac-AS-debug~~	~~🧪 wpe-wk2~~	~~🧪 win-tests~~
~~🧪 webkitperl~~	~~🧪 ios-wk2~~	~~🧪 api-mac~~	~~🧪 api-wpe~~
	~~🧪 ios-wk2-wpt~~	~~🧪 mac-wk1~~	~~🛠 wpe-cairo~~
	~~🧪 api-ios~~	~~🧪 mac-wk2~~	~~🛠 gtk~~
	~~🛠 vision~~	~~🧪 mac-AS-debug-wk2~~	~~🧪 gtk-wk2~~
	~~🛠 vision-sim~~	~~🧪 mac-wk2-stress~~	~~🧪 api-gtk~~
	⏳ 🧪 vision-wk2	~~🧪 mac-intel-wk2~~
	~~🛠 tv~~	~~🛠 mac-safer-cpp~~
	~~🛠 tv-sim~~
	~~🛠 watch~~
	~~🛠 watch-sim~~

webkit-early-warning-system · 2024-10-25T01:57:39Z

EWS run on previous version of this PR (hash 1fa6d88)

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2	✅ 🧪 win-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-cairo
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 vision	✅ 🧪 mac-AS-debug-wk2	❌ 🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
	✅ 🧪 vision-wk2	✅ 🧪 mac-intel-wk2
	✅ 🛠 tv	✅ 🛠 mac-safer-cpp
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2024-10-26T00:01:29Z

EWS run on current version of this PR (hash 59aa64c)

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	✅ 🧪 win-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-cairo
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 vision	✅ 🧪 mac-AS-debug-wk2	❌ 🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
✅ 🛠 🧪 merge	✅ 🧪 vision-wk2	✅ 🧪 mac-intel-wk2
	✅ 🛠 tv	✅ 🛠 mac-safer-cpp
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

twilco · 2024-10-26T02:18:06Z

LayoutTests/accessibility/mac/attributed-string-with-listitem-multiple-lines.html

@@ -18,7 +18,7 @@

    if (window.accessibilityController) {
        var listItem1 = accessibilityController.accessibleElementById("item1");
-        var p1 = listItem1.childAtIndex(0);
+        var p1 = listItem1.childAtIndex(1);


Prior to this PR, we sometimes used to insert list markers as not the first child of list items, which is wrong. I fixed this bug as a side effect of this change, and thus the <p> is at index 1 (as it should be) rather than index 0.

twilco · 2024-10-26T02:18:25Z

LayoutTests/accessibility/mac/ruby-hierarchy-roles.html

-        else {
-            axRuby = axRuby.childAtIndex(0);
-            logId(axRuby);
-            output += expect("axRuby.role", "expectedRubyRole");
-            output += expect("axRuby.subrole", "expectedRubyInlineSubrole");
-        }


This branch only existed because we had to deal with anonymous renderers.

fleizach · 2024-10-27T20:54:51Z

Source/WebCore/accessibility/AXObjectCache.cpp

@@ -856,7 +874,8 @@ AccessibilityObject* AXObjectCache::getOrCreate(Node& node, IsPartOfRelation isP
    if (auto* renderer = node.renderer())
        return getOrCreate(*renderer);

-    if (!node.parentElement())
+    RefPtr composedParent = node.parentElementInComposedTree();


can we make this a reference here instead of dereferencing later on?

I don't think so, unfortunately, since this can be null. We could turn it into a Ref after null-checking, but there's not much difference between a Ref and a RefPtr that has been checked for null. Both hold a strong reference count and thus guarantee the pointed to object is valid for as long as the scope. No ergonomic difference either — both require usage of -> to get at the underlying value.

fleizach

LGTM, only minor comments

…ing the accessibility tree https://bugs.webkit.org/show_bug.cgi?id=281749 rdar://138184652 Reviewed by Chris Fleizach. Walking the DOM rather than the render tree allows many simplifications to our code. Before this patch, we had several display:contents special cases scattered throughout the code that are no longer needed: 1. AccessibilityRenderObject::addNodeOnlyChildren() added display:contents children to the right place in an object's render-tree children retroactively. This function is now unnecessary — we get this property for free by walking the DOM to build the AX tree. 2. AccessibilityObject::insertChild had a special case to prevent double-insertion of display:contents children. 3. AccessibilityRenderObject::addCanvasChildren() only existed because canvas descendants are not rendered, and thus not picked up by a render tree walk. This function is now removed. 4. Numerous other more minor checks throughout the code that only existed because we had to deal with anonymous renderers are removed. The flip side of this is that we don't get "interesting" anonymous renderers for free anymore, e.g. list markers, CSS ::before and CSS ::after, mfenced element `open`, `close`, `separators` anonymous renderers. This is still a great tradeoff, as there are far more uninteresting anonymous renderers than there are interesting ones. I tried to apply this change to USE(ATSPI) ports, but there are GTK tests that expect the presence of certain anonymous renderers that I'm not sure we can outright remove (e.g. those in accessibility/gtk/replaced-objects-in-anonymous-blocks.html). I filed a follow-up bug (https://bugs.webkit.org/show_bug.cgi?id=282117) to track this, more details are there. Another important aspect of this change is the addition of AXObjectCache::onStyleChange. We have accessibility properties cached based on element styles that never get updated, and the addition of this function gives us the framework for starting to fix those. * LayoutTests/accessibility/mac/ruby-hierarchy-roles-expected.txt: * LayoutTests/accessibility/mac/ruby-hierarchy-roles.html: Remove an else block from this test that only existed due to a useless anonymous renderer child. * Source/WebCore/accessibility/AXCoreObject.h: * Source/WebCore/accessibility/AXLogger.cpp: (WebCore::operator<<): * Source/WebCore/accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::createObjectFromRenderer): (WebCore::AXObjectCache::getOrCreate): (WebCore::AXObjectCache::handleChildrenChanged): (WebCore::AXObjectCache::onStyleChange): * Source/WebCore/accessibility/AXObjectCache.h: * Source/WebCore/accessibility/AccessibilityMathMLElement.cpp: (WebCore::AccessibilityMathMLElement::addChildren): * Source/WebCore/accessibility/AccessibilityMathMLElement.h: * Source/WebCore/accessibility/AccessibilityNodeObject.cpp: (WebCore::AccessibilityNodeObject::parentObject const): (WebCore::AccessibilityNodeObject::addChildren): (WebCore::shouldUseAccessibilityObjectInnerText): (WebCore::AccessibilityNodeObject::parentObjectIfExists const): Deleted. * Source/WebCore/accessibility/AccessibilityNodeObject.h: * Source/WebCore/accessibility/AccessibilityObject.cpp: (WebCore::AccessibilityObject::insertChild): * Source/WebCore/accessibility/AccessibilityObject.h: (WebCore::AccessibilityObject::parentInCoreTree const): (WebCore::AccessibilityObject::parentObjectIfExists const): Deleted. * Source/WebCore/accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::parentObject const): (WebCore::AccessibilityRenderObject::textUnderElement const): (WebCore::AccessibilityRenderObject::shouldGetTextFromNode const): (WebCore::AccessibilityRenderObject::boundingBoxRect const): (WebCore::AccessibilityRenderObject::determineAccessibilityRole): (WebCore::AccessibilityRenderObject::markerRenderer const): (WebCore::AccessibilityRenderObject::addListItemMarker): (WebCore::AccessibilityRenderObject::addChildren): (WebCore::AccessibilityRenderObject::parentObjectIfExists const): Deleted. (WebCore::AccessibilityRenderObject::addCanvasChildren): Deleted. (WebCore::AccessibilityRenderObject::addNodeOnlyChildren): Deleted. * Source/WebCore/accessibility/AccessibilityRenderObject.h: * Source/WebCore/accessibility/AccessibilityScrollView.h: * Source/WebCore/accessibility/AccessibilityTable.cpp: (WebCore::AccessibilityTable::addChildren): * Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm: (-[WebAccessibilityObjectWrapper detailParentForSummaryObject:]): (-[WebAccessibilityObjectWrapper accessibilitySupportsARIAExpanded]): (-[WebAccessibilityObjectWrapper accessibilityIsExpanded]): * Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp: (WebCore::AXIsolatedTree::updateChildren): * Source/WebCore/style/StyleTreeResolver.cpp: (WebCore::Style::TreeResolver::resolveComposedTree): Canonical link: https://commits.webkit.org/285807@main

webkit-commit-queue · 2024-10-29T02:25:39Z

Committed 285807@main (6a44b38): https://commits.webkit.org/285807@main

Reviewed commits have been landed. Closing PR #35430 and removing active labels.

twilco self-assigned this Oct 18, 2024

twilco added the Accessibility For bugs related to accessibility. label Oct 18, 2024

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Oct 18, 2024

twilco force-pushed the eng/AX-Default-to-walking-the-DOM-rather-than-the-render-tree-when-building-the-accessibility-tree branch from cc858cf to 46aa769 Compare October 18, 2024 17:06

twilco requested a review from a team as a code owner October 18, 2024 17:06

twilco force-pushed the eng/AX-Default-to-walking-the-DOM-rather-than-the-render-tree-when-building-the-accessibility-tree branch from 46aa769 to 75fcf0e Compare October 25, 2024 01:56

twilco force-pushed the eng/AX-Default-to-walking-the-DOM-rather-than-the-render-tree-when-building-the-accessibility-tree branch from 75fcf0e to 1fa6d88 Compare October 25, 2024 01:57

twilco force-pushed the eng/AX-Default-to-walking-the-DOM-rather-than-the-render-tree-when-building-the-accessibility-tree branch from 1fa6d88 to 59aa64c Compare October 26, 2024 00:01

twilco commented Oct 26, 2024

View reviewed changes

fleizach reviewed Oct 27, 2024

View reviewed changes

fleizach approved these changes Oct 27, 2024

View reviewed changes

twilco added merge-queue Applied to send a pull request to merge-queue and removed merging-blocked Applied to prevent a change from being merged labels Oct 28, 2024

webkit-commit-queue force-pushed the eng/AX-Default-to-walking-the-DOM-rather-than-the-render-tree-when-building-the-accessibility-tree branch from 59aa64c to 6a44b38 Compare October 29, 2024 02:25

webkit-commit-queue merged commit 6a44b38 into WebKit:main Oct 29, 2024

webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Oct 29, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

AX: Default to walking the DOM rather than the render tree when building the accessibility tree #35430

AX: Default to walking the DOM rather than the render tree when building the accessibility tree #35430

Uh oh!

twilco commented Oct 18, 2024 •

edited by webkit-early-warning-system

Loading

Uh oh!

webkit-early-warning-system commented Oct 18, 2024 •

edited

Loading

Uh oh!

webkit-early-warning-system commented Oct 18, 2024 •

edited

Loading

Uh oh!

webkit-early-warning-system commented Oct 25, 2024 •

edited

Loading

Uh oh!

webkit-early-warning-system commented Oct 25, 2024 •

edited

Loading

Uh oh!

webkit-early-warning-system commented Oct 26, 2024 •

edited

Loading

Uh oh!

twilco Oct 26, 2024

Uh oh!

twilco Oct 26, 2024

Uh oh!

fleizach Oct 27, 2024

Uh oh!

twilco Oct 28, 2024

Uh oh!

fleizach left a comment

Uh oh!

webkit-commit-queue commented Oct 29, 2024

Uh oh!

Uh oh!

AX: Default to walking the DOM rather than the render tree when building the accessibility tree #35430

AX: Default to walking the DOM rather than the render tree when building the accessibility tree #35430

Uh oh!

Conversation

twilco commented Oct 18, 2024 • edited by webkit-early-warning-system Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

6a44b38

Uh oh!

webkit-early-warning-system commented Oct 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Oct 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Oct 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Oct 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Oct 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

twilco Oct 26, 2024

Choose a reason for hiding this comment

Uh oh!

twilco Oct 26, 2024

Choose a reason for hiding this comment

Uh oh!

fleizach Oct 27, 2024

Choose a reason for hiding this comment

Uh oh!

twilco Oct 28, 2024

Choose a reason for hiding this comment

Uh oh!

fleizach left a comment

Choose a reason for hiding this comment

Uh oh!

webkit-commit-queue commented Oct 29, 2024

Uh oh!

Uh oh!

twilco commented Oct 18, 2024 •

edited by webkit-early-warning-system

Loading

`6a44b38`

webkit-early-warning-system commented Oct 18, 2024 •

edited

Loading

webkit-early-warning-system commented Oct 18, 2024 •

edited

Loading

webkit-early-warning-system commented Oct 25, 2024 •

edited

Loading

webkit-early-warning-system commented Oct 25, 2024 •

edited

Loading

webkit-early-warning-system commented Oct 26, 2024 •

edited

Loading