Skip to content

git-webkit pfr fails when using angle brackets for bugs.webkit.org URL #3580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 23, 2022
Merged

git-webkit pfr fails when using angle brackets for bugs.webkit.org URL #3580

merged 1 commit into from
Aug 23, 2022

Conversation

JonWBedard
Copy link
Member

@JonWBedard JonWBedard commented Aug 23, 2022 •
edited by webkit-early-warning-system
Loading

b6e3977

`git-webkit pfr` fails when using angle brackets for bugs.webkit.org URL
https://bugs.webkit.org/show_bug.cgi?id=244010
<rdar://98856552>

Reviewed by Aakash Jain and David Kilzer.

* Tools/Scripts/libraries/webkitscmpy/setup.py: Bump version.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py: Ditto.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/remote/git_hub.py: PRGenerator doesn't define a tracker, the repository does.
* metadata/trackers.json: Allow angled brackets.

Canonical link: https://commits.webkit.org/253710@main

71ec489

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios   🛠 mac ✅ 🛠 wpe   🛠 🧪 win
✅ 🧪 bindings ✅ 🛠 ios-sim   🛠 mac-debug   🛠 gtk   🛠 wincairo
✅ 🧪 webkitperl   🧪 ios-wk2   🛠 mac-AS-debug   🧪 gtk-wk2
✅ 🧪 webkitpy   🧪 api-ios   🧪 api-mac   🧪 api-gtk
✅ 🛠 tv   🧪 mac-wk1
✅ 🧪 services ✅ 🛠 tv-sim   🧪 mac-wk2
  🛠 🧪 merge ✅ 🛠 watch   🧪 mac-AS-debug-wk2
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim   🧪 mac-wk2-stress

@JonWBedard JonWBedard self-assigned this Aug 23, 2022
@JonWBedard JonWBedard added Other Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases labels Aug 23, 2022
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Aug 23, 2022 •
edited
Loading

EWS run on previous version of this PR (hash 82426bf)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 🧪 win
✅ 🧪 bindings ✅ 🛠 ios-sim ⏳ 🛠 mac-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🛠 mac-AS-debug ✅ 🧪 gtk-wk2
✅ 🧪 webkitpy ✅ 🧪 api-ios ✅ 🧪 api-mac ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-wk1
✅ 🧪 services ✅ 🛠 tv-sim ✅ 🧪 mac-wk2
✅ 🛠 watch   🧪 mac-AS-debug-wk2
✅ 🛠 watch-sim ✅ 🧪 mac-wk2-stress

@JonWBedard JonWBedard requested a review from ddkilzer August 23, 2022 17:40
@ryanhaddad
Copy link
Contributor

The radar referenced in your commit message is wrong, it appears to be one mentioned in the bugzilla description, but not the one for this particular bug.

ddkilzer
ddkilzer approved these changes Aug 23, 2022
View reviewed changes
Copy link
Contributor

@ddkilzer ddkilzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me

@JonWBedard JonWBedard force-pushed the eng/git-webkit-pfr-fails-when-using-angle-brackets-for-bugs-webkit-org-URL branch from 82426bf to f22a01f Compare August 23, 2022 22:54
@JonWBedard JonWBedard added the merge-queue Applied to send a pull request to merge-queue label Aug 23, 2022
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Aug 23, 2022 •
edited
Loading

EWS run on previous version of this PR (hash f22a01f)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ⏳ 🛠 mac ✅ 🛠 wpe ⏳ 🛠 🧪 win
✅ 🧪 bindings   🛠 ios-sim ⏳ 🛠 mac-debug ⏳ 🛠 gtk ⏳ 🛠 wincairo
✅ 🧪 webkitperl   🧪 ios-wk2 ⏳ 🛠 mac-AS-debug ⏳ 🧪 gtk-wk2
✅ 🧪 webkitpy   🧪 api-ios ⏳ 🧪 api-mac ⏳ 🧪 api-gtk
⏳ 🛠 tv ⏳ 🧪 mac-wk1
✅ 🧪 services ✅ 🛠 tv-sim ⏳ 🧪 mac-wk2
✅ 🛠 watch ⏳ 🧪 mac-AS-debug-wk2
✅ 🛠 watch-sim ⏳ 🧪 mac-wk2-stress

@JonWBedard JonWBedard removed the merge-queue Applied to send a pull request to merge-queue label Aug 23, 2022
@JonWBedard JonWBedard force-pushed the eng/git-webkit-pfr-fails-when-using-angle-brackets-for-bugs-webkit-org-URL branch from f22a01f to 71ec489 Compare August 23, 2022 22:57
@JonWBedard JonWBedard added the merge-queue Applied to send a pull request to merge-queue label Aug 23, 2022
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Aug 23, 2022 •
edited
Loading

71ec489

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios   🛠 mac ✅ 🛠 wpe   🛠 🧪 win
✅ 🧪 bindings ✅ 🛠 ios-sim   🛠 mac-debug   🛠 gtk   🛠 wincairo
✅ 🧪 webkitperl   🧪 ios-wk2   🛠 mac-AS-debug   🧪 gtk-wk2
✅ 🧪 webkitpy   🧪 api-ios   🧪 api-mac   🧪 api-gtk
✅ 🛠 tv   🧪 mac-wk1
✅ 🧪 services ✅ 🛠 tv-sim   🧪 mac-wk2
  🛠 🧪 merge ✅ 🛠 watch   🧪 mac-AS-debug-wk2
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim   🧪 mac-wk2-stress

@smfr smfr added unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing and removed merge-queue Applied to send a pull request to merge-queue labels Aug 23, 2022
@JonWBedard @smfr
git-webkit pfr fails when using angle brackets for bugs.webkit.org URL
b6e3977 
https://bugs.webkit.org/show_bug.cgi?id=244010
<rdar://98856552>

Reviewed by Aakash Jain and David Kilzer.

* Tools/Scripts/libraries/webkitscmpy/setup.py: Bump version.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py: Ditto.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/remote/git_hub.py: PRGenerator doesn't define a tracker, the repository does.
* metadata/trackers.json: Allow angled brackets.

Canonical link: https://commits.webkit.org/253710@main
@webkit-early-warning-system webkit-early-warning-system force-pushed the eng/git-webkit-pfr-fails-when-using-angle-brackets-for-bugs-webkit-org-URL branch from 71ec489 to b6e3977 Compare August 23, 2022 23:42
@webkit-commit-queue
Copy link
Collaborator

Committed 253710@main (b6e3977): https://commits.webkit.org/253710@main

Reviewed commits have been landed. Closing PR #3580 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system merged commit b6e3977 into WebKit:main Aug 23, 2022
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Aug 23, 2022
@JonWBedard JonWBedard deleted the eng/git-webkit-pfr-fails-when-using-angle-brackets-for-bugs-webkit-org-URL branch September 20, 2022 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddkilzer ddkilzer ddkilzer approved these changes

@aj062 aj062 aj062 approved these changes

@facetothefate facetothefate Awaiting requested review from facetothefate facetothefate is a code owner

Assignees

@JonWBedard JonWBedard

Labels
Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@JonWBedard @webkit-early-warning-system @ryanhaddad @webkit-commit-queue @ddkilzer @aj062 @smfr