-
Notifications
You must be signed in to change notification settings - Fork 1.7k
[JSC] Make some iterator structures initialization lazily #36526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JSC] Make some iterator structures initialization lazily #36526
Conversation
EWS run on previous version of this PR (hash 18ba65d) |
18ba65d
to
195dfad
Compare
EWS run on previous version of this PR (hash 195dfad) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r=me if these structures are not obtained from JIT compiler threads (concurrent access for these lazy field is not allowed).
195dfad
to
d525396
Compare
EWS run on current version of this PR (hash d525396) |
https://bugs.webkit.org/show_bug.cgi?id=282984 Reviewed by Yusuke Suzuki. This patch makes following iterator structures initialization lazily: - AsyncFromSyncIterator - WrapForValidIterator - RegExpStringIterator * Source/JavaScriptCore/runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::init): (JSC::JSGlobalObject::visitChildrenImpl): * Source/JavaScriptCore/runtime/JSGlobalObject.h: (JSC::JSGlobalObject::setIteratorPrototype const): (JSC::JSGlobalObject::wrapForValidIteratorStructure const): (JSC::JSGlobalObject::wrapForValidIteratorPrototype const): Deleted. Canonical link: https://commits.webkit.org/286519@main
d525396
to
c938e4d
Compare
Committed 286519@main (c938e4d): https://commits.webkit.org/286519@main Reviewed commits have been landed. Closing PR #36526 and removing active labels. |
c938e4d
d525396
🧪 mac-intel-wk2