-
Notifications
You must be signed in to change notification settings - Fork 1.7k
[css-anchor-position-1] Implement anchor-center
alignment value
#36705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[css-anchor-position-1] Implement anchor-center
alignment value
#36705
Conversation
EWS run on previous version of this PR (hash e0d9779) |
e0d9779
to
211995f
Compare
EWS run on previous version of this PR (hash 211995f) |
211995f
to
531df4c
Compare
EWS run on previous version of this PR (hash 531df4c) |
531df4c
to
64a220f
Compare
EWS run on previous version of this PR (hash 64a220f) |
64a220f
to
68b790b
Compare
EWS run on previous version of this PR (hash 68b790b) |
68b790b
to
01ac09f
Compare
EWS run on current version of this PR (hash 01ac09f) |
https://bugs.webkit.org/show_bug.cgi?id=275451 Reviewed by Antti Koivisto. This change implements `anchor-center` CSS value as specified in: https://drafts.csswg.org/css-anchor-position-1/#anchor-center * LayoutTests/TestExpectations: * LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/anchor-center-htb-htb-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/anchor-center-htb-vrl-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/anchor-center-vrl-htb-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/anchor-center-vrl-vrl-expected.txt: * Source/WebCore/css/CSSProperties.json: * Source/WebCore/rendering/RenderBox.cpp: (WebCore::RenderBox::computePositionedLogicalWidth const): (WebCore::RenderBox::computePositionedLogicalHeight const): (WebCore::isObjectAncestorContainerOf): (WebCore::findClosestCommonContainer): (WebCore::RenderBox::computeAnchorCenteredPosition const): * Source/WebCore/rendering/RenderBox.h: * Source/WebCore/rendering/RenderElement.cpp: (WebCore::RenderElement::defaultAnchor const): (WebCore::RenderElement::defaultAnchorRenderer const): * Source/WebCore/rendering/RenderElement.h: * Source/WebCore/rendering/RenderFlexibleBox.cpp: (WebCore::alignmentOffset): * Source/WebCore/rendering/RenderGrid.cpp: (WebCore::RenderGrid::columnAxisPositionForGridItem const): (WebCore::RenderGrid::rowAxisPositionForGridItem const): * Source/WebCore/style/AnchorPositionEvaluator.cpp: (WebCore::Style::AnchorPositionEvaluator::computeAnchorRectRelativeToContainingBlock): (WebCore::Style::computeInsetValue): (WebCore::Style::computeAnchorRectRelativeToContainingBlock): Deleted. * Source/WebCore/style/AnchorPositionEvaluator.h: Canonical link: https://commits.webkit.org/287144@main
01ac09f
to
a84350e
Compare
Committed 287144@main (a84350e): https://commits.webkit.org/287144@main Reviewed commits have been landed. Closing PR #36705 and removing active labels. |
a84350e
01ac09f