Skip to content

Conversation

philn
Copy link
Member

@philn philn commented Jan 12, 2025

b409dbb

REGRESSION(288642@main): [GStreamer][Debug] Triggers ASSERT when running http/tests/inspector/gatherWebInspectorRTCLogs.html
https://bugs.webkit.org/show_bug.cgi?id=285814

Reviewed by Xabier Rodriguez-Calvar.

The gst_debug_message_get() function returns nullptr when it fails to apply the format specifiers to
the debug message, so this needs to be accounted for and we now return early when this happens.

* Source/WebCore/platform/mediastream/gstreamer/GStreamerWebRTCLogSink.cpp:
(WebCore::GStreamerWebRTCLogSink::start):

Canonical link: https://commits.webkit.org/288860@main

79ead8d

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@philn philn self-assigned this Jan 12, 2025
@philn philn added the Platform Portability improvements and other general platform improvements not driven directly by site bugs. label Jan 12, 2025
@philn philn added the merge-queue Applied to send a pull request to merge-queue label Jan 14, 2025
…ing http/tests/inspector/gatherWebInspectorRTCLogs.html

https://bugs.webkit.org/show_bug.cgi?id=285814

Reviewed by Xabier Rodriguez-Calvar.

The gst_debug_message_get() function returns nullptr when it fails to apply the format specifiers to
the debug message, so this needs to be accounted for and we now return early when this happens.

* Source/WebCore/platform/mediastream/gstreamer/GStreamerWebRTCLogSink.cpp:
(WebCore::GStreamerWebRTCLogSink::start):

Canonical link: https://commits.webkit.org/288860@main
@webkit-commit-queue
Copy link
Collaborator

Committed 288860@main (b409dbb): https://commits.webkit.org/288860@main

Reviewed commits have been landed. Closing PR #38905 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit b409dbb into WebKit:main Jan 14, 2025
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jan 14, 2025
@philn philn deleted the eng/285814 branch January 14, 2025 18:20
@aperezdc
Copy link
Contributor

Backported into the 2.46 branch as commit eb72225

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Platform Portability improvements and other general platform improvements not driven directly by site bugs.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants