Skip to content

Conversation

bnham
Copy link
Contributor

@bnham bnham commented Sep 5, 2022

75b8547

Fix JSCOnly build of bmalloc
https://bugs.webkit.org/show_bug.cgi?id=244751
<rdar://problem/99556286>

Reviewed by Yusuke Suzuki.

In bug 244355 we made `bmalloc::api::enableMiniMode()` call a function in ProcessCheck. But this
breaks the JSCOnly CMake port because ProcessCheck wasn't compiled for that port (it was only
compiled for the Mac port). This patch fixes that.

* Source/bmalloc/PlatformJSCOnly.cmake: Added.

Canonical link: https://commits.webkit.org/254194@main

69c1241

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios 🛠 mac ✅ 🛠 wpe 🛠 🧪 win
✅ 🛠 ios-sim 🛠 mac-debug ✅ 🛠 gtk 🛠 wincairo
✅ 🧪 webkitperl 🧪 ios-wk2 🛠 mac-AS-debug 🧪 gtk-wk2
🧪 api-ios 🧪 api-mac 🧪 api-gtk
✅ 🛠 🧪 jsc 🛠 tv 🧪 mac-wk1 ✅ 🛠 jsc-armv7
🛠 tv-sim 🧪 mac-wk2 ✅ 🧪 jsc-armv7-tests
✅ 🛠 🧪 merge ✅ 🛠 watch 🧪 mac-AS-debug-wk2 ✅ 🛠 jsc-mips
✅ 🛠 watch-sim 🧪 mac-wk2-stress ✅ 🧪 jsc-mips-tests

@bnham bnham requested a review from Constellation as a code owner September 5, 2022 04:57
@bnham bnham self-assigned this Sep 5, 2022
@bnham bnham added bmalloc For bugs in bmalloc WebKit Local Build labels Sep 5, 2022
Copy link
Member

@Constellation Constellation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me

@bnham bnham added the merge-queue Applied to send a pull request to merge-queue label Sep 5, 2022
@webkit-commit-queue
Copy link
Collaborator

No reviewer information in commit message, blocking PR #4015

@webkit-commit-queue webkit-commit-queue added merging-blocked Applied to prevent a change from being merged and removed merge-queue Applied to send a pull request to merge-queue labels Sep 5, 2022
@bnham bnham removed the merging-blocked Applied to prevent a change from being merged label Sep 6, 2022
@bnham bnham force-pushed the eng/fix-bmalloc-jsc-only-build branch from db26375 to 69c1241 Compare September 6, 2022 18:10
@bnham bnham added the merge-queue Applied to send a pull request to merge-queue label Sep 6, 2022
@webkit-commit-queue
Copy link
Collaborator

Committed 254194@main (75b8547): https://commits.webkit.org/254194@main

Reviewed commits have been landed. Closing PR #4015 and removing active labels.

@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bmalloc For bugs in bmalloc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants