Skip to content

WebIDL Parser should support dots as delimiters in enumerations #40533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 16, 2025
Merged

WebIDL Parser should support dots as delimiters in enumerations #40533

merged 1 commit into from
Feb 16, 2025

Conversation

marcoscaceres
Copy link
Contributor

@marcoscaceres marcoscaceres commented Feb 13, 2025 •
edited by webkit-early-warning-system
Loading

9b41952

WebIDL Parser should support dots as delimiters in enumerations
https://bugs.webkit.org/show_bug.cgi?id=287606
rdar://144753892

Reviewed by Chris Dumez.

Adds support for dots as delimiters in enumerations
in the WebIDL code generator. This is needed as some other organizatons are
using dots in their enumerations (e.g, "org.iso.mdoc").

* Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:
(GetEnumerationValueName):
* Source/WebCore/bindings/scripts/test/JS/JSTestStandaloneEnumeration.cpp:
(WebCore::convertEnumerationToString):
(WebCore::parseEnumerationFromString<TestStandaloneEnumeration>):
(WebCore::expectedEnumerationValues<TestStandaloneEnumeration>):
* Source/WebCore/bindings/scripts/test/TestStandaloneEnumeration.idl:

Canonical link: https://commits.webkit.org/290454@main

ff661a0

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ❌ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@marcoscaceres marcoscaceres self-assigned this Feb 13, 2025
@marcoscaceres marcoscaceres added the WebCore Misc. For miscellaneous bugs in the WebCore framework (and not JavaScriptCore or WebKit). label Feb 13, 2025
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Feb 13, 2025 •
edited
Loading

EWS run on previous version of this PR (hash f9d1076)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe   🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2   🧪 win-tests
✅ 🧪 webkitperl   🧪 ios-wk2 ⏳ 🧪 api-mac   🧪 api-wpe
⏳ 🧪 ios-wk2-wpt ⏳ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
⏳ 🧪 api-ios   🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ⏳ 🧪 mac-AS-debug-wk2 ⏳ 🧪 gtk-wk2
✅ 🛠 vision-sim   🧪 mac-wk2-stress ✅ 🧪 api-gtk
  🧪 vision-wk2 ⏳ 🧪 mac-intel-wk2   🛠 playstation
  🛠 tv   🛠 mac-safer-cpp
  🛠 tv-sim
  🛠 watch
  🛠 watch-sim

@marcoscaceres marcoscaceres force-pushed the eng/WebIDL-Parser-should-support-dots-as-delimiters-in-enumerations branch from f9d1076 to 887fe86 Compare February 13, 2025 04:59
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Feb 13, 2025 •
edited
Loading

EWS run on previous version of this PR (hash 887fe86)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2   🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ⏳ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
⏳ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ⏳ 🧪 mac-AS-debug-wk2   🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ❌ 🧪 api-gtk
✅ 🧪 vision-wk2 ⏳ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 tv   🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

cdumez
cdumez approved these changes Feb 13, 2025
View reviewed changes
Copy link
Contributor

@cdumez cdumez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marcoscaceres marcoscaceres added the safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks label Feb 13, 2025
@marcoscaceres marcoscaceres force-pushed the eng/WebIDL-Parser-should-support-dots-as-delimiters-in-enumerations branch from 887fe86 to 61fecda Compare February 13, 2025 05:52
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Feb 13, 2025 •
edited
Loading

EWS run on previous version of this PR (hash 61fecda)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ❌ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@annevk annevk removed the safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks label Feb 13, 2025
@annevk
Copy link
Contributor

annevk commented Feb 13, 2025

I don't want to completely block this, but can we still make an attempt to steer the specification away from this? This contradicts https://w3ctag.github.io/design-principles/#casing-rules and it would be great to not set bad precedent that others will then copy from.

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Feb 13, 2025
@marcoscaceres marcoscaceres removed the merging-blocked Applied to prevent a change from being merged label Feb 13, 2025
@marcoscaceres marcoscaceres force-pushed the eng/WebIDL-Parser-should-support-dots-as-delimiters-in-enumerations branch from 61fecda to 95f8e6c Compare February 13, 2025 13:16
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Feb 13, 2025 •
edited
Loading

EWS run on previous version of this PR (hash 95f8e6c)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ❌ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@marcoscaceres marcoscaceres added the safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks label Feb 13, 2025
@marcoscaceres
Copy link
Contributor Author

Spoke to folks involved. Let's see if we can get them to change. Will revert this they do.

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Feb 13, 2025
@webkit-ews-buildbot
Copy link
Collaborator

Failed mac-wk1 checks. Please resolve failures and re-apply safe-merge-queue label.

Rejecting #40533 from merge queue.

@webkit-ews-buildbot webkit-ews-buildbot removed the safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks label Feb 13, 2025
@webkit-ews-buildbot
Copy link
Collaborator

Safe-Merge-Queue: Build #48690.

@marcoscaceres marcoscaceres removed the merging-blocked Applied to prevent a change from being merged label Feb 14, 2025
@marcoscaceres marcoscaceres force-pushed the eng/WebIDL-Parser-should-support-dots-as-delimiters-in-enumerations branch from 95f8e6c to ff661a0 Compare February 14, 2025 02:36
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Feb 14, 2025 •
edited
Loading

EWS run on current version of this PR (hash ff661a0)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ❌ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@marcoscaceres marcoscaceres added the safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks label Feb 14, 2025
@webkit-ews-buildbot
Copy link
Collaborator

Failed mac-wk1 checks. Please resolve failures and re-apply safe-merge-queue label.

Rejecting #40533 from merge queue.

@webkit-ews-buildbot webkit-ews-buildbot removed the safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks label Feb 14, 2025
@webkit-ews-buildbot
Copy link
Collaborator

Safe-Merge-Queue: Build #48754.

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Feb 14, 2025
@marcoscaceres marcoscaceres added merge-queue Applied to send a pull request to merge-queue and removed merging-blocked Applied to prevent a change from being merged labels Feb 16, 2025
@marcoscaceres
WebIDL Parser should support dots as delimiters in enumerations
9b41952 
https://bugs.webkit.org/show_bug.cgi?id=287606
rdar://144753892

Reviewed by Chris Dumez.

Adds support for dots as delimiters in enumerations
in the WebIDL code generator. This is needed as some other organizatons are
using dots in their enumerations (e.g, "org.iso.mdoc").

* Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:
(GetEnumerationValueName):
* Source/WebCore/bindings/scripts/test/JS/JSTestStandaloneEnumeration.cpp:
(WebCore::convertEnumerationToString):
(WebCore::parseEnumerationFromString<TestStandaloneEnumeration>):
(WebCore::expectedEnumerationValues<TestStandaloneEnumeration>):
* Source/WebCore/bindings/scripts/test/TestStandaloneEnumeration.idl:

Canonical link: https://commits.webkit.org/290454@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/WebIDL-Parser-should-support-dots-as-delimiters-in-enumerations branch from ff661a0 to 9b41952 Compare February 16, 2025 01:48
@webkit-commit-queue
Copy link
Collaborator

Committed 290454@main (9b41952): https://commits.webkit.org/290454@main

Reviewed commits have been landed. Closing PR #40533 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 9b41952 into WebKit:main Feb 16, 2025
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Feb 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdumez cdumez cdumez approved these changes

Assignees

@marcoscaceres marcoscaceres

Labels
WebCore Misc. For miscellaneous bugs in the WebCore framework (and not JavaScriptCore or WebKit).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@marcoscaceres @webkit-early-warning-system @annevk @webkit-ews-buildbot @webkit-commit-queue @cdumez