Skip to content

Conversation

calvaris
Copy link
Contributor

@calvaris calvaris commented Feb 14, 2025

4a987ca

[GStreamer][MSE] Can GStreamer other handle state changes while an async is ongoing?
https://bugs.webkit.org/show_bug.cgi?id=259775

Reviewed by NOBODY (OOPS!).

Yes, it can. Checks for ongoing state changes during other state changes and seeks were removed.

* Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::play):
(WebCore::MediaPlayerPrivateGStreamer::changePipelineState):
* Source/WebCore/platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp:
(WebCore::MediaPlayerPrivateGStreamerMSE::updateStates):

4a987ca

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ❌ 🧪 wpe-wk2 ✅ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ❌ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ❌ 🧪 mac-AS-debug-wk2 ❌ 🧪 gtk-wk2
loading 🧪 services ✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

…ync is ongoing?

https://bugs.webkit.org/show_bug.cgi?id=259775

Reviewed by NOBODY (OOPS!).

Yes, it can. Checks for ongoing state changes during other state changes and seeks were removed.

* Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::play):
(WebCore::MediaPlayerPrivateGStreamer::changePipelineState):
* Source/WebCore/platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp:
(WebCore::MediaPlayerPrivateGStreamerMSE::updateStates):
@calvaris calvaris requested a review from philn as a code owner February 14, 2025 15:26
@calvaris calvaris self-assigned this Feb 14, 2025
@calvaris calvaris added the Media Bugs related to the HTML 5 Media elements. label Feb 14, 2025
@philn
Copy link
Member

philn commented Feb 14, 2025

First time I see a bug title being a question. Can you reword this please? It's awkward :)

@calvaris
Copy link
Contributor Author

There are reports of problems at WebPlatformForEmbedded/WPEWebKit#1460 (comment) to I am closing this.

@calvaris calvaris closed this Feb 21, 2025
@calvaris calvaris deleted the eng/259775 branch February 21, 2025 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Media Bugs related to the HTML 5 Media elements. merging-blocked Applied to prevent a change from being merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants