Fix internal iOS builds following 290280@main #40716
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pxlcoder
added
the
New Bugs
|
EWS run on current version of this PR (hash ae6a223) |
aprotyas
approved these changes
Feb 17, 2025
pxlcoder
added
the
unsafe-merge-queue
webkit-commit-queue
force-pushed
the
eng/287807
branch
from
ae6a223 to
11f5578
Compare
https://bugs.webkit.org/show_bug.cgi?id=287807 rdar://144991668 Reviewed by Abrar Rahman Protyasha. SwiftUI.framework is unavailable in some images where WebKit.framework is available. Weak link SwiftUI to avoid build failures in those places. * Source/WebKit/Platform/cocoa/WKMaterialHostingSupport.h: Introduce an availability check to avoid crashing in places where SwiftUI is unavailable. * Source/WebKit/Platform/cocoa/WKMaterialHostingSupport.swift: (WKMaterialHostingSupport.isMaterialHostingAvailable): * Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeHost.mm: (WebKit::RemoteLayerTreeHost::makeNode): * Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteLayerTreeHostIOS.mm: (WebKit::RemoteLayerTreeHost::makeNode): Canonical link: https://commits.webkit.org/290493@main
webkit-commit-queue
force-pushed
the
eng/287807
branch
from
11f5578 to
dfce27a
Compare
|
Committed 290493@main (dfce27a): https://commits.webkit.org/290493@main Reviewed commits have been landed. Closing PR #40716 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dfce27a
ae6a223
🧪 wpe-wk2🧪 win-tests🧪 ios-wk2🧪 api-mac🧪 api-wpe🧪 ios-wk2-wpt🛠 wpe-cairo🧪 api-ios🧪 mac-AS-debug-wk2🧪 gtk-wk2🧪 vision-wk2🧪 mac-intel-wk2🛠 playstation🛠 mac-safer-cpp🛠 tv-sim🛠 watch🛠 watch-sim