-
Notifications
You must be signed in to change notification settings - Fork 1.6k
[GStreamer][WebRTC] Excessive tag events with bitrate update at startup #42690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
EWS run on previous version of this PR (hash 8372988) |
EWS run on previous version of this PR (hash 800a262) |
EWS failure seems unrelated. |
Source/WebCore/platform/mediastream/gstreamer/RealtimeIncomingSourceGStreamer.cpp
Outdated
Show resolved
Hide resolved
EWS run on previous version of this PR (hash 0cb70f2) |
@philn I found an easier solution after seeing that the high frequency of tag events with small bitrate updates only happens at startup! Therefore, applying some simple backpressure should already be enough to reduce the overhead. |
Source/WebCore/platform/mediastream/gstreamer/RealtimeIncomingSourceGStreamer.cpp
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but please fix the typo ;)
EWS run on current version of this PR (hash 37acfc6) |
Safe-Merge-Queue: Build #51983. |
https://bugs.webkit.org/show_bug.cgi?id=290045 Reviewed by Philippe Normand. Codec parsers like h264parse emit too many tag events at startup, while carrying only small bitrate updates. As time passes, bitrate updates are sent less frequently. Reduce the overhead in the pipelines at startup by forwarding tag events only every 1 second in RealtimeIncomingSourceGStreamer. Canonical link: https://commits.webkit.org/292399@main
37acfc6
to
18068fa
Compare
Committed 292399@main (18068fa): https://commits.webkit.org/292399@main Reviewed commits have been landed. Closing PR #42690 and removing active labels. |
18068fa
37acfc6