Skip to content

Conversation

pxlcoder
Copy link
Member

@pxlcoder pxlcoder commented Mar 26, 2025

3ce6e1e

[SwiftUI] Magnification gestures should be enabled by default on all platforms
https://bugs.webkit.org/show_bug.cgi?id=290484
rdar://147941344

Reviewed by Richard Robinson.

Align macOS and iOS default magnification behavior.

* Source/WebKit/_WebKit_SwiftUI/Implementation/WebViewRepresentable.swift:
(WebViewRepresentable.updatePlatformView(_:context:)):
* Tools/SwiftBrowser/Source/Views/ContentView.swift:
(ContentView.body):

Canonical link: https://commits.webkit.org/292736@main

d13b649

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug 🧪 wpe-wk2 ✅ 🧪 win-tests
✅ 🧪 webkitperl 🧪 ios-wk2 🧪 api-mac ✅ 🧪 api-wpe
🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
🛠 vision 🧪 mac-AS-debug-wk2 🧪 gtk-wk2
🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
⏳ 🧪 vision-wk2 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 🧪 unsafe-merge ✅ 🛠 tv 🛠 mac-safer-cpp
🛠 tv-sim
🛠 watch
✅ 🛠 watch-sim

@pxlcoder pxlcoder requested a review from JonWBedard as a code owner March 26, 2025 23:04
@pxlcoder pxlcoder self-assigned this Mar 26, 2025
@pxlcoder pxlcoder added the New Bugs Unclassified bugs are placed in this component until the correct component can be determined. label Mar 26, 2025
@pxlcoder pxlcoder requested a review from rr-codes March 26, 2025 23:04
@pxlcoder pxlcoder added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Mar 27, 2025
…platforms

https://bugs.webkit.org/show_bug.cgi?id=290484
rdar://147941344

Reviewed by Richard Robinson.

Align macOS and iOS default magnification behavior.

* Source/WebKit/_WebKit_SwiftUI/Implementation/WebViewRepresentable.swift:
(WebViewRepresentable.updatePlatformView(_:context:)):
* Tools/SwiftBrowser/Source/Views/ContentView.swift:
(ContentView.body):

Canonical link: https://commits.webkit.org/292736@main
@webkit-commit-queue
Copy link
Collaborator

Committed 292736@main (3ce6e1e): https://commits.webkit.org/292736@main

Reviewed commits have been landed. Closing PR #43068 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 3ce6e1e into WebKit:main Mar 27, 2025
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Mar 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

New Bugs Unclassified bugs are placed in this component until the correct component can be determined.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants