Skip to content

Conversation

TingPing
Copy link
Contributor

@TingPing TingPing commented Apr 10, 2025

7154d37

[WPE] Remove unnecessary introspection annotations
https://bugs.webkit.org/show_bug.cgi?id=291354

Reviewed by Michael Catanzaro.

This used the copy-func and free-func annotations which was
added in gobject-introspection 1.74 (1 year newer than our
glib dep 2.70).

However this struct is a GBoxed type so introspection already
knows this information and it can be removed.

* Source/WebKit/WPEPlatform/wpe/WPEBufferDMABufFormats.cpp:

Canonical link: https://commits.webkit.org/293523@main

573a08c

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe 🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug 🧪 wpe-wk2 🧪 win-tests
✅ 🧪 webkitperl 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🛠 wpe-cairo
✅ 🧪 api-ios 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision 🧪 mac-AS-debug-wk2 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
🧪 vision-wk2 🧪 mac-intel-wk2 🛠 playstation
✅ 🛠 🧪 unsafe-merge ✅ 🛠 tv 🛠 mac-safer-cpp
🛠 tv-sim
🛠 watch
🛠 watch-sim

@TingPing TingPing requested a review from a team as a code owner April 10, 2025 15:38
@TingPing TingPing self-assigned this Apr 10, 2025
@TingPing TingPing added the WPE WebKit WebKit WPE component label Apr 10, 2025
@TingPing TingPing added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Apr 10, 2025
https://bugs.webkit.org/show_bug.cgi?id=291354

Reviewed by Michael Catanzaro.

This used the copy-func and free-func annotations which was
added in gobject-introspection 1.74 (1 year newer than our
glib dep 2.70).

However this struct is a GBoxed type so introspection already
knows this information and it can be removed.

* Source/WebKit/WPEPlatform/wpe/WPEBufferDMABufFormats.cpp:

Canonical link: https://commits.webkit.org/293523@main
@webkit-commit-queue webkit-commit-queue force-pushed the pgriffis/introspection-annotation branch from 573a08c to 7154d37 Compare April 10, 2025 16:13
@webkit-commit-queue
Copy link
Collaborator

Committed 293523@main (7154d37): https://commits.webkit.org/293523@main

Reviewed commits have been landed. Closing PR #43905 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 7154d37 into WebKit:main Apr 10, 2025
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Apr 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WPE WebKit WebKit WPE component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants