Skip to content

Conversation

aestes
Copy link
Contributor

@aestes aestes commented Jun 5, 2025

6bdace1

Add more logging to MediaSessionHelperIOS::providePresentingApplicationPID
https://bugs.webkit.org/show_bug.cgi?id=294062

Reviewed by Youenn Fablet.

Logged when MediaSessionHelperIOS::providePresentingApplicationPID is called with a unique PID.
While here, removed some optional soft-linking that is no longer necessary.

* Source/WebCore/platform/audio/ios/MediaSessionHelperIOS.mm:
(MediaSessionHelperIOS::providePresentingApplicationPID):
(-[WebMediaSessionHelper initWithCallback:]):

Canonical link: https://commits.webkit.org/295883@main

b3be794

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ❌ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@aestes aestes self-assigned this Jun 5, 2025
@aestes aestes added the Media Bugs related to the HTML 5 Media elements. label Jun 5, 2025
@aestes aestes requested review from a team and youennf June 5, 2025 05:10
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jun 5, 2025
@aestes aestes added merge-queue Applied to send a pull request to merge-queue and removed merging-blocked Applied to prevent a change from being merged labels Jun 5, 2025
…onPID

https://bugs.webkit.org/show_bug.cgi?id=294062

Reviewed by Youenn Fablet.

Logged when MediaSessionHelperIOS::providePresentingApplicationPID is called with a unique PID.
While here, removed some optional soft-linking that is no longer necessary.

* Source/WebCore/platform/audio/ios/MediaSessionHelperIOS.mm:
(MediaSessionHelperIOS::providePresentingApplicationPID):
(-[WebMediaSessionHelper initWithCallback:]):

Canonical link: https://commits.webkit.org/295883@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Add-more-logging-to-MediaSessionHelperIOS-providePresentingApplicationPID branch from b3be794 to 6bdace1 Compare June 5, 2025 19:01
@webkit-commit-queue
Copy link
Collaborator

Committed 295883@main (6bdace1): https://commits.webkit.org/295883@main

Reviewed commits have been landed. Closing PR #46359 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 6bdace1 into WebKit:main Jun 5, 2025
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jun 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Media Bugs related to the HTML 5 Media elements.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants