-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Extend Fetch to accept local connections #49639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
EWS run on previous version of this PR (hash 626a279) |
626a279
to
34d361f
Compare
EWS run on previous version of this PR (hash 34d361f) |
34d361f
to
f8d847f
Compare
EWS run on previous version of this PR (hash f8d847f) |
f8d847f
to
3b4a20f
Compare
EWS run on previous version of this PR (hash 3b4a20f) |
3b4a20f
to
29d6dc1
Compare
EWS run on current version of this PR (hash 29d6dc1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for correcting the missing include.
https://bugs.webkit.org/show_bug.cgi?id=296710 rdar://154439024 Reviewed by Alex Christensen. Reintroducing changes that had previously caused build failure. Original PR: 298921@main (d4e2bd4) Integration with fetch as per the local network access spec: (https://wicg.github.io/local-network-access/#integration-with-fetch) * LayoutTests/TestExpectations: * LayoutTests/ipc/invalid-url-network-data-task-crash.html: * LayoutTests/platform/glib/TestExpectations: * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: * Source/WebCore/DerivedSources.make: * Source/WebCore/Modules/fetch/FetchRequest.cpp: (WebCore::updateTargetAddressSpaceIfNeeded): (WebCore::FetchRequest::initializeWith): (WebCore::FetchRequest::resourceRequest const): (WebCore::FetchRequest::clone): * Source/WebCore/Modules/fetch/FetchRequest.h: * Source/WebCore/Modules/fetch/FetchRequest.idl: * Source/WebCore/Modules/fetch/FetchRequestInit.h: (WebCore::FetchRequestInit::hasMembers const): * Source/WebCore/Modules/fetch/FetchRequestInit.idl: * Source/WebCore/Modules/fetch/IPAddressSpace.cpp: Added. (WebCore::determineIPAddressSpace): (WebCore::isLocalIPAddressSpace): * Source/WebCore/Modules/fetch/IPAddressSpace.h: * Source/WebCore/Modules/geolocation/Geolocation.h: * Source/WebCore/Modules/mediasession/MediaSessionCoordinator.cpp: * Source/WebCore/Modules/mediastream/MediaStreamTrackProcessor.cpp: * Source/WebCore/Modules/mediastream/RTCSessionDescription.h: * Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCRtpSenderBackend.h: * Source/WebCore/Modules/notifications/NotificationEvent.cpp: * Source/WebCore/Modules/streams/WritableStream.h: * Source/WebCore/Modules/webaudio/AudioNode.h: * Source/WebCore/Modules/webauthn/PublicKeyCredential.cpp: * Source/WebCore/Modules/webdatabase/SQLResultSetRowList.h: * Source/WebCore/Sources.txt: * Source/WebCore/WebCore.xcodeproj/project.pbxproj: * Source/WebCore/dom/SecurityContext.cpp: (WebCore::SecurityContext::policyContainer const): (WebCore::SecurityContext::inheritPolicyContainerFrom): * Source/WebCore/dom/SecurityContext.h: (WebCore::SecurityContext::ipAddressSpace const): (WebCore::SecurityContext::setIPAddressSpace): * Source/WebCore/loader/LinkLoader.cpp: * Source/WebCore/loader/PolicyContainer.h: (WebCore::PolicyContainer::isolatedCopy const): (WebCore::PolicyContainer::isolatedCopy): * Source/WebCore/platform/network/ResourceRequestBase.cpp: * Source/WebCore/platform/network/ResourceRequestBase.h: (WebCore::ResourceRequestBase::RequestData::RequestData): (WebCore::ResourceRequestBase::targetAddressSpace const): (WebCore::ResourceRequestBase::setTargetAddressSpace): * Source/WebCore/platform/network/ResourceResponseBase.cpp: (WebCore::m_ipAddressSpace): (WebCore::ResourceResponseData::isolatedCopy const): (WebCore::ResourceResponseBase::crossThreadData const): (WebCore::ResourceResponseBase::fromCrossThreadData): (WebCore::ResourceResponseBase::getResponseData const): (WTF::Persistence::Coder<WebCore::ResourceResponseData>::decodeForPersistence): (WebCore::m_type): Deleted. * Source/WebCore/platform/network/ResourceResponseBase.h: (WebCore::ResourceResponseBase::ipAddressSpace): (WebCore::ResourceResponseBase::setIPAddressSpace): (WebCore::ResourceResponseData::ResourceResponseData): * Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in: * Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * Tools/TestWebKitAPI/Tests/WebCore/IPAddressSpaceTests.cpp: Added. (TestWebKitAPI::TEST(IPAddressSpace, IPv4Loopback)): (TestWebKitAPI::TEST(IPAddressSpace, IPv4PrivateAddresses)): (TestWebKitAPI::TEST(IPAddressSpace, IPv4CarrierGradeNAT)): (TestWebKitAPI::TEST(IPAddressSpace, IPv4LinkLocal)): (TestWebKitAPI::TEST(IPAddressSpace, IPv4Benchmarking)): (TestWebKitAPI::TEST(IPAddressSpace, IPv4PublicAddresses)): (TestWebKitAPI::TEST(IPAddressSpace, IPv6Loopback)): (TestWebKitAPI::TEST(IPAddressSpace, IPv6UniqueLocal)): (TestWebKitAPI::TEST(IPAddressSpace, IPv6LinkLocal)): (TestWebKitAPI::TEST(IPAddressSpace, IPv6MappedIPv4DottedDecimal)): (TestWebKitAPI::TEST(IPAddressSpace, IPv6MappedIPv4HexNotation)): (TestWebKitAPI::TEST(IPAddressSpace, IPv6PublicAddresses)): (TestWebKitAPI::TEST(IPAddressSpace, HostnameAddresses)): (TestWebKitAPI::TEST(IPAddressSpace, EdgeCasesAndMalformed)): (TestWebKitAPI::TEST(IPAddressSpace, UtilityFunctions)): (TestWebKitAPI::TEST(IPAddressSpace, DifferentURLSchemes)): (TestWebKitAPI::TEST(IPAddressSpace, URLsWithPorts)): (TestWebKitAPI::TEST(IPAddressSpace, IPv4BoundaryConditions)): Canonical link: https://commits.webkit.org/298981@main
29d6dc1
to
a3bc93f
Compare
Committed 298981@main (a3bc93f): https://commits.webkit.org/298981@main Reviewed commits have been landed. Closing PR #49639 and removing active labels. |
a3bc93f
29d6dc1
🛠 playstation