-
Notifications
You must be signed in to change notification settings - Fork 1.7k
[css-anchor-position-1] Acceptable anchor algorithm should consider inline containing block #51056
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
EWS run on previous version of this PR (hash fd7806c) |
|
WPT Pull Request: web-platform-tests/wpt#55023 |
fd7806c
to
953acf1
Compare
EWS run on current version of this PR (hash 953acf1) |
…nline containing block rdar://160917762 https://bugs.webkit.org/show_bug.cgi?id=299157 Reviewed by Elika Etemad. THe acceptable anchor code uses RenderObject::containingBlock() to get the containing block, but the name is a bit deceptive: it returns the container that is a _block element_. For determining acceptable anchor, the containing block could be an inline element. Switch to using RenderObject::container(), which does return an inline element as containing block. Test: LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/anchor-scroll-004.html * LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/anchor-name-inline-001-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/anchor-scroll-004-expected.txt: * Source/WebCore/style/AnchorPositionEvaluator.cpp: (WebCore::Style::penultimateContainingBlockChainElement): (WebCore::Style::firstChildPrecedesSecondChild): Canonical link: https://commits.webkit.org/300614@main
953acf1
to
39cf916
Compare
Committed 300614@main (39cf916): https://commits.webkit.org/300614@main Reviewed commits have been landed. Closing PR #51056 and removing active labels. |
39cf916
953acf1
🧪 win-tests