Skip to content

Conversation

sosukesuzuki
Copy link
Member

@sosukesuzuki sosukesuzuki commented Sep 22, 2025

d9a997b

[JSC] Suppprt `Promise.any` in async stack trace
https://bugs.webkit.org/show_bug.cgi?id=299288

Reviewed by Yusuke Suzuki.

This patch changes async stack trace to support `Promise.any`.

Test: JSTests/stress/async-stack-trace-promise-any-basic.js

Test: JSTests/stress/async-stack-trace-promise-any-basic.js
* JSTests/stress/async-stack-trace-promise-any-basic.js: Added.
(nop):
(shouldBe):
(testStack):
(async fine):
(async thrower):
(async run):
(i.const.aggregateError.shouldThrowAsync.async test):
(testStack.async task1):
(testStack.async task2):
(testStack.async task3):
(testStack.async run):
* Source/JavaScriptCore/builtins/PromiseConstructor.js:
(any):
* Source/JavaScriptCore/interpreter/Interpreter.cpp:
(JSC::Interpreter::getAsyncStackTrace):

Canonical link: https://commits.webkit.org/300623@main

b0a5dff

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🛠 🧪 jsc ✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 tv ✅ 🛠 mac-safer-cpp ✅ 🛠 jsc-armv7
✅ 🛠 tv-sim ✅ 🧪 jsc-armv7-tests
✅ 🛠 watch
✅ 🛠 watch-sim

@sosukesuzuki sosukesuzuki requested a review from a team as a code owner September 22, 2025 14:40
@sosukesuzuki sosukesuzuki self-assigned this Sep 22, 2025
@sosukesuzuki sosukesuzuki added the JavaScriptCore For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues. label Sep 22, 2025
@sosukesuzuki sosukesuzuki added merge-queue Applied to send a pull request to merge-queue and removed merge-queue Applied to send a pull request to merge-queue labels Sep 27, 2025
@sosukesuzuki sosukesuzuki force-pushed the eng/promise-any-async-stack-trace branch from f5979ce to b0a5dff Compare September 27, 2025 00:28
@sosukesuzuki sosukesuzuki added the merge-queue Applied to send a pull request to merge-queue label Sep 27, 2025
https://bugs.webkit.org/show_bug.cgi?id=299288

Reviewed by Yusuke Suzuki.

This patch changes async stack trace to support `Promise.any`.

Test: JSTests/stress/async-stack-trace-promise-any-basic.js

Test: JSTests/stress/async-stack-trace-promise-any-basic.js
* JSTests/stress/async-stack-trace-promise-any-basic.js: Added.
(nop):
(shouldBe):
(testStack):
(async fine):
(async thrower):
(async run):
(i.const.aggregateError.shouldThrowAsync.async test):
(testStack.async task1):
(testStack.async task2):
(testStack.async task3):
(testStack.async run):
* Source/JavaScriptCore/builtins/PromiseConstructor.js:
(any):
* Source/JavaScriptCore/interpreter/Interpreter.cpp:
(JSC::Interpreter::getAsyncStackTrace):

Canonical link: https://commits.webkit.org/300623@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/promise-any-async-stack-trace branch from b0a5dff to d9a997b Compare September 27, 2025 05:37
@webkit-commit-queue
Copy link
Collaborator

Committed 300623@main (d9a997b): https://commits.webkit.org/300623@main

Reviewed commits have been landed. Closing PR #51118 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit d9a997b into WebKit:main Sep 27, 2025
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Sep 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

JavaScriptCore For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants