Skip to content

Conversation

Ahmad-S792
Copy link
Contributor

@Ahmad-S792 Ahmad-S792 commented Sep 24, 2025

503e5f0

Remove `audioparam-cancel-and-hold` and `audioparam-nominal-range` local tests in favor of WPT
https://bugs.webkit.org/show_bug.cgi?id=299451
rdar://161259561

Reviewed by Sihui Liu.

This patch removes two local WPT tests, which exist with same name on WPT,
moved by Chromium / Blink. We haven't removed them till recently since our
WebAudio tests were quite out of sync, which I manage to tackle and do now
often occassional syncs.

As drive-by, I also removed stale test expectation for another test
(i.g., `audioparam-setValueCurve-exceptions`), which I tackled earlier.

* LayoutTests/webaudio/AudioParam/audioparam-cancel-and-hold-expected.txt: Removed.
* LayoutTests/webaudio/AudioParam/audioparam-cancel-and-hold.html: Removed.
* LayoutTests/webaudio/AudioParam/audioparam-nominal-range-expected.txt: Removed.
* LayoutTests/webaudio/AudioParam/audioparam-nominal-range.html: Removed.
* LayoutTests/webaudio/AudioParam/audioparam-setValueCurve-exceptions-expected.txt: Removed.

Canonical link: https://commits.webkit.org/300479@main

0ea309a

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows Apple Internal
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe 🛠 win ✅ 🛠 ios-apple
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug 🧪 wpe-wk2 🧪 win-tests ❌ 🛠 mac-apple
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe ✅ 🛠 vision-apple
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 🛠 playstation
✅ 🛠 tv
🛠 tv-sim
🛠 watch
✅ 🛠 watch-sim

@Ahmad-S792 Ahmad-S792 self-assigned this Sep 24, 2025
@Ahmad-S792 Ahmad-S792 added the Web Audio Bugs against the Web Audio API label Sep 24, 2025
@Ahmad-S792 Ahmad-S792 requested review from nt1m and szewai September 24, 2025 17:45
@Ahmad-S792 Ahmad-S792 changed the title Remove audioparam-setValueCurve-exceptions and audioparam-nominal-range local tests in favor of WPT Remove audioparam-cancel-and-hold and audioparam-nominal-range local tests in favor of WPT Sep 24, 2025
@Ahmad-S792 Ahmad-S792 force-pushed the eng/Remove-audioparam-setValueCurve-exceptions-and-audioparam-nominal-range-local-tests-in-favor-of-WPT branch from 9cb49a5 to 0ea309a Compare September 24, 2025 17:58
@Ahmad-S792 Ahmad-S792 added the merge-queue Applied to send a pull request to merge-queue label Sep 24, 2025
…cal tests in favor of WPT

https://bugs.webkit.org/show_bug.cgi?id=299451
rdar://161259561

Reviewed by Sihui Liu.

This patch removes two local WPT tests, which exist with same name on WPT,
moved by Chromium / Blink. We haven't removed them till recently since our
WebAudio tests were quite out of sync, which I manage to tackle and do now
often occassional syncs.

As drive-by, I also removed stale test expectation for another test
(i.g., `audioparam-setValueCurve-exceptions`), which I tackled earlier.

* LayoutTests/webaudio/AudioParam/audioparam-cancel-and-hold-expected.txt: Removed.
* LayoutTests/webaudio/AudioParam/audioparam-cancel-and-hold.html: Removed.
* LayoutTests/webaudio/AudioParam/audioparam-nominal-range-expected.txt: Removed.
* LayoutTests/webaudio/AudioParam/audioparam-nominal-range.html: Removed.
* LayoutTests/webaudio/AudioParam/audioparam-setValueCurve-exceptions-expected.txt: Removed.

Canonical link: https://commits.webkit.org/300479@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Remove-audioparam-setValueCurve-exceptions-and-audioparam-nominal-range-local-tests-in-favor-of-WPT branch from 0ea309a to 503e5f0 Compare September 24, 2025 20:27
@webkit-commit-queue
Copy link
Collaborator

Committed 300479@main (503e5f0): https://commits.webkit.org/300479@main

Reviewed commits have been landed. Closing PR #51267 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 503e5f0 into WebKit:main Sep 24, 2025
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Sep 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Web Audio Bugs against the Web Audio API

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants