Skip to content

Conversation

philn
Copy link
Member

@philn philn commented Sep 29, 2025

eb10357

REGRESSION(298889@main): [WPE][GTK] Broke WebRTC event logging
https://bugs.webkit.org/show_bug.cgi?id=299723

Reviewed by Xabier Rodriguez-Calvar.

In 298889@main the log site identifiers format changed from hexadecimal to plain uint64_t, which
broke WebRTC event logging in the WPE and GTK ports. So adapt our code accordingly using this new
format.

* Source/WebCore/Modules/mediastream/PeerConnectionBackend.cpp:
(WebCore::PeerConnectionBackend::handleLogMessage):
* Source/WebCore/Modules/mediastream/gstreamer/GStreamerPeerConnectionBackend.cpp:
(WebCore::GStreamerPeerConnectionBackend::GStreamerPeerConnectionBackend):
* Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):

Canonical link: https://commits.webkit.org/300739@main

1e779ce

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@philn philn self-assigned this Sep 29, 2025
@philn philn added the Platform Portability improvements and other general platform improvements not driven directly by site bugs. label Sep 29, 2025
@philn philn requested a review from calvaris September 29, 2025 10:17
@philn philn added the merge-queue Applied to send a pull request to merge-queue label Sep 30, 2025
https://bugs.webkit.org/show_bug.cgi?id=299723

Reviewed by Xabier Rodriguez-Calvar.

In 298889@main the log site identifiers format changed from hexadecimal to plain uint64_t, which
broke WebRTC event logging in the WPE and GTK ports. So adapt our code accordingly using this new
format.

* Source/WebCore/Modules/mediastream/PeerConnectionBackend.cpp:
(WebCore::PeerConnectionBackend::handleLogMessage):
* Source/WebCore/Modules/mediastream/gstreamer/GStreamerPeerConnectionBackend.cpp:
(WebCore::GStreamerPeerConnectionBackend::GStreamerPeerConnectionBackend):
* Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):

Canonical link: https://commits.webkit.org/300739@main
@webkit-commit-queue
Copy link
Collaborator

Committed 300739@main (eb10357): https://commits.webkit.org/300739@main

Reviewed commits have been landed. Closing PR #51495 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit eb10357 into WebKit:main Sep 30, 2025
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Sep 30, 2025
@philn philn deleted the eng/299723 branch September 30, 2025 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Platform Portability improvements and other general platform improvements not driven directly by site bugs.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants