[Live Range Selection] A few tests fail due to behavior difference in VisibleSelection::selectionFromContentsOfNode #5197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rniwa
added
HTML Editing
|
EWS run on current version of this PR (hash 4fe3f87) |
darinadler
approved these changes
Oct 10, 2022
rniwa
added
the
unsafe-merge-queue
… VisibleSelection::selectionFromContentsOfNode https://bugs.webkit.org/show_bug.cgi?id=246284 Reviewed by Darin Adler. Explicitly canonicalize selection start & end in VisibleSelection::selectionFromContentsOfNode so that enabling live range selection wouldn't cause a new test failure. Also add variants of the tests that enable live range selection. * LayoutTests/editing/deleting/paste-with-transparent-background-color-live-range-expected.txt: Added. * LayoutTests/editing/deleting/paste-with-transparent-background-color-live-range.html: Added. * LayoutTests/editing/execCommand/delete-selection-has-style-live-range-expected.txt: Added. * LayoutTests/editing/execCommand/delete-selection-has-style-live-range.html: Added. * LayoutTests/editing/input/select-all-clear-input-method-live-range-expected.txt: Added. * LayoutTests/editing/input/select-all-clear-input-method-live-range.html: Added. * LayoutTests/editing/pasteboard/contenteditable-pre-2-live-range-expected.txt: Added. * LayoutTests/editing/pasteboard/contenteditable-pre-2-live-range.html: Added. * LayoutTests/editing/pasteboard/copy-paste-content-starting-and-ending-canvas-live-range-expected.txt: Added. * LayoutTests/editing/pasteboard/copy-paste-content-starting-and-ending-canvas-live-range.html: Added. * LayoutTests/editing/pasteboard/preserve-line-break-at-end-of-pasted-content-live-range-expected.txt: Added. * LayoutTests/editing/pasteboard/preserve-line-break-at-end-of-pasted-content-live-range.html: Added. * LayoutTests/editing/selection/select-all-user-select-none-live-range-expected.txt: Added. * LayoutTests/editing/selection/select-all-user-select-none-live-range.html: Added. * Source/WebCore/editing/VisibleSelection.cpp: (WebCore::VisibleSelection::selectionFromContentsOfNode): Canonical link: https://commits.webkit.org/255372@main
webkit-early-warning-system
force-pushed
the
fix246284
branch
from
4fe3f87 to
aef26c6
Compare
|
Committed 255372@main (aef26c6): https://commits.webkit.org/255372@main Reviewed commits have been landed. Closing PR #5197 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aef26c6
4fe3f87
🛠 🧪 win🧪 api-gtk🧪 mac-wk1🧪 mac-AS-debug-wk2