[Temporal] Add PlainMonthDay #52010

catamorphism · 2025-10-08T15:18:06Z

`dab2cf7`

[Temporal] Add PlainMonthDay
https://bugs.webkit.org/show_bug.cgi?id=300389

Reviewed by Yusuke Suzuki.

Add basic support for Temporal PlainMonthDay type, without most
methods yet.

Test: JSTests/stress/temporal-plainmonthday.js
* JSTests/stress/temporal-plainmonthday.js: Added.
(shouldBe):
(shouldThrow):
(const.monthDay.new.Temporal.PlainMonthDay):
* JSTests/test262/config.yaml:
* Source/JavaScriptCore/CMakeLists.txt:
* Source/JavaScriptCore/DerivedSources.make:
* Source/JavaScriptCore/Sources.txt:
* Source/JavaScriptCore/runtime/ISO8601.h:
* Source/JavaScriptCore/runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::init):
(JSC::JSGlobalObject::visitChildrenImpl):
* Source/JavaScriptCore/runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::plainMonthDayStructure):
* Source/JavaScriptCore/runtime/TemporalObject.cpp:
(JSC::createPlainMonthDayConstructor):
(JSC::toTemporalOverflow):
* Source/JavaScriptCore/runtime/TemporalObject.h:
* Source/JavaScriptCore/runtime/TemporalPlainMonthDay.cpp: Added.
(JSC::TemporalPlainMonthDay::create):
(JSC::TemporalPlainMonthDay::createStructure):
(JSC::TemporalPlainMonthDay::TemporalPlainMonthDay):
(JSC::TemporalPlainMonthDay::finishCreation):
(JSC::TemporalPlainMonthDay::visitChildrenImpl):
(JSC::TemporalPlainMonthDay::tryCreateIfValid):
(JSC::TemporalPlainMonthDay::monthCode const):
* Source/JavaScriptCore/runtime/TemporalPlainMonthDay.h: Added.
* Source/JavaScriptCore/runtime/TemporalPlainMonthDayConstructor.cpp: Added.
(JSC::TemporalPlainMonthDayConstructor::create):
(JSC::TemporalPlainMonthDayConstructor::createStructure):
(JSC::TemporalPlainMonthDayConstructor::TemporalPlainMonthDayConstructor):
(JSC::TemporalPlainMonthDayConstructor::finishCreation):
(JSC::JSC_DEFINE_HOST_FUNCTION):
* Source/JavaScriptCore/runtime/TemporalPlainMonthDayConstructor.h: Added.
* Source/JavaScriptCore/runtime/TemporalPlainMonthDayPrototype.cpp: Added.
(JSC::TemporalPlainMonthDayPrototype::create):
(JSC::TemporalPlainMonthDayPrototype::createStructure):
(JSC::TemporalPlainMonthDayPrototype::TemporalPlainMonthDayPrototype):
(JSC::TemporalPlainMonthDayPrototype::finishCreation):
(JSC::JSC_DEFINE_CUSTOM_GETTER):
* Source/JavaScriptCore/runtime/TemporalPlainMonthDayPrototype.h: Added.

Canonical link: https://commits.webkit.org/301244@main

299221f

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	~~🧪 win-tests~~
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-cairo
✅ 🛠 🧪 jsc	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64	✅ 🛠 vision	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
	✅ 🧪 vision-wk2	✅ 🧪 mac-intel-wk2	~~🛠 playstation~~
✅ 🛠 🧪 unsafe-merge	✅ 🛠 tv	✅ 🛠 mac-safer-cpp	✅ 🛠 jsc-armv7
	✅ 🛠 tv-sim		✅ 🧪 jsc-armv7-tests
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2025-10-08T15:18:13Z

EWS run on previous version of this PR (hash ea57bb2)

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	~~🛠 wpe~~	⏳ 🛠 win
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~	⏳ 🧪 win-tests
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	~~🧪 api-mac~~	~~🧪 api-wpe~~
	~~🧪 ios-wk2-wpt~~	~~🧪 mac-wk1~~	~~🛠 wpe-cairo~~
✅ 🛠 🧪 jsc	~~🧪 api-ios~~	~~🧪 mac-wk2~~	~~🛠 gtk~~
✅ 🛠 🧪 jsc-arm64	✅ 🛠 vision	~~🧪 mac-AS-debug-wk2~~	~~🧪 gtk-wk2~~
	✅ 🛠 vision-sim	~~🧪 mac-wk2-stress~~	~~🧪 api-gtk~~
	~~🧪 vision-wk2~~	~~🧪 mac-intel-wk2~~	~~🛠 playstation~~
	✅ 🛠 tv	~~🛠 mac-safer-cpp~~	✅ 🛠 jsc-armv7
	✅ 🛠 tv-sim		~~🧪 jsc-armv7-tests~~
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2025-10-08T15:24:57Z

EWS run on previous version of this PR (hash d2bab08)

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	⏳ 🧪 win-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-cairo
✅ 🛠 🧪 jsc	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64	✅ 🛠 vision	⏳ 🧪 mac-AS-debug-wk2	❌ 🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
	✅ 🧪 vision-wk2	✅ 🧪 mac-intel-wk2	~~🛠 playstation~~
	✅ 🛠 tv	✅ 🛠 mac-safer-cpp	✅ 🛠 jsc-armv7
	✅ 🛠 tv-sim		✅ 🧪 jsc-armv7-tests
	✅ 🛠 watch
	✅ 🛠 watch-sim

Constellation · 2025-10-08T18:38:06Z

Source/JavaScriptCore/runtime/ISO8601.h

        : year(y), month(m) { }
 };

+class PlainMonthDay {


Also, that PlainDate's year's double looks bad. It must be int32_t and out of range year should be represented via special Int32. Using double is supper slow. Can you add a FIXME? I think we cannot enable Temporal until it gets fixed.

Added a FIXME -- also, what do you mean by "special Int32"?

Indicating Out-of-range via INT32_MIN for example.

Yeah this is changed in f1cf8d2, this is not OK. This is hard blocker for enablement definitely.

webkit-early-warning-system · 2025-10-08T18:45:22Z

EWS run on current version of this PR (hash 299221f)

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	~~🧪 win-tests~~
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-cairo
✅ 🛠 🧪 jsc	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64	✅ 🛠 vision	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
	✅ 🧪 vision-wk2	✅ 🧪 mac-intel-wk2	~~🛠 playstation~~
✅ 🛠 🧪 unsafe-merge	✅ 🛠 tv	✅ 🛠 mac-safer-cpp	✅ 🛠 jsc-armv7
	✅ 🛠 tv-sim		✅ 🧪 jsc-armv7-tests
	✅ 🛠 watch
	✅ 🛠 watch-sim

https://bugs.webkit.org/show_bug.cgi?id=300389 Reviewed by Yusuke Suzuki. Add basic support for Temporal PlainMonthDay type, without most methods yet. Test: JSTests/stress/temporal-plainmonthday.js * JSTests/stress/temporal-plainmonthday.js: Added. (shouldBe): (shouldThrow): (const.monthDay.new.Temporal.PlainMonthDay): * JSTests/test262/config.yaml: * Source/JavaScriptCore/CMakeLists.txt: * Source/JavaScriptCore/DerivedSources.make: * Source/JavaScriptCore/Sources.txt: * Source/JavaScriptCore/runtime/ISO8601.h: * Source/JavaScriptCore/runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::init): (JSC::JSGlobalObject::visitChildrenImpl): * Source/JavaScriptCore/runtime/JSGlobalObject.h: (JSC::JSGlobalObject::plainMonthDayStructure): * Source/JavaScriptCore/runtime/TemporalObject.cpp: (JSC::createPlainMonthDayConstructor): (JSC::toTemporalOverflow): * Source/JavaScriptCore/runtime/TemporalObject.h: * Source/JavaScriptCore/runtime/TemporalPlainMonthDay.cpp: Added. (JSC::TemporalPlainMonthDay::create): (JSC::TemporalPlainMonthDay::createStructure): (JSC::TemporalPlainMonthDay::TemporalPlainMonthDay): (JSC::TemporalPlainMonthDay::finishCreation): (JSC::TemporalPlainMonthDay::visitChildrenImpl): (JSC::TemporalPlainMonthDay::tryCreateIfValid): (JSC::TemporalPlainMonthDay::monthCode const): * Source/JavaScriptCore/runtime/TemporalPlainMonthDay.h: Added. * Source/JavaScriptCore/runtime/TemporalPlainMonthDayConstructor.cpp: Added. (JSC::TemporalPlainMonthDayConstructor::create): (JSC::TemporalPlainMonthDayConstructor::createStructure): (JSC::TemporalPlainMonthDayConstructor::TemporalPlainMonthDayConstructor): (JSC::TemporalPlainMonthDayConstructor::finishCreation): (JSC::JSC_DEFINE_HOST_FUNCTION): * Source/JavaScriptCore/runtime/TemporalPlainMonthDayConstructor.h: Added. * Source/JavaScriptCore/runtime/TemporalPlainMonthDayPrototype.cpp: Added. (JSC::TemporalPlainMonthDayPrototype::create): (JSC::TemporalPlainMonthDayPrototype::createStructure): (JSC::TemporalPlainMonthDayPrototype::TemporalPlainMonthDayPrototype): (JSC::TemporalPlainMonthDayPrototype::finishCreation): (JSC::JSC_DEFINE_CUSTOM_GETTER): * Source/JavaScriptCore/runtime/TemporalPlainMonthDayPrototype.h: Added. Canonical link: https://commits.webkit.org/301244@main

webkit-commit-queue · 2025-10-09T03:28:50Z

Committed 301244@main (dab2cf7): https://commits.webkit.org/301244@main

Reviewed commits have been landed. Closing PR #52010 and removing active labels.

catamorphism requested a review from a team as a code owner October 8, 2025 15:18

catamorphism self-assigned this Oct 8, 2025

catamorphism added the JavaScriptCore For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues. label Oct 8, 2025

catamorphism force-pushed the plainmonthday-plainyearmonth-part-2 branch from ea57bb2 to d2bab08 Compare October 8, 2025 15:24

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Oct 8, 2025

Constellation approved these changes Oct 8, 2025

View reviewed changes

catamorphism force-pushed the plainmonthday-plainyearmonth-part-2 branch from d2bab08 to 299221f Compare October 8, 2025 18:45

catamorphism added request-merge-queue Request a pull request to be added to merge-queue once ready and removed merging-blocked Applied to prevent a change from being merged labels Oct 8, 2025

fujii added unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing and removed request-merge-queue Request a pull request to be added to merge-queue once ready labels Oct 9, 2025

webkit-commit-queue force-pushed the plainmonthday-plainyearmonth-part-2 branch from 299221f to dab2cf7 Compare October 9, 2025 03:28

webkit-commit-queue merged commit dab2cf7 into WebKit:main Oct 9, 2025

webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Oct 9, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Temporal] Add PlainMonthDay #52010

[Temporal] Add PlainMonthDay #52010

catamorphism commented Oct 8, 2025 •

edited by webkit-early-warning-system

Loading

Uh oh!

webkit-early-warning-system commented Oct 8, 2025 •

edited

Loading

Uh oh!

webkit-early-warning-system commented Oct 8, 2025 •

edited

Loading

Uh oh!

Constellation Oct 8, 2025

Uh oh!

catamorphism Oct 8, 2025

Uh oh!

Constellation Oct 9, 2025

Uh oh!

Constellation Oct 9, 2025

Uh oh!

webkit-early-warning-system commented Oct 8, 2025 •

edited

Loading

Uh oh!

webkit-commit-queue commented Oct 9, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

[Temporal] Add PlainMonthDay #52010

[Temporal] Add PlainMonthDay #52010

Conversation

catamorphism commented Oct 8, 2025 • edited by webkit-early-warning-system Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

dab2cf7

Uh oh!

webkit-early-warning-system commented Oct 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Oct 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Constellation Oct 8, 2025

Choose a reason for hiding this comment

Uh oh!

catamorphism Oct 8, 2025

Choose a reason for hiding this comment

Uh oh!

Constellation Oct 9, 2025

Choose a reason for hiding this comment

Uh oh!

Constellation Oct 9, 2025

Choose a reason for hiding this comment

Uh oh!

webkit-early-warning-system commented Oct 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-commit-queue commented Oct 9, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

catamorphism commented Oct 8, 2025 •

edited by webkit-early-warning-system

Loading

`dab2cf7`

webkit-early-warning-system commented Oct 8, 2025 •

edited

Loading

webkit-early-warning-system commented Oct 8, 2025 •

edited

Loading

webkit-early-warning-system commented Oct 8, 2025 •

edited

Loading