Skip to content

Conversation

mattwoodrow
Copy link
Contributor

@mattwoodrow mattwoodrow commented Oct 12, 2022

df65178

Prioritize the currently checked out branch when picking the canonical one.
https://bugs.webkit.org/show_bug.cgi?id=246385

Reviewed by Jonathan Bedard.

* Tools/Scripts/libraries/webkitscmpy/setup.py:
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py:
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/local/git.py:
(Git.commit):
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/scm_base.py:
(ScmBase.prioritize_branches):

Canonical link: https://commits.webkit.org/255516@main

aaecf14

Misc iOS, tvOS & watchOS macOS Linux Windows
❌ 🧪 style 🛠 ios 🛠 mac 🛠 wpe 🛠 🧪 win
✅ 🧪 bindings 🛠 ios-sim 🛠 mac-debug 🛠 gtk 🛠 wincairo
🧪 webkitperl 🧪 ios-wk2 🛠 mac-AS-debug 🧪 gtk-wk2
❌ 🧪 webkitpy 🧪 api-ios 🧪 api-mac 🧪 api-gtk
🛠 tv 🧪 mac-wk1
🧪 services 🛠 tv-sim 🧪 mac-wk2
🛠 watch 🧪 mac-AS-debug-wk2 ✅ 🛠 jsc-mips
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim 🧪 mac-wk2-stress 🧪 jsc-mips-tests

@mattwoodrow mattwoodrow self-assigned this Oct 12, 2022
@mattwoodrow mattwoodrow added Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases WebKit Nightly Build labels Oct 12, 2022
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Oct 12, 2022
Copy link
Member

@JonWBedard JonWBedard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious the motivation for this, because I don't think it's correct.

As an example, if I'm on main and run git checkout -b new-branch, HEAD is canonically on main. It's also on new-branch, but the canonical identifier of HEAD will remain 1234@main, this change would make the canonical identifier depend on the branch you're on (in our example, 1234.0@new-branch), which is what we're trying to avoid

@mattwoodrow mattwoodrow removed the merging-blocked Applied to prevent a change from being merged label Oct 13, 2022
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Oct 13, 2022
Copy link
Member

@JonWBedard JonWBedard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will need to bump the version number in Tools/Scripts/libraries/webkitscmpy/setup.py and Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py for our pip package when landing.

@mattwoodrow mattwoodrow removed the merging-blocked Applied to prevent a change from being merged label Oct 14, 2022
@mattwoodrow mattwoodrow added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Oct 14, 2022
@webkit-commit-queue
Copy link
Collaborator

Committed 255516@main (df65178): https://commits.webkit.org/255516@main

Reviewed commits have been landed. Closing PR #5275 and removing active labels.

@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants