-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Prioritize the currently checked out branch when picking the canonical one. #5275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
EWS run on previous version of this PR (hash 978ac06) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm curious the motivation for this, because I don't think it's correct.
As an example, if I'm on main
and run git checkout -b new-branch
, HEAD
is canonically on main
. It's also on new-branch
, but the canonical identifier of HEAD
will remain 1234@main
, this change would make the canonical identifier depend on the branch you're on (in our example, 1234.0@new-branch
), which is what we're trying to avoid
978ac06
to
1c7e7b7
Compare
EWS run on previous version of this PR (hash 1c7e7b7) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will need to bump the version number in Tools/Scripts/libraries/webkitscmpy/setup.py
and Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py
for our pip package when landing.
1c7e7b7
to
aaecf14
Compare
Committed 255516@main (df65178): https://commits.webkit.org/255516@main Reviewed commits have been landed. Closing PR #5275 and removing active labels. |
aaecf14
to
df65178
Compare
EWS run on current version of this PR (hash aaecf14) |
df65178
aaecf14
🛠 ios🛠 mac🛠 wpe🛠 🧪 win🛠 ios-sim🛠 mac-debug🛠 gtk🛠 wincairo🧪 webkitperl🧪 ios-wk2🛠 mac-AS-debug🧪 gtk-wk2🧪 api-ios🧪 api-mac🧪 api-gtk🛠 tv🧪 mac-wk1🧪 services🛠 tv-sim🧪 mac-wk2🛠 watch🧪 mac-AS-debug-wk2🧪 mac-wk2-stress🧪 jsc-mips-tests