-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Make GraphicsLayerTextureMapper code platform agnostic #5383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make GraphicsLayerTextureMapper code platform agnostic #5383
Conversation
EWS run on previous version of this PR (hash 1f59699)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nativeWindowHandle is not only for GraphicsLayerTextureMapper, but also for GraphicsLayerWC. And, I have a plan to remove GraphicsLayerTextureMapper after removing WinCairo WK1 and migrating Microsoft Playwright to GraphicsLayerWC.
I think it should be #if USE(GRAPHICS_LAYER_TEXTURE_MAPPER) || USE(GRAPHICS_LAYER_WC)
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok updated @fujii
1f59699
to
dfe978d
Compare
EWS run on current version of this PR (hash dfe978d)
|
https://bugs.webkit.org/show_bug.cgi?id=246497 Reviewed by Fujii Hironori. Replaces `PLATFORM(WIN)` code with checks for `USE(GRAPHICS_LAYER_TEXTURE_MAPPER)` or `USE(GRAPHICS_LAYER_WC)` where applicable. Modify types to platform specific ones. The patch largely modifies code from 225218@main to be port agnostic. * Source/WebKit/Shared/WebPageCreationParameters.cpp: * Source/WebKit/Shared/WebPageCreationParameters.h: * Source/WebKit/UIProcess/WebPageProxy.cpp: * Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/LayerTreeHostTextureMapper.cpp: * Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/LayerTreeHostTextureMapper.h: * Source/WebKit/WebProcess/WebPage/WebPage.cpp: * Source/WebKit/WebProcess/WebPage/WebPage.h: Canonical link: https://commits.webkit.org/255582@main
dfe978d
to
0b29e27
Compare
Committed 255582@main (0b29e27): https://commits.webkit.org/255582@main Reviewed commits have been landed. Closing PR #5383 and removing active labels. |
0b29e27
dfe978d
🧪 api-mac