Skip to content

Conversation

donny-dont
Copy link
Contributor

@donny-dont donny-dont commented Oct 14, 2022

0b29e27

Make GraphicsLayerTextureMapper code platform agnostic
https://bugs.webkit.org/show_bug.cgi?id=246497

Reviewed by Fujii Hironori.

Replaces `PLATFORM(WIN)` code with checks for
`USE(GRAPHICS_LAYER_TEXTURE_MAPPER)` or `USE(GRAPHICS_LAYER_WC)` where
applicable. Modify types to platform specific ones. The patch largely
modifies code from 225218@main to be port agnostic.

* Source/WebKit/Shared/WebPageCreationParameters.cpp:
* Source/WebKit/Shared/WebPageCreationParameters.h:
* Source/WebKit/UIProcess/WebPageProxy.cpp:
* Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/LayerTreeHostTextureMapper.cpp:
* Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/LayerTreeHostTextureMapper.h:
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
* Source/WebKit/WebProcess/WebPage/WebPage.h:

Canonical link: https://commits.webkit.org/255582@main

dfe978d

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe
✅ 🛠 ios-sim ✅ 🛠 mac-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🛠 mac-AS-debug ✅ 🧪 gtk-wk2
✅ 🧪 api-ios 🧪 api-mac ❌ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-wk1
✅ 🛠 tv-sim ✅ 🧪 mac-wk2
✅ 🛠 🧪 merge ✅ 🛠 watch ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 watch-sim ✅ 🧪 mac-wk2-stress

@donny-dont donny-dont self-assigned this Oct 14, 2022
@donny-dont donny-dont added Platform Portability improvements and other general platform improvements not driven directly by site bugs. WebKit Nightly Build labels Oct 14, 2022
@donny-dont donny-dont requested a review from fujii October 14, 2022 20:26
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nativeWindowHandle is not only for GraphicsLayerTextureMapper, but also for GraphicsLayerWC. And, I have a plan to remove GraphicsLayerTextureMapper after removing WinCairo WK1 and migrating Microsoft Playwright to GraphicsLayerWC.
I think it should be #if USE(GRAPHICS_LAYER_TEXTURE_MAPPER) || USE(GRAPHICS_LAYER_WC).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok updated @fujii

@donny-dont donny-dont force-pushed the eng/Make-GraphicsLayerTextureMapper-code-platform-agnostic branch from 1f59699 to dfe978d Compare October 14, 2022 21:31
@donny-dont donny-dont added the merge-queue Applied to send a pull request to merge-queue label Oct 15, 2022
https://bugs.webkit.org/show_bug.cgi?id=246497

Reviewed by Fujii Hironori.

Replaces `PLATFORM(WIN)` code with checks for
`USE(GRAPHICS_LAYER_TEXTURE_MAPPER)` or `USE(GRAPHICS_LAYER_WC)` where
applicable. Modify types to platform specific ones. The patch largely
modifies code from 225218@main to be port agnostic.

* Source/WebKit/Shared/WebPageCreationParameters.cpp:
* Source/WebKit/Shared/WebPageCreationParameters.h:
* Source/WebKit/UIProcess/WebPageProxy.cpp:
* Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/LayerTreeHostTextureMapper.cpp:
* Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/LayerTreeHostTextureMapper.h:
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
* Source/WebKit/WebProcess/WebPage/WebPage.h:

Canonical link: https://commits.webkit.org/255582@main
@webkit-early-warning-system webkit-early-warning-system force-pushed the eng/Make-GraphicsLayerTextureMapper-code-platform-agnostic branch from dfe978d to 0b29e27 Compare October 15, 2022 15:58
@webkit-commit-queue
Copy link
Collaborator

Committed 255582@main (0b29e27): https://commits.webkit.org/255582@main

Reviewed commits have been landed. Closing PR #5383 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system merged commit 0b29e27 into WebKit:main Oct 15, 2022
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Oct 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Platform Portability improvements and other general platform improvements not driven directly by site bugs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants