Web Manifest: support id member #5800

marcoscaceres · 2022-10-26T05:51:01Z

`7e44837`

Web Manifest: support id member
https://bugs.webkit.org/show_bug.cgi?id=230596
rdar://83656112

Implementation of Web Manifest's id member:
https://www.w3.org/TR/appmanifest/#id-member

The manifest's id member is a string that represents the identity for the application. The identity takes the form of a URL, which is same origin as the start URL.

Reviewed by Devin Rousso.

* Source/WebCore/Modules/applicationmanifest/ApplicationManifest.h:
* Source/WebCore/Modules/applicationmanifest/ApplicationManifestParser.cpp:
(WebCore::ApplicationManifestParser::parseManifest):
(WebCore::ApplicationManifestParser::parseId):
* Source/WebCore/Modules/applicationmanifest/ApplicationManifestParser.h:
* Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in:
* Source/WebKit/UIProcess/API/Cocoa/_WKApplicationManifest.h:
* Source/WebKit/UIProcess/API/Cocoa/_WKApplicationManifest.mm:
(-[_WKApplicationManifest initWithCoder:]):
(-[_WKApplicationManifest encodeWithCoder:]):
(-[_WKApplicationManifest manifestId]):
* Tools/TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:
(ApplicationManifestParserTest::testId):
(assertManifestHasDefaultValues):
(TEST_F):

Canonical link: https://commits.webkit.org/256182@main

165b16f

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🛠 mac-AS-debug	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	~~🧪 api-mac~~	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-wk1
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2
✅ 🛠 🧪 merge	✅ 🛠 watch	~~🧪 mac-AS-debug-wk2~~
	✅ 🛠 watch-sim	✅ 🧪 mac-wk2-stress

webkit-early-warning-system · 2022-10-26T05:53:42Z

EWS run on previous version of this PR (hash 7febaa8)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	❌ 🛠 ios	⏳ 🛠 mac	✅ 🛠 wpe	✅ 🛠 🧪 win
✅ 🧪 bindings	❌ 🛠 ios-sim	❌ 🛠 mac-debug	✅ 🛠 gtk	⏳ 🛠 wincairo
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	❌ 🛠 mac-AS-debug	✅ 🧪 gtk-wk2
	❌ 🧪 api-ios	⏳ 🧪 api-mac	✅ 🧪 api-gtk
	❌ 🛠 tv	⏳ 🧪 mac-wk1
	❌ 🛠 tv-sim	⏳ 🧪 mac-wk2
	❌ 🛠 watch	❌ 🧪 mac-AS-debug-wk2
	❌ 🛠 watch-sim	⏳ 🧪 mac-wk2-stress

webkit-early-warning-system · 2022-10-26T09:32:54Z

EWS run on previous version of this PR (hash eca97bf)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	❌ 🛠 ios	❌ 🛠 mac	✅ 🛠 wpe	✅ 🛠 🧪 win
✅ 🧪 bindings	❌ 🛠 ios-sim	❌ 🛠 mac-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	❌ 🛠 mac-AS-debug	✅ 🧪 gtk-wk2
	❌ 🧪 api-ios	❌ 🧪 api-mac	✅ 🧪 api-gtk
	❌ 🛠 tv	❌ 🧪 mac-wk1
	❌ 🛠 tv-sim	❌ 🧪 mac-wk2
	❌ 🛠 watch	❌ 🧪 mac-AS-debug-wk2
	❌ 🛠 watch-sim	❌ 🧪 mac-wk2-stress

Source/WebCore/Modules/applicationmanifest/ApplicationManifestParser.cpp

Source/WebKit/UIProcess/API/Cocoa/_WKApplicationManifest.h

Source/WebCore/Modules/applicationmanifest/ApplicationManifest.h

webkit-early-warning-system · 2022-10-26T23:15:34Z

EWS run on previous version of this PR (hash bf12ead)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	❌ 🛠 ios	❌ 🛠 mac	✅ 🛠 wpe	❌ 🛠 🧪 win
✅ 🧪 bindings	❌ 🛠 ios-sim	❌ 🛠 mac-debug	✅ 🛠 gtk	❌ 🛠 wincairo
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	❌ 🛠 mac-AS-debug	✅ 🧪 gtk-wk2
	❌ 🧪 api-ios	❌ 🧪 api-mac	✅ 🧪 api-gtk
	❌ 🛠 tv	❌ 🧪 mac-wk1
	❌ 🛠 tv-sim	❌ 🧪 mac-wk2
	❌ 🛠 watch	❌ 🧪 mac-AS-debug-wk2
	❌ 🛠 watch-sim	❌ 🧪 mac-wk2-stress

webkit-early-warning-system · 2022-10-27T23:35:23Z

Starting EWS tests for fe095bf. Live statuses available at the PR page, #5800

webkit-early-warning-system · 2022-10-27T23:35:24Z

EWS run on previous version of this PR (hash fe095bf)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	❌ 🛠 ios	❌ 🛠 mac	✅ 🛠 wpe	~~🛠 🧪 win~~
✅ 🧪 bindings	❌ 🛠 ios-sim	❌ 🛠 mac-debug	✅ 🛠 gtk	⏳ 🛠 wincairo
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	❌ 🛠 mac-AS-debug	✅ 🧪 gtk-wk2
	❌ 🧪 api-ios	❌ 🧪 api-mac	✅ 🧪 api-gtk
	❌ 🛠 tv	❌ 🧪 mac-wk1
	❌ 🛠 tv-sim	❌ 🧪 mac-wk2
	❌ 🛠 watch	❌ 🧪 mac-AS-debug-wk2
	❌ 🛠 watch-sim	❌ 🧪 mac-wk2-stress

webkit-early-warning-system · 2022-10-28T04:28:20Z

EWS run on previous version of this PR (hash b5e068e)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	❌ 🛠 ios	❌ 🛠 mac	✅ 🛠 wpe	✅ 🛠 🧪 win
✅ 🧪 bindings	❌ 🛠 ios-sim	❌ 🛠 mac-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	❌ 🛠 mac-AS-debug	✅ 🧪 gtk-wk2
	❌ 🧪 api-ios	❌ 🧪 api-mac	✅ 🧪 api-gtk
	❌ 🛠 tv	❌ 🧪 mac-wk1
	❌ 🛠 tv-sim	❌ 🧪 mac-wk2
	❌ 🛠 watch	❌ 🧪 mac-AS-debug-wk2
	❌ 🛠 watch-sim	❌ 🧪 mac-wk2-stress

webkit-early-warning-system · 2022-10-30T23:16:40Z

EWS run on previous version of this PR (hash ebd4c55)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🛠 mac-AS-debug	✅ 🧪 gtk-wk2
	❌ 🧪 api-ios	~~🧪 api-mac~~	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-wk1
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2
	✅ 🛠 watch	~~🧪 mac-AS-debug-wk2~~
	✅ 🛠 watch-sim	✅ 🧪 mac-wk2-stress

webkit-early-warning-system · 2022-10-31T09:02:00Z

EWS run on previous version of this PR (hash 32a28a0)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🛠 mac-AS-debug	✅ 🧪 gtk-wk2
	❌ 🧪 api-ios	✅ 🧪 api-mac	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-wk1
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2
	✅ 🛠 watch	~~🧪 mac-AS-debug-wk2~~
	✅ 🛠 watch-sim	✅ 🧪 mac-wk2-stress

Source/WebKit/UIProcess/API/Cocoa/_WKApplicationManifest.h

webkit-early-warning-system · 2022-10-31T18:37:26Z

EWS run on previous version of this PR (hash c2a0a73)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	~~🛠 🧪 win~~
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-debug	✅ 🛠 gtk	⏳ 🛠 wincairo
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	✅ 🛠 mac-AS-debug	~~🧪 gtk-wk2~~
	~~🧪 api-ios~~	~~🧪 api-mac~~	~~🧪 api-gtk~~
⏳ 🛠 🧪 jsc	✅ 🛠 tv	~~🧪 mac-wk1~~
	✅ 🛠 tv-sim	~~🧪 mac-wk2~~
	✅ 🛠 watch	~~🧪 mac-AS-debug-wk2~~
	✅ 🛠 watch-sim	✅ 🧪 mac-wk2-stress

webkit-early-warning-system · 2022-10-31T20:08:30Z

EWS run on current version of this PR (hash 165b16f)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🛠 mac-AS-debug	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	~~🧪 api-mac~~	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-wk1
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2
✅ 🛠 🧪 merge	✅ 🛠 watch	~~🧪 mac-AS-debug-wk2~~
	✅ 🛠 watch-sim	✅ 🧪 mac-wk2-stress

https://bugs.webkit.org/show_bug.cgi?id=230596 rdar://83656112 Implementation of Web Manifest's id member: https://www.w3.org/TR/appmanifest/#id-member The manifest's id member is a string that represents the identity for the application. The identity takes the form of a URL, which is same origin as the start URL. Reviewed by Devin Rousso. * Source/WebCore/Modules/applicationmanifest/ApplicationManifest.h: * Source/WebCore/Modules/applicationmanifest/ApplicationManifestParser.cpp: (WebCore::ApplicationManifestParser::parseManifest): (WebCore::ApplicationManifestParser::parseId): * Source/WebCore/Modules/applicationmanifest/ApplicationManifestParser.h: * Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in: * Source/WebKit/UIProcess/API/Cocoa/_WKApplicationManifest.h: * Source/WebKit/UIProcess/API/Cocoa/_WKApplicationManifest.mm: (-[_WKApplicationManifest initWithCoder:]): (-[_WKApplicationManifest encodeWithCoder:]): (-[_WKApplicationManifest manifestId]): * Tools/TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp: (ApplicationManifestParserTest::testId): (assertManifestHasDefaultValues): (TEST_F): Canonical link: https://commits.webkit.org/256182@main

webkit-commit-queue · 2022-11-01T02:33:56Z

Committed 256182@main (7e44837): https://commits.webkit.org/256182@main

Reviewed commits have been landed. Closing PR #5800 and removing active labels.

marcoscaceres self-assigned this Oct 26, 2022

marcoscaceres added New Bugs Unclassified bugs are placed in this component until the correct component can be determined. Other labels Oct 26, 2022

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Oct 26, 2022

marcoscaceres removed the merging-blocked Applied to prevent a change from being merged label Oct 26, 2022

marcoscaceres requested review from dcrousso and beidson October 26, 2022 09:38

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Oct 26, 2022

dcrousso reviewed Oct 26, 2022

View reviewed changes

marcoscaceres removed the merging-blocked Applied to prevent a change from being merged label Oct 26, 2022

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Oct 26, 2022

marcoscaceres removed the merging-blocked Applied to prevent a change from being merged label Oct 27, 2022

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Oct 27, 2022

marcoscaceres removed the merging-blocked Applied to prevent a change from being merged label Oct 28, 2022

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Oct 28, 2022

marcoscaceres removed the merging-blocked Applied to prevent a change from being merged label Oct 30, 2022

marcoscaceres marked this pull request as ready for review October 30, 2022 23:18

marcoscaceres requested a review from cdumez as a code owner October 30, 2022 23:18

marcoscaceres requested a review from dcrousso October 31, 2022 02:52

dcrousso approved these changes Oct 31, 2022

View reviewed changes

Source/WebKit/UIProcess/API/Cocoa/_WKApplicationManifest.h Outdated Show resolved Hide resolved

rreno added the merge-queue Applied to send a pull request to merge-queue label Nov 1, 2022

webkit-early-warning-system merged commit 7e44837 into WebKit:main Nov 1, 2022

webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Nov 1, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Web Manifest: support id member #5800

Web Manifest: support id member #5800

Uh oh!

marcoscaceres commented Oct 26, 2022 •

edited by webkit-early-warning-system

Loading

Uh oh!

webkit-early-warning-system commented Oct 26, 2022 •

edited

Loading

Uh oh!

webkit-early-warning-system commented Oct 26, 2022 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

webkit-early-warning-system commented Oct 26, 2022 •

edited

Loading

Uh oh!

webkit-early-warning-system commented Oct 27, 2022

Uh oh!

webkit-early-warning-system commented Oct 27, 2022 •

edited

Loading

Uh oh!

webkit-early-warning-system commented Oct 28, 2022 •

edited

Loading

Uh oh!

webkit-early-warning-system commented Oct 30, 2022 •

edited

Loading

Uh oh!

webkit-early-warning-system commented Oct 31, 2022 •

edited

Loading

Uh oh!

Uh oh!

webkit-early-warning-system commented Oct 31, 2022 •

edited

Loading

Uh oh!

webkit-early-warning-system commented Oct 31, 2022 •

edited

Loading

Uh oh!

webkit-commit-queue commented Nov 1, 2022

Uh oh!

Uh oh!

Web Manifest: support id member #5800

Web Manifest: support id member #5800

Uh oh!

Conversation

marcoscaceres commented Oct 26, 2022 • edited by webkit-early-warning-system Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

7e44837

Uh oh!

webkit-early-warning-system commented Oct 26, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Oct 26, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

webkit-early-warning-system commented Oct 26, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Oct 27, 2022

Uh oh!

webkit-early-warning-system commented Oct 27, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Oct 28, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Oct 30, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Oct 31, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

webkit-early-warning-system commented Oct 31, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Oct 31, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-commit-queue commented Nov 1, 2022

Uh oh!

Uh oh!

marcoscaceres commented Oct 26, 2022 •

edited by webkit-early-warning-system

Loading

`7e44837`

webkit-early-warning-system commented Oct 26, 2022 •

edited

Loading

webkit-early-warning-system commented Oct 26, 2022 •

edited

Loading

webkit-early-warning-system commented Oct 26, 2022 •

edited

Loading

webkit-early-warning-system commented Oct 27, 2022 •

edited

Loading

webkit-early-warning-system commented Oct 28, 2022 •

edited

Loading

webkit-early-warning-system commented Oct 30, 2022 •

edited

Loading

webkit-early-warning-system commented Oct 31, 2022 •

edited

Loading

webkit-early-warning-system commented Oct 31, 2022 •

edited

Loading

webkit-early-warning-system commented Oct 31, 2022 •

edited

Loading