[Filters] FilterEffect::calculatePrimitiveSubregion() and calculateImageRect() should take a span of the input image rects #6706
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shallawa
added
the
Layout and Rendering
|
EWS run on previous version of this PR (hash 1ae380a) |
|
EWS run on current version of this PR (hash 1ae380a) |
shallawa
force-pushed
the
eng/Filters-FilterEffectcalculatePrimitiveSubregion-and-calculateImageRect-should-take-a-vector-of-the-input-rects
branch
from
1ae380a to
c30e2a1
Compare
shallawa
changed the title
|
EWS run on previous version of this PR (hash c30e2a1)
|
heycam
approved these changes
Nov 23, 2022
Comment on lines
55
to
61
There was a problem hiding this comment.
You could write this as:
return inputs.map([] (auto& input) { return input->primitiveSubregion(); });if you think it's clearer. (I'm always on the fence, given C++'s verbose lambda syntax.)
Comment on lines
93
to
99
shallawa
force-pushed
the
eng/Filters-FilterEffectcalculatePrimitiveSubregion-and-calculateImageRect-should-take-a-vector-of-the-input-rects
branch
from
c30e2a1 to
e5d5317
Compare
|
EWS run on current version of this PR (hash e5d5317)
|
webkit-commit-queue
force-pushed
the
eng/Filters-FilterEffectcalculatePrimitiveSubregion-and-calculateImageRect-should-take-a-vector-of-the-input-rects
branch
from
e5d5317 to
b362815
Compare
…ageRect() should take a span of the input image rects https://bugs.webkit.org/show_bug.cgi?id=248181 rdar://102586592 Reviewed by Cameron McCormack. Instead of passing a FilterImageVector to these functions we should pass a Vector<FloatRect> since they care about the FilterImage::imageRect() only. This work is towards supporting CoreGraphics filters since no FilterImage will be used while applying the FilterEffects. * Source/WebCore/platform/graphics/filters/FEComposite.cpp: (WebCore::FEComposite::calculateImageRect const): * Source/WebCore/platform/graphics/filters/FEComposite.h: * Source/WebCore/platform/graphics/filters/FEConvolveMatrix.cpp: (WebCore::FEConvolveMatrix::calculateImageRect const): * Source/WebCore/platform/graphics/filters/FEConvolveMatrix.h: * Source/WebCore/platform/graphics/filters/FEDisplacementMap.cpp: (WebCore::FEDisplacementMap::calculateImageRect const): * Source/WebCore/platform/graphics/filters/FEDisplacementMap.h: * Source/WebCore/platform/graphics/filters/FEDropShadow.cpp: (WebCore::FEDropShadow::calculateImageRect const): * Source/WebCore/platform/graphics/filters/FEDropShadow.h: * Source/WebCore/platform/graphics/filters/FEFlood.cpp: (WebCore::FEFlood::calculateImageRect const): * Source/WebCore/platform/graphics/filters/FEFlood.h: * Source/WebCore/platform/graphics/filters/FEGaussianBlur.cpp: (WebCore::FEGaussianBlur::calculateImageRect const): * Source/WebCore/platform/graphics/filters/FEGaussianBlur.h: * Source/WebCore/platform/graphics/filters/FEImage.cpp: (WebCore::FEImage::calculateImageRect const): * Source/WebCore/platform/graphics/filters/FEImage.h: * Source/WebCore/platform/graphics/filters/FELighting.cpp: (WebCore::FELighting::calculateImageRect const): * Source/WebCore/platform/graphics/filters/FELighting.h: * Source/WebCore/platform/graphics/filters/FEMorphology.cpp: (WebCore::FEMorphology::calculateImageRect const): * Source/WebCore/platform/graphics/filters/FEMorphology.h: * Source/WebCore/platform/graphics/filters/FEOffset.cpp: (WebCore::FEOffset::calculateImageRect const): * Source/WebCore/platform/graphics/filters/FEOffset.h: * Source/WebCore/platform/graphics/filters/FETile.cpp: (WebCore::FETile::calculateImageRect const): * Source/WebCore/platform/graphics/filters/FETile.h: * Source/WebCore/platform/graphics/filters/FETurbulence.cpp: (WebCore::FETurbulence::calculateImageRect const): * Source/WebCore/platform/graphics/filters/FETurbulence.h: * Source/WebCore/platform/graphics/filters/FilterEffect.cpp: (WebCore::inputPrimitiveSubregions): (WebCore::FilterEffect::calculatePrimitiveSubregion const): (WebCore::inputImageRects): (WebCore::FilterEffect::calculateImageRect const): (WebCore::FilterEffect::apply): * Source/WebCore/platform/graphics/filters/FilterEffect.h: Canonical link: https://commits.webkit.org/256983@main
webkit-commit-queue
force-pushed
the
eng/Filters-FilterEffectcalculatePrimitiveSubregion-and-calculateImageRect-should-take-a-vector-of-the-input-rects
branch
from
b362815 to
d4236a4
Compare
|
Committed 256983@main (d4236a4): https://commits.webkit.org/256983@main Reviewed commits have been landed. Closing PR #6706 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
shallawa
deleted the
eng/Filters-FilterEffectcalculatePrimitiveSubregion-and-calculateImageRect-should-take-a-vector-of-the-input-rects
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
d4236a4
e5d5317
🧪 ios-wk2🧪 api-ios🧪 api-mac🧪 mac-wk1🧪 mac-wk2🧪 mac-AS-debug-wk2