-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove failing assert in JSC Options.cpp. #7340
Remove failing assert in JSC Options.cpp. #7340
Conversation
@@ -747,7 +747,7 @@ void Options::notifyOptionsChanged() | |||
|
|||
// Do range checks where needed and make corrections to the options: | |||
ASSERT(Options::thresholdForOptimizeAfterLongWarmUp() >= Options::thresholdForOptimizeAfterWarmUp()); | |||
ASSERT(Options::thresholdForOptimizeAfterWarmUp() >= Options::thresholdForOptimizeSoon()); | |||
// ASSERT(Options::thresholdForOptimizeAfterWarmUp() >= Options::thresholdForOptimizeSoon()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why comment it out instead of removing it? Also, in the commit msg, it would be good to explain why this should be removed.
EWS run on previous version of this PR (hash abfb2f3) |
abfb2f3
to
5809f5c
Compare
EWS run on current version of this PR (hash 5809f5c) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r=me
https://bugs.webkit.org/show_bug.cgi?id=248971 Reviewed by Yusuke Suzuki. We have tests that test this configuration, like stress/ftl-osr-entry-order-reverse.js. We should temporarily remove this assertion so that debug tests pass. * Source/JavaScriptCore/runtime/Options.cpp: (JSC::Options::notifyOptionsChanged): Canonical link: https://commits.webkit.org/257586@main
5809f5c
to
0893db1
Compare
Committed 257586@main (0893db1): https://commits.webkit.org/257586@main Reviewed commits have been landed. Closing PR #7340 and removing active labels. |
0893db1
5809f5c
🛠 mac🛠 🧪 win🛠 mac-AS-debug🛠 wincairo🧪 ios-wk2🧪 api-mac🧪 api-ios🧪 mac-wk1🛠 🧪 jsc🛠 tv🧪 mac-wk2🧪 mac-AS-debug-wk2🛠 watch🧪 mac-wk2-stress🛠 watch-sim