Remove failing assert in JSC Options.cpp. #7340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinmichaud
added
the
JavaScriptCore
MenloDorian
reviewed
Dec 8, 2022
| @@ -747,7 +747,7 @@ void Options::notifyOptionsChanged() | |||
|
|
|||
| // Do range checks where needed and make corrections to the options: | |||
| ASSERT(Options::thresholdForOptimizeAfterLongWarmUp() >= Options::thresholdForOptimizeAfterWarmUp()); | |||
| ASSERT(Options::thresholdForOptimizeAfterWarmUp() >= Options::thresholdForOptimizeSoon()); | |||
| // ASSERT(Options::thresholdForOptimizeAfterWarmUp() >= Options::thresholdForOptimizeSoon()); | |||
There was a problem hiding this comment.
Why comment it out instead of removing it? Also, in the commit msg, it would be good to explain why this should be removed.
|
EWS run on previous version of this PR (hash abfb2f3) |
justinmichaud
force-pushed
the
eng/Remove-failing-assert-in-JSC-Options-cpp
branch
from
abfb2f3
to
5809f5c
Compare
|
EWS run on current version of this PR (hash 5809f5c) |
Constellation
added
the
unsafe-merge-queue
https://bugs.webkit.org/show_bug.cgi?id=248971 Reviewed by Yusuke Suzuki. We have tests that test this configuration, like stress/ftl-osr-entry-order-reverse.js. We should temporarily remove this assertion so that debug tests pass. * Source/JavaScriptCore/runtime/Options.cpp: (JSC::Options::notifyOptionsChanged): Canonical link: https://commits.webkit.org/257586@main
webkit-early-warning-system
force-pushed
the
eng/Remove-failing-assert-in-JSC-Options-cpp
branch
from
5809f5c
to
0893db1
Compare
|
Committed 257586@main (0893db1): https://commits.webkit.org/257586@main Reviewed commits have been landed. Closing PR #7340 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
0893db1
5809f5c
🛠 mac🛠 🧪 win🛠 mac-AS-debug🛠 wincairo🧪 ios-wk2🧪 api-mac🧪 api-ios🧪 mac-wk1🛠 🧪 jsc🛠 tv🧪 mac-wk2🧪 mac-AS-debug-wk2🛠 watch🧪 mac-wk2-stress🛠 watch-sim