Do not serialize shorthands when any longhands are missing #7770
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
EWS run on current version of this PR (hash 9a4c19f)
|
Loirooriol
reviewed
Dec 16, 2022
| if (!start.value() || !end.value()) | ||
| return { }; | ||
| auto start = propertyAt(findPropertyIndex(shorthand.properties()[0])); | ||
| auto end = propertyAt(findPropertyIndex(shorthand.properties()[1])); |
There was a problem hiding this comment.
end could just use getPropertyCSSValue.
start has an isImplicit check which doesn't seem to make much sense, maybe it could use getPropertyCSSValue too.
There was a problem hiding this comment.
The isImplicit check is going away soon.
I think I‘ll take a pass through tightening up the code again once I finish removing implicit entirely.
nt1m
approved these changes
Dec 16, 2022
Mostly done, will do more in follow-up. |
darinadler
force-pushed
the
eng/Dont-serialize-shorthands-when-any-of-the-longhands-are-missing
branch
from
9a4c19f to
d750def
Compare
Loirooriol
approved these changes
Dec 17, 2022
webkit-commit-queue
added
merging-blocked
darinadler
added
unsafe-merge-queue
https://bugs.webkit.org/show_bug.cgi?id=249440 rdar://problem/103423965 Reviewed by Tim Nguyen. * LayoutTests/imported/w3c/web-platform-tests/css/cssom/cssom-getPropertyValue-common-checks-expected.txt: Expect one more test to pass. * Source/WebCore/css/StyleProperties.cpp: (WebCore::StyleProperties::commonShorthandChecks const): Return empty string when a longhand is missing. Also redid the logic for values that are set by the shorthand, since it no longer needs to compute a count. (WebCore::StyleProperties::getPropertyValue const): Removed unneeded checks since commonShorthandChecks handles missing longhands, and parsing makes sure things have correct types. (WebCore::StyleProperties::offsetValue const): Ditto. (WebCore::StyleProperties::fontVariantValue const): Ditto. (WebCore::StyleProperties::get2Values const): Ditto. (WebCore::StyleProperties::get4Values const): Ditto. (WebCore::StyleProperties::getLayeredShorthandValue const): Ditto. (WebCore::StyleProperties::getGridTemplateValue const): Ditto. (WebCore::StyleProperties::getGridValue const): Ditto. (WebCore::StyleProperties::getGridRowColumnShorthandValue const): Ditto. (WebCore::StyleProperties::getGridAreaShorthandValue const): Ditto. (WebCore::StyleProperties::getShorthandValue const): Ditto. (WebCore::StyleProperties::getCommonValue const): Ditto. (WebCore::StyleProperties::borderImagePropertyValue const): Ditto. (WebCore::StyleProperties::borderRadiusShorthandValue const): Ditto. (WebCore::StyleProperties::borderPropertyValue const): Ditto. * Source/WebCore/css/StyleProperties.h: Removed the unneeded argument from fontVariantValue. Canonical link: https://commits.webkit.org/258038@main
webkit-early-warning-system
force-pushed
the
eng/Dont-serialize-shorthands-when-any-of-the-longhands-are-missing
branch
from
d750def to
a7f14bf
Compare
|
Committed 258038@main (a7f14bf): https://commits.webkit.org/258038@main Reviewed commits have been landed. Closing PR #7770 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
darinadler
deleted the
eng/Dont-serialize-shorthands-when-any-of-the-longhands-are-missing
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a7f14bf
d750def