Skip to content

media/modern-media-controls tests are timing out #802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 0 commits into from
Closed

media/modern-media-controls tests are timing out #802

wants to merge 0 commits into from

Conversation

dcrousso
Copy link
Member

@dcrousso dcrousso commented May 19, 2022 •
edited by webkit-early-warning-system
Loading

79f119a

media/modern-media-controls tests are timing out
https://bugs.webkit.org/show_bug.cgi?id=231187
<rdar://problem/83846919 >

Unreviewed.

The tests in `media/modern-media-controls/overflow-support` and `media/modern-media-controls/tracks-support`
require `"touch*"` (really `"pointer*"`) events on iOS, so skip for OpenSource and unskip internally.

* LayoutTests/platform/ios/TestExpectations:

Canonical link: https://commits.webkit.org/250762@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294505 268f45cc-cd09-0410-ab3c-d52691b4dbfc

@dcrousso dcrousso self-assigned this May 19, 2022
@dcrousso dcrousso added Media Bugs related to the HTML 5 Media elements. WebKit Nightly Build unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing labels May 19, 2022
@webkit-early-warning-system
Copy link
Collaborator

No reviewer information in commit message, blocking PR #802

@webkit-early-warning-system webkit-early-warning-system added merging-blocked Applied to prevent a change from being merged and removed unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing labels May 19, 2022
@dcrousso dcrousso removed merging-blocked Applied to prevent a change from being merged Media Bugs related to the HTML 5 Media elements. WebKit Nightly Build labels May 19, 2022
@dcrousso dcrousso added Media Bugs related to the HTML 5 Media elements. WebKit Nightly Build unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing labels May 19, 2022
@webkit-early-warning-system
Copy link
Collaborator

Committed r294505 (250762@main): https://commits.webkit.org/250762@main

Reviewed commits have been landed. Closing PR #802 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label May 19, 2022
@dcrousso dcrousso deleted the eng/231187 branch May 19, 2022 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dcrousso dcrousso

Labels
Media Bugs related to the HTML 5 Media elements.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dcrousso @webkit-early-warning-system