Skip to content

Add logs to AutoplayOnVisibilityChange API test timeouts #8442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 10, 2023
Merged

Add logs to AutoplayOnVisibilityChange API test timeouts #8442

merged 1 commit into from
Jan 10, 2023

Conversation

youennf
Copy link
Contributor

@youennf youennf commented Jan 10, 2023 •
edited by webkit-early-warning-system
Loading

1136658

Add logs to AutoplayOnVisibilityChange API test timeouts
https://bugs.webkit.org/show_bug.cgi?id=250368
rdar://problem/104066597

Reviewed by Jean-Yves Avenard.

AutoplayOnVisibilityChange is timing out for unobvious reasons on some bots.
Add logging to identify where it actually times out.

* Tools/TestWebKitAPI/Tests/WebKit/GetUserMedia.mm:

Canonical link: https://commits.webkit.org/258718@main

f2c713f

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 🧪 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac   🧪 gtk-wk2
  🧪 api-ios ✅ 🧪 mac-wk1   🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-wk2
✅ 🛠 tv-sim ❌ 🧪 mac-AS-debug-wk2
✅ 🛠 watch ✅ 🧪 mac-wk2-stress
✅ 🛠 🧪 merge ✅ 🛠 watch-sim

@youennf youennf self-assigned this Jan 10, 2023
@youennf youennf added the WebRTC For bugs in WebRTC label Jan 10, 2023
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jan 10, 2023 •
edited
Loading

EWS run on current version of this PR (hash f2c713f)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 🧪 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac   🧪 gtk-wk2
  🧪 api-ios ✅ 🧪 mac-wk1   🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-wk2
✅ 🛠 tv-sim ❌ 🧪 mac-AS-debug-wk2
✅ 🛠 watch ✅ 🧪 mac-wk2-stress
✅ 🛠 🧪 merge ✅ 🛠 watch-sim

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jan 10, 2023
@youennf youennf added merge-queue Applied to send a pull request to merge-queue and removed merging-blocked Applied to prevent a change from being merged labels Jan 10, 2023
@youennf
Add logs to AutoplayOnVisibilityChange API test timeouts
1136658 
https://bugs.webkit.org/show_bug.cgi?id=250368
rdar://problem/104066597

Reviewed by Jean-Yves Avenard.

AutoplayOnVisibilityChange is timing out for unobvious reasons on some bots.
Add logging to identify where it actually times out.

* Tools/TestWebKitAPI/Tests/WebKit/GetUserMedia.mm:

Canonical link: https://commits.webkit.org/258718@main
@webkit-early-warning-system webkit-early-warning-system force-pushed the eng/Add-logs-to-AutoplayOnVisibilityChange-API-test-timeouts branch from f2c713f to 1136658 Compare January 10, 2023 13:17
@webkit-commit-queue
Copy link
Collaborator

Committed 258718@main (1136658): https://commits.webkit.org/258718@main

Reviewed commits have been landed. Closing PR #8442 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system merged commit 1136658 into WebKit:main Jan 10, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyavenard jyavenard jyavenard approved these changes

Assignees

@youennf youennf

Labels
WebRTC For bugs in WebRTC
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@youennf @webkit-early-warning-system @webkit-commit-queue @jyavenard @webkit-ews-buildbot