Skip to content

[ATSPI] Make Atspi::ScrollType an enum class #9024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 31, 2023
Merged

[ATSPI] Make Atspi::ScrollType an enum class #9024

merged 1 commit into from
Jan 31, 2023

Conversation

obyknovenius
Copy link
Contributor

@obyknovenius obyknovenius commented Jan 24, 2023 •
edited by webkit-early-warning-system
Loading

713642c

[ATSPI] Make `Atspi::ScrollType` an enum class
https://bugs.webkit.org/show_bug.cgi?id=251076

Reviewed by Adrian Perez de Castro and Carlos Garcia Campos.

It should improve code readability.

* Source/WebCore/accessibility/atspi/AccessibilityAtspiEnums.h:
* Source/WebCore/accessibility/atspi/AccessibilityObjectAtspi.h:
* Source/WebCore/accessibility/atspi/AccessibilityObjectComponentAtspi.cpp:
(WebCore::AccessibilityObjectAtspi::scrollToMakeVisible const):
* Source/WebCore/accessibility/atspi/AccessibilityObjectTextAtspi.cpp:
(WebCore::AccessibilityObjectAtspi::scrollToMakeVisible const):

Canonical link: https://commits.webkit.org/259615@main

e72d1d1

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ❌ 🛠 🧪 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 watch ✅ 🧪 mac-wk2-stress
✅ 🛠 watch-sim
✅ 🛠 🧪 unsafe-merge

@obyknovenius obyknovenius requested a review from a team as a code owner January 24, 2023 08:59
@obyknovenius obyknovenius self-assigned this Jan 24, 2023
@obyknovenius obyknovenius added the Accessibility For bugs related to accessibility. label Jan 24, 2023
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jan 24, 2023 •
edited
Loading

EWS run on current version of this PR (hash e72d1d1)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ❌ 🛠 🧪 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 watch ✅ 🧪 mac-wk2-stress
✅ 🛠 watch-sim
✅ 🛠 🧪 unsafe-merge

@obyknovenius obyknovenius added the request-merge-queue Request a pull request to be added to merge-queue once ready label Jan 24, 2023
@webkit-ews-buildbot webkit-ews-buildbot added merging-blocked Applied to prevent a change from being merged and removed request-merge-queue Request a pull request to be added to merge-queue once ready labels Jan 24, 2023
@obyknovenius obyknovenius added the request-merge-queue Request a pull request to be added to merge-queue once ready label Jan 24, 2023
@carlosgcampos carlosgcampos added unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing and removed merging-blocked Applied to prevent a change from being merged labels Jan 31, 2023
@webkit-commit-queue
Copy link
Collaborator

Commit message contains (OOPS!) and no reviewer found, blocking PR #9024

@webkit-commit-queue webkit-commit-queue added merging-blocked Applied to prevent a change from being merged and removed unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing request-merge-queue Request a pull request to be added to merge-queue once ready labels Jan 31, 2023
@aperezdc aperezdc added unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing and removed merging-blocked Applied to prevent a change from being merged labels Jan 31, 2023
@obyknovenius @aperezdc
[ATSPI] Make Atspi::ScrollType an enum class
713642c 
https://bugs.webkit.org/show_bug.cgi?id=251076

Reviewed by Adrian Perez de Castro and Carlos Garcia Campos.

It should improve code readability.

* Source/WebCore/accessibility/atspi/AccessibilityAtspiEnums.h:
* Source/WebCore/accessibility/atspi/AccessibilityObjectAtspi.h:
* Source/WebCore/accessibility/atspi/AccessibilityObjectComponentAtspi.cpp:
(WebCore::AccessibilityObjectAtspi::scrollToMakeVisible const):
* Source/WebCore/accessibility/atspi/AccessibilityObjectTextAtspi.cpp:
(WebCore::AccessibilityObjectAtspi::scrollToMakeVisible const):

Canonical link: https://commits.webkit.org/259615@main
@webkit-commit-queue
Copy link
Collaborator

Committed 259615@main (713642c): https://commits.webkit.org/259615@main

Reviewed commits have been landed. Closing PR #9024 and removing active labels.

@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jan 31, 2023
@webkit-early-warning-system webkit-early-warning-system merged commit 713642c into WebKit:main Jan 31, 2023
@obyknovenius obyknovenius deleted the atspi/scroll-type-enum-class branch February 29, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aperezdc aperezdc aperezdc approved these changes

@carlosgcampos carlosgcampos carlosgcampos approved these changes

Assignees

@obyknovenius obyknovenius

Labels
Accessibility For bugs related to accessibility.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@obyknovenius @webkit-early-warning-system @webkit-commit-queue @aperezdc @carlosgcampos @webkit-ews-buildbot