Skip to content

Web Inspector: Timelines Tab: Screenshots: white images blend in with the background #956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 0 commits into from
May 24, 2022
Merged

Web Inspector: Timelines Tab: Screenshots: white images blend in with the background #956

merged 0 commits into from
May 24, 2022

Conversation

dcrousso
Copy link
Member

@dcrousso dcrousso commented May 24, 2022 •
edited by webkit-early-warning-system
Loading

7f96d4f

Web Inspector: Timelines Tab: Screenshots: white images blend in with the background
https://bugs.webkit.org/show_bug.cgi?id=240848

Reviewed by Patrick Angle.

* Source/WebInspectorUI/UserInterface/Views/ScreenshotsTimelineView.css:
(.timeline-view.screenshots):
(@media (prefers-color-scheme: dark) .timeline-view.screenshots): Added.

Canonical link: https://commits.webkit.org/250928@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294761 268f45cc-cd09-0410-ab3c-d52691b4dbfc

@dcrousso dcrousso self-assigned this May 24, 2022
@dcrousso dcrousso added Web Inspector Bugs related to the WebKit Web Inspector. WebKit Nightly Build labels May 24, 2022
@dcrousso dcrousso requested a review from patrickangle May 24, 2022 01:47
@webkit-early-warning-system webkit-early-warning-system added the merging-blocked Applied to prevent a change from being merged label May 24, 2022
patrickangle
patrickangle approved these changes May 24, 2022
View reviewed changes
@dcrousso dcrousso added merge-queue Applied to send a pull request to merge-queue and removed merging-blocked Applied to prevent a change from being merged labels May 24, 2022
@webkit-early-warning-system webkit-early-warning-system merged commit 7f96d4f into WebKit:main May 24, 2022
@webkit-early-warning-system
Copy link
Collaborator

Committed r294761 (250928@main): https://commits.webkit.org/250928@main

Reviewed commits have been landed. Closing PR #956 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system removed the merge-queue Applied to send a pull request to merge-queue label May 24, 2022
@dcrousso dcrousso deleted the eng/240848 branch May 24, 2022 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickangle patrickangle patrickangle approved these changes

Assignees

@dcrousso dcrousso

Labels
Web Inspector Bugs related to the WebKit Web Inspector.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dcrousso @webkit-early-warning-system @patrickangle