Skip to content

Conversation

Lonniebiz
Copy link
Contributor

Some of my changes are helpful, but please review to make sure they are 100% correct.

Some of my changes are helpful, but please review to make sure they are 100% correct.
@coveralls
Copy link

coveralls commented Nov 29, 2018

Pull Request Test Coverage Report for Build 735

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at ?%

Totals Coverage Status
Change from base Build 733: 0.0%
Covered Lines:
Relevant Lines: 0

💛 - Coveralls

Copy link
Owner

@WebReflection WebReflection left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please leave it as it was or make it more meaningful, thanks

@Lonniebiz
Copy link
Contributor Author

Sorry, I don't have much experience with github. Perhaps, I tried to edit too much at once.

Most importantly, I thought my edits to the comment on fragments made the comment more explicit and quicker to fully understand.

@WebReflection
Copy link
Owner

I thought my edits to the comment on fragments made the comment more explicit and quicker to fully understand.

all but one, because tag function is a specific term, while tag a function means nothing in that context.

WebReflection pushed a commit that referenced this pull request Nov 29, 2018
@WebReflection
Copy link
Owner

Look, I've manually pushed those other two so it should be good now. Thanks anyway!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants