Skip to content

deleting teams route #502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 3, 2023
Merged

Conversation

s2sharpit
Copy link
Member

Related Issue

  • Information about the related issue

Closes: #501

Describe the changes you've made

Deleting teams route which is redirecting from /teams to /team

Type of change

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update.
  • This change requires a documentation update

How Has This Been Tested?

Checklist

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented on my code, particularly wherever it was hard to understand.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • Any dependent changes have been merged and published in downstream modules.

Screenshots (if applicable)

Original Updated
original screenshot updated screenshot

Code of Conduct

Signed-off-by: Tushar Saini <s2sharpit@gmail.com>
@s2sharpit s2sharpit requested review from Panquesito7 and a team as code owners August 2, 2023 12:02
@vercel
Copy link

vercel bot commented Aug 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
webxdao-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 2, 2023 0:03am

@s2sharpit
Copy link
Member Author

Hey @Anmol-Baranwal & @vinzvinci
Kindly review this PR.

@Anmol-Baranwal
Copy link
Member

@s2sharpit
Did you check this?

Read the title
image

I was looking at the codebase, and noticed this. Let others review this.

@s2sharpit
Copy link
Member Author

s2sharpit commented Aug 3, 2023

@s2sharpit Did you check this?
I was looking at the codebase, and noticed this. Let others review this.

Yes, I checked.
The WebX Team page has undergone a route change from /teams to /team #475, so a temporary redirect was added for that. Now that a month has passed, we should proceed with the removal of the redirect.
What do you say @vinzvinci & @Panquesito7

@Anmol-Baranwal
Copy link
Member

@mkubdev
Please let us know your opinion.

@s2sharpit Did you check this?
I was looking at the codebase, and noticed this. Let others review this.

Yes, I checked. The WebX Team page has undergone a route change from /teams to /team #475, so a temporary redirect was added for that. Now that a month has passed, we should proceed with the removal of the redirect. What do you say @vinzvinci & @Panquesito7

@mkubdev
Copy link
Contributor

mkubdev commented Aug 3, 2023

@s2sharpit @Anmol-Baranwal @vinzvinci

Yes indeed, the redirect was a temp fix, please feel free to remove it! :)

Copy link
Member

@Anmol-Baranwal Anmol-Baranwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Looks good to me.

Copy link
Member

@vinzvinci vinzvinci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Can we merge it fast? need to update the current team

@Anmol-Baranwal

@Anmol-Baranwal Anmol-Baranwal merged commit 8ca387f into WebXDAO:main Aug 3, 2023
@Anmol-Baranwal Anmol-Baranwal added gssoc23 Used for GirlScript Summer of Code 2023 level1 Documentation/Minor bug Fix labels Aug 3, 2023
@s2sharpit s2sharpit deleted the delete-teams branch August 3, 2023 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc23 Used for GirlScript Summer of Code 2023 level1 Documentation/Minor bug Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

To delete teams page which is redirecting from /teams to /team
4 participants